linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [GIT PULL] thermal for v5.14-rc1
@ 2021-07-03 16:17 Daniel Lezcano
  2021-07-03 19:34 ` Linus Torvalds
  0 siblings, 1 reply; 7+ messages in thread
From: Daniel Lezcano @ 2021-07-03 16:17 UTC (permalink / raw)
  To: Linus Torvalds
  Cc: Zhang Rui, Linux PM mailing list, Linux Kernel Mailing List,
	Chunyan Zhang, Srinivas Pandruvada, Rajeshwari Ravindra Kamble,
	Yang Yingliang, Niklas Söderlund, Krzysztof Kozlowski,
	Dmitry Osipenko, Ezequiel Garcia, Bjorn Andersson,
	Andy Shevchenko, Yangtao Li, Finley Xiao

The following changes since commit 614124bea77e452aa6df7a8714e8bc820b489922:

  Linux 5.13-rc5 (2021-06-06 15:47:27 -0700)

are available in the Git repository at:


ssh://git@gitolite.kernel.org/pub/scm/linux/kernel/git/thermal/linux.git
tags/thermal-v5.14-rc1

for you to fetch changes up to 1264017b3ab6d903760673a8515180af6e7a7f28:

  thermal/drivers/int340x/processor_thermal: Fix tcc setting (2021-06-29
08:15:53 +0200)

----------------------------------------------------------------
- Add rk3568 sensor support (Finley Xiao)

- Add missing MODULE_DEVICE_TABLE for the Spreadtrum sensor (Chunyan
  Zhang)

- Export additionnal attributes for the int340x thermal processor
  (Srinivas Pandruvada)

- Add SC7280 compatible for the tsens driver (Rajeshwari Ravindra
  Kamble)

- Fix kernel documentation for thermal_zone_device_unregister()	and
  use devm_platform_get_and_ioremap_resource() (Yang Yingliang)

- Fix coefficient calculations for the rcar_gen3 sensor driver (Niklas
  Söderlund)

- Fix shadowing variable rcar_gen3_ths_tj_1 (Geert Uytterhoeven)

- Add missing of_node_put() for the iMX and Spreadtrum sensors
  (Krzysztof Kozlowski)

- Correct compile-testing of tegra drivers, add tegra3 DT bindings and
  new thermal sensor for tegra3 (Dmitry Osipenko)

- Stop the thermal zone monitoring when unregistering it to prevent a
  temperature update without the 'get_temp' callback (Dmitry Osipenko)

- Add rk3568 DT bindings, convert bindings to yaml schemas and add the
  corresponding compatible in the Rockchip sensor (Ezequiel Garcia)

- Add the sc8180x compatible for the Qualcomm tsensor (Bjorn Andersson)

- Use the find_first_zero_bit()	function instead of custom code (Andy
  Shevchenko)

- Fix the kernel doc for the device cooling device (Yang Li)

- Reorg the processor thermal int340x to set the scene for the PCI
  mmio driver (Srinivas Pandruvada)

- Add PCI MMIO driver for the int340x processor thermal driver
  (Srinivas Pandruvada)

- Add hwmon sensors for the mediatek sensor (Frank Wunderlich)

- Fix warning for return value reported by Smatch for the int340x
  thermal processor (Srinivas Pandruvada)

- Fix wrong register access and decoding for the int340x thermal
  processor (Srinivas Pandruvada)

----------------------------------------------------------------
Andy Shevchenko (1):
      thermal/drivers/intel/intel_soc_dts_iosf: Switch to use
find_first_zero_bit()

Bjorn Andersson (1):
      dt-bindings: thermal: tsens: Add sc8180x compatible

Chunyan Zhang (1):
      thermal/drivers/sprd: Add missing MODULE_DEVICE_TABLE

Dmitry Osipenko (4):
      thermal/drivers/tegra: Correct compile-testing of drivers
      dt-bindings: thermal: Add binding for Tegra30 thermal sensor
      thermal/core/thermal_of: Stop zone device before unregistering it
      thermal/drivers/tegra: Add driver for Tegra30 thermal sensor

Ezequiel Garcia (2):
      dt-bindings: thermal: convert rockchip-thermal to json-schema
      dt-bindings: rockchip-thermal: Support the RK3568 SoC compatible

Finley Xiao (1):
      thermal/drivers/rockchip: Support RK3568 SoCs in the thermal driver

Frank Wunderlich (1):
      thermal/drivers/mediatek: Add sensors-support

Geert Uytterhoeven (1):
      thermal/drivers/rcar_gen3_thermal: Do not shadow rcar_gen3_ths_tj_1

Krzysztof Kozlowski (2):
      thermal/drivers/imx_sc: Add missing of_node_put for loop iteration
      thermal/drivers/sprd: Add missing of_node_put for loop iteration

Niklas Söderlund (1):
      thermal/drivers/rcar_gen3_thermal: Fix coefficient calculations

Rajeshwari Ravindra Kamble (1):
      dt-bindings: thermal: tsens: Add compatible string to TSENS
binding for SC7280

Srinivas Pandruvada (6):
      thermal/drivers/int340x: processor_thermal: Export mailbox interface
      thermal/drivers/int340x: processor_thermal: Export additional
attributes
      thermal/drivers/int340x/processor_thermal: Split enumeration and
processing part
      thermal/drivers/int340x/processor_thermal: Add PCI MMIO based
thermal driver
      thermal/drivers/int340x/processor_thermal: Fix warning for return
value
      thermal/drivers/int340x/processor_thermal: Fix tcc setting

Yang Li (1):
      thermal: devfreq_cooling: Fix kernel-doc

Yang Yingliang (2):
      thermal/core: Correct function name thermal_zone_device_unregister()
      thermal/drivers/st: Use devm_platform_get_and_ioremap_resource()

 .../bindings/thermal/nvidia,tegra30-tsensor.yaml   |  73 +++
 .../devicetree/bindings/thermal/qcom-tsens.yaml    |   2 +
 .../bindings/thermal/rockchip-thermal.txt          |  85 ---
 .../bindings/thermal/rockchip-thermal.yaml         |  96 +++
 drivers/thermal/devfreq_cooling.c                  |   2 +-
 drivers/thermal/imx_sc_thermal.c                   |   3 +
 drivers/thermal/intel/int340x_thermal/Makefile     |   3 +
 .../intel/int340x_thermal/int3401_thermal.c        |  82 +++
 .../int340x_thermal/processor_thermal_device.c     | 309 ++--------
 .../int340x_thermal/processor_thermal_device.h     |   9 +
 .../int340x_thermal/processor_thermal_device_pci.c | 373 ++++++++++++
 .../processor_thermal_device_pci_legacy.c          | 163 +++++
 .../intel/int340x_thermal/processor_thermal_mbox.c |  12 +-
 .../intel/int340x_thermal/processor_thermal_rfim.c |  55 ++
 drivers/thermal/intel/intel_soc_dts_iosf.c         |  15 +-
 drivers/thermal/mtk_thermal.c                      |   6 +
 drivers/thermal/rcar_gen3_thermal.c                |   7 +-
 drivers/thermal/rockchip_thermal.c                 | 121 ++++
 drivers/thermal/sprd_thermal.c                     |  16 +-
 drivers/thermal/st/st_thermal_memmap.c             |  13 +-
 drivers/thermal/tegra/Kconfig                      |   9 +-
 drivers/thermal/tegra/Makefile                     |   1 +
 drivers/thermal/tegra/tegra30-tsensor.c            | 673
+++++++++++++++++++++
 drivers/thermal/thermal_core.c                     |   2 +-
 drivers/thermal/thermal_of.c                       |   3 +
 25 files changed, 1748 insertions(+), 385 deletions(-)
 create mode 100644
Documentation/devicetree/bindings/thermal/nvidia,tegra30-tsensor.yaml
 delete mode 100644
Documentation/devicetree/bindings/thermal/rockchip-thermal.txt
 create mode 100644
Documentation/devicetree/bindings/thermal/rockchip-thermal.yaml
 create mode 100644 drivers/thermal/intel/int340x_thermal/int3401_thermal.c
 create mode 100644
drivers/thermal/intel/int340x_thermal/processor_thermal_device_pci.c
 create mode 100644
drivers/thermal/intel/int340x_thermal/processor_thermal_device_pci_legacy.c
 create mode 100644 drivers/thermal/tegra/tegra30-tsensor.c

-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [GIT PULL] thermal for v5.14-rc1
  2021-07-03 16:17 [GIT PULL] thermal for v5.14-rc1 Daniel Lezcano
@ 2021-07-03 19:34 ` Linus Torvalds
  2021-07-03 19:56   ` Dmitry Osipenko
  0 siblings, 1 reply; 7+ messages in thread
From: Linus Torvalds @ 2021-07-03 19:34 UTC (permalink / raw)
  To: Daniel Lezcano
  Cc: Zhang Rui, Linux PM mailing list, Linux Kernel Mailing List,
	Chunyan Zhang, Srinivas Pandruvada, Rajeshwari Ravindra Kamble,
	Yang Yingliang, Niklas Söderlund, Krzysztof Kozlowski,
	Dmitry Osipenko, Ezequiel Garcia, Bjorn Andersson,
	Andy Shevchenko, Yangtao Li, Finley Xiao

On Sat, Jul 3, 2021 at 9:17 AM Daniel Lezcano <daniel.lezcano@linaro.org> wrote:
>
> ssh://git@gitolite.kernel.org/pub/scm/linux/kernel/git/thermal/linux.git
> tags/thermal-v5.14-rc1

This does not build for me. And I suspect it never built in linux-next either.

I get

  ERROR: modpost: "tegra_fuse_readl"
[drivers/thermal/tegra/tegra30-tsensor.ko] undefined!
  ERROR: modpost: "tegra_fuse_readl"
[drivers/thermal/tegra/tegra-soctherm.ko] undefined!
  make[1]: *** [scripts/Makefile.modpost:150: modules-only.symvers] Error 1
  make[1]: *** Deleting file 'modules-only.symvers'
  make: *** [Makefile:1762: modules] Error 2

and I think it's due to that commit 1f9c5936b10c
("thermal/drivers/tegra: Correct compile-testing of drivers") which
quite sensibly tries to extend build coverage for the tegra thermal
drivers, but that build coverage doesn't actually *work* outside the
tegra world.

That commit says "All Tegra thermal drivers support compile-testing",
but clearly they stumble at the last hurdle.

I made the decision to just unpull this, not because I couldn't fix
it, but because if it was this untested, I don't want to worry about
all the *other* code in there too.

               Linus

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [GIT PULL] thermal for v5.14-rc1
  2021-07-03 19:34 ` Linus Torvalds
@ 2021-07-03 19:56   ` Dmitry Osipenko
  2021-07-04  9:51     ` Daniel Lezcano
  0 siblings, 1 reply; 7+ messages in thread
From: Dmitry Osipenko @ 2021-07-03 19:56 UTC (permalink / raw)
  To: Linus Torvalds, Daniel Lezcano
  Cc: Zhang Rui, Linux PM mailing list, Linux Kernel Mailing List,
	Chunyan Zhang, Srinivas Pandruvada, Rajeshwari Ravindra Kamble,
	Yang Yingliang, Niklas Söderlund, Krzysztof Kozlowski,
	Ezequiel Garcia, Bjorn Andersson, Andy Shevchenko, Yangtao Li,
	Finley Xiao

03.07.2021 22:34, Linus Torvalds пишет:
> On Sat, Jul 3, 2021 at 9:17 AM Daniel Lezcano <daniel.lezcano@linaro.org> wrote:
>>
>> ssh://git@gitolite.kernel.org/pub/scm/linux/kernel/git/thermal/linux.git
>> tags/thermal-v5.14-rc1
> 
> This does not build for me. And I suspect it never built in linux-next either.
> 
> I get
> 
>   ERROR: modpost: "tegra_fuse_readl"
> [drivers/thermal/tegra/tegra30-tsensor.ko] undefined!
>   ERROR: modpost: "tegra_fuse_readl"
> [drivers/thermal/tegra/tegra-soctherm.ko] undefined!
>   make[1]: *** [scripts/Makefile.modpost:150: modules-only.symvers] Error 1
>   make[1]: *** Deleting file 'modules-only.symvers'
>   make: *** [Makefile:1762: modules] Error 2
> 
> and I think it's due to that commit 1f9c5936b10c
> ("thermal/drivers/tegra: Correct compile-testing of drivers") which
> quite sensibly tries to extend build coverage for the tegra thermal
> drivers, but that build coverage doesn't actually *work* outside the
> tegra world.
> 
> That commit says "All Tegra thermal drivers support compile-testing",
> but clearly they stumble at the last hurdle.
> 
> I made the decision to just unpull this, not because I couldn't fix
> it, but because if it was this untested, I don't want to worry about
> all the *other* code in there too.

It was tested in linux-next for about two weeks and it was a known
problem already [1], sorry again. The compile-testing depends on the
patch [2] that should come with the ARM32 PR. The linux-next was okay
because [2] got first into -next and I forgot about it. It will be fine
to defer these Tegra patches till the next release if this is the
easiest solution.

[1]
https://lore.kernel.org/linux-devicetree/20210616190417.32214-7-digetx@gmail.com/T/#m354e679e93c4f84e26d5e630423e47317d0c2edc

[2]
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=30b44e81772a5caa983000057ce1cd9cb4531647

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [GIT PULL] thermal for v5.14-rc1
  2021-07-03 19:56   ` Dmitry Osipenko
@ 2021-07-04  9:51     ` Daniel Lezcano
  2021-07-04 12:04       ` Dmitry Osipenko
  0 siblings, 1 reply; 7+ messages in thread
From: Daniel Lezcano @ 2021-07-04  9:51 UTC (permalink / raw)
  To: Dmitry Osipenko, Linus Torvalds
  Cc: Zhang Rui, Linux PM mailing list, Linux Kernel Mailing List,
	Chunyan Zhang, Srinivas Pandruvada, Rajeshwari Ravindra Kamble,
	Yang Yingliang, Niklas Söderlund, Krzysztof Kozlowski,
	Ezequiel Garcia, Bjorn Andersson, Andy Shevchenko, Yangtao Li,
	Finley Xiao

On 03/07/2021 21:56, Dmitry Osipenko wrote:
> 03.07.2021 22:34, Linus Torvalds пишет:
>> On Sat, Jul 3, 2021 at 9:17 AM Daniel Lezcano <daniel.lezcano@linaro.org> wrote:
>>>
>>> ssh://git@gitolite.kernel.org/pub/scm/linux/kernel/git/thermal/linux.git
>>> tags/thermal-v5.14-rc1
>>
>> This does not build for me. And I suspect it never built in linux-next either.
>>
>> I get
>>
>>   ERROR: modpost: "tegra_fuse_readl"
>> [drivers/thermal/tegra/tegra30-tsensor.ko] undefined!
>>   ERROR: modpost: "tegra_fuse_readl"
>> [drivers/thermal/tegra/tegra-soctherm.ko] undefined!
>>   make[1]: *** [scripts/Makefile.modpost:150: modules-only.symvers] Error 1
>>   make[1]: *** Deleting file 'modules-only.symvers'
>>   make: *** [Makefile:1762: modules] Error 2
>>
>> and I think it's due to that commit 1f9c5936b10c
>> ("thermal/drivers/tegra: Correct compile-testing of drivers") which
>> quite sensibly tries to extend build coverage for the tegra thermal
>> drivers, but that build coverage doesn't actually *work* outside the
>> tegra world.
>>
>> That commit says "All Tegra thermal drivers support compile-testing",
>> but clearly they stumble at the last hurdle.
>>
>> I made the decision to just unpull this, not because I couldn't fix
>> it, but because if it was this untested, I don't want to worry about
>> all the *other* code in there too.
> 
> It was tested in linux-next for about two weeks and it was a known
> problem already [1], sorry again. The compile-testing depends on the
> patch [2] that should come with the ARM32 PR. The linux-next was okay
> because [2] got first into -next and I forgot about it. It will be fine
> to defer these Tegra patches till the next release if this is the
> easiest solution.

My bad, I did a wrong decision assuming the ARM32 branch would be
already there when pulling the thermal branch.

I'll remove the patches.

Sorry for the inconvenience.




-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [GIT PULL] thermal for v5.14-rc1
  2021-07-04  9:51     ` Daniel Lezcano
@ 2021-07-04 12:04       ` Dmitry Osipenko
  2021-07-04 13:19         ` Daniel Lezcano
  0 siblings, 1 reply; 7+ messages in thread
From: Dmitry Osipenko @ 2021-07-04 12:04 UTC (permalink / raw)
  To: Daniel Lezcano
  Cc: Zhang Rui, Linux PM mailing list, Linux Kernel Mailing List,
	Chunyan Zhang, Srinivas Pandruvada, Rajeshwari Ravindra Kamble,
	Yang Yingliang, Niklas Söderlund, Krzysztof Kozlowski,
	Ezequiel Garcia, Bjorn Andersson, Andy Shevchenko, Yangtao Li,
	Finley Xiao, Linus Torvalds

04.07.2021 12:51, Daniel Lezcano пишет:
> On 03/07/2021 21:56, Dmitry Osipenko wrote:
>> 03.07.2021 22:34, Linus Torvalds пишет:
>>> On Sat, Jul 3, 2021 at 9:17 AM Daniel Lezcano <daniel.lezcano@linaro.org> wrote:
>>>>
>>>> ssh://git@gitolite.kernel.org/pub/scm/linux/kernel/git/thermal/linux.git
>>>> tags/thermal-v5.14-rc1
>>>
>>> This does not build for me. And I suspect it never built in linux-next either.
>>>
>>> I get
>>>
>>>   ERROR: modpost: "tegra_fuse_readl"
>>> [drivers/thermal/tegra/tegra30-tsensor.ko] undefined!
>>>   ERROR: modpost: "tegra_fuse_readl"
>>> [drivers/thermal/tegra/tegra-soctherm.ko] undefined!
>>>   make[1]: *** [scripts/Makefile.modpost:150: modules-only.symvers] Error 1
>>>   make[1]: *** Deleting file 'modules-only.symvers'
>>>   make: *** [Makefile:1762: modules] Error 2
>>>
>>> and I think it's due to that commit 1f9c5936b10c
>>> ("thermal/drivers/tegra: Correct compile-testing of drivers") which
>>> quite sensibly tries to extend build coverage for the tegra thermal
>>> drivers, but that build coverage doesn't actually *work* outside the
>>> tegra world.
>>>
>>> That commit says "All Tegra thermal drivers support compile-testing",
>>> but clearly they stumble at the last hurdle.
>>>
>>> I made the decision to just unpull this, not because I couldn't fix
>>> it, but because if it was this untested, I don't want to worry about
>>> all the *other* code in there too.
>>
>> It was tested in linux-next for about two weeks and it was a known
>> problem already [1], sorry again. The compile-testing depends on the
>> patch [2] that should come with the ARM32 PR. The linux-next was okay
>> because [2] got first into -next and I forgot about it. It will be fine
>> to defer these Tegra patches till the next release if this is the
>> easiest solution.
> 
> My bad, I did a wrong decision assuming the ARM32 branch would be
> already there when pulling the thermal branch.
> 
> I'll remove the patches.
> 
> Sorry for the inconvenience.

Daniel, please let me know if I will need to resend the thermal patches
for 5.15.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [GIT PULL] thermal for v5.14-rc1
  2021-07-04 12:04       ` Dmitry Osipenko
@ 2021-07-04 13:19         ` Daniel Lezcano
  2021-07-04 13:28           ` Dmitry Osipenko
  0 siblings, 1 reply; 7+ messages in thread
From: Daniel Lezcano @ 2021-07-04 13:19 UTC (permalink / raw)
  To: Dmitry Osipenko
  Cc: Zhang Rui, Linux PM mailing list, Linux Kernel Mailing List,
	Chunyan Zhang, Srinivas Pandruvada, Rajeshwari Ravindra Kamble,
	Yang Yingliang, Niklas Söderlund, Krzysztof Kozlowski,
	Ezequiel Garcia, Bjorn Andersson, Andy Shevchenko, Yangtao Li,
	Finley Xiao, Linus Torvalds

On 04/07/2021 14:04, Dmitry Osipenko wrote:
> 04.07.2021 12:51, Daniel Lezcano пишет:
>> On 03/07/2021 21:56, Dmitry Osipenko wrote:
>>> 03.07.2021 22:34, Linus Torvalds пишет:
>>>> On Sat, Jul 3, 2021 at 9:17 AM Daniel Lezcano <daniel.lezcano@linaro.org> wrote:
>>>>>
>>>>> ssh://git@gitolite.kernel.org/pub/scm/linux/kernel/git/thermal/linux.git
>>>>> tags/thermal-v5.14-rc1
>>>>
>>>> This does not build for me. And I suspect it never built in linux-next either.
>>>>
>>>> I get
>>>>
>>>>   ERROR: modpost: "tegra_fuse_readl"
>>>> [drivers/thermal/tegra/tegra30-tsensor.ko] undefined!
>>>>   ERROR: modpost: "tegra_fuse_readl"
>>>> [drivers/thermal/tegra/tegra-soctherm.ko] undefined!
>>>>   make[1]: *** [scripts/Makefile.modpost:150: modules-only.symvers] Error 1
>>>>   make[1]: *** Deleting file 'modules-only.symvers'
>>>>   make: *** [Makefile:1762: modules] Error 2
>>>>
>>>> and I think it's due to that commit 1f9c5936b10c
>>>> ("thermal/drivers/tegra: Correct compile-testing of drivers") which
>>>> quite sensibly tries to extend build coverage for the tegra thermal
>>>> drivers, but that build coverage doesn't actually *work* outside the
>>>> tegra world.
>>>>
>>>> That commit says "All Tegra thermal drivers support compile-testing",
>>>> but clearly they stumble at the last hurdle.
>>>>
>>>> I made the decision to just unpull this, not because I couldn't fix
>>>> it, but because if it was this untested, I don't want to worry about
>>>> all the *other* code in there too.
>>>
>>> It was tested in linux-next for about two weeks and it was a known
>>> problem already [1], sorry again. The compile-testing depends on the
>>> patch [2] that should come with the ARM32 PR. The linux-next was okay
>>> because [2] got first into -next and I forgot about it. It will be fine
>>> to defer these Tegra patches till the next release if this is the
>>> easiest solution.
>>
>> My bad, I did a wrong decision assuming the ARM32 branch would be
>> already there when pulling the thermal branch.
>>
>> I'll remove the patches.
>>
>> Sorry for the inconvenience.
> 
> Daniel, please let me know if I will need to resend the thermal patches
> for 5.15.

I'll drop:

"thermal/drivers/tegra: Add driver for Tegra30 thermal sensor"
"thermal/drivers/tegra: Correct compile-testing of drivers"

but keep the bindings.

It won't be necessary to resend them.

Thanks
  -- Daniel

-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [GIT PULL] thermal for v5.14-rc1
  2021-07-04 13:19         ` Daniel Lezcano
@ 2021-07-04 13:28           ` Dmitry Osipenko
  0 siblings, 0 replies; 7+ messages in thread
From: Dmitry Osipenko @ 2021-07-04 13:28 UTC (permalink / raw)
  To: Daniel Lezcano
  Cc: Zhang Rui, Linux PM mailing list, Linux Kernel Mailing List,
	Chunyan Zhang, Srinivas Pandruvada, Rajeshwari Ravindra Kamble,
	Yang Yingliang, Niklas Söderlund, Krzysztof Kozlowski,
	Ezequiel Garcia, Bjorn Andersson, Andy Shevchenko, Yangtao Li,
	Finley Xiao, Linus Torvalds

04.07.2021 16:19, Daniel Lezcano пишет:
> On 04/07/2021 14:04, Dmitry Osipenko wrote:
>> 04.07.2021 12:51, Daniel Lezcano пишет:
>>> On 03/07/2021 21:56, Dmitry Osipenko wrote:
>>>> 03.07.2021 22:34, Linus Torvalds пишет:
>>>>> On Sat, Jul 3, 2021 at 9:17 AM Daniel Lezcano <daniel.lezcano@linaro.org> wrote:
>>>>>>
>>>>>> ssh://git@gitolite.kernel.org/pub/scm/linux/kernel/git/thermal/linux.git
>>>>>> tags/thermal-v5.14-rc1
>>>>>
>>>>> This does not build for me. And I suspect it never built in linux-next either.
>>>>>
>>>>> I get
>>>>>
>>>>>   ERROR: modpost: "tegra_fuse_readl"
>>>>> [drivers/thermal/tegra/tegra30-tsensor.ko] undefined!
>>>>>   ERROR: modpost: "tegra_fuse_readl"
>>>>> [drivers/thermal/tegra/tegra-soctherm.ko] undefined!
>>>>>   make[1]: *** [scripts/Makefile.modpost:150: modules-only.symvers] Error 1
>>>>>   make[1]: *** Deleting file 'modules-only.symvers'
>>>>>   make: *** [Makefile:1762: modules] Error 2
>>>>>
>>>>> and I think it's due to that commit 1f9c5936b10c
>>>>> ("thermal/drivers/tegra: Correct compile-testing of drivers") which
>>>>> quite sensibly tries to extend build coverage for the tegra thermal
>>>>> drivers, but that build coverage doesn't actually *work* outside the
>>>>> tegra world.
>>>>>
>>>>> That commit says "All Tegra thermal drivers support compile-testing",
>>>>> but clearly they stumble at the last hurdle.
>>>>>
>>>>> I made the decision to just unpull this, not because I couldn't fix
>>>>> it, but because if it was this untested, I don't want to worry about
>>>>> all the *other* code in there too.
>>>>
>>>> It was tested in linux-next for about two weeks and it was a known
>>>> problem already [1], sorry again. The compile-testing depends on the
>>>> patch [2] that should come with the ARM32 PR. The linux-next was okay
>>>> because [2] got first into -next and I forgot about it. It will be fine
>>>> to defer these Tegra patches till the next release if this is the
>>>> easiest solution.
>>>
>>> My bad, I did a wrong decision assuming the ARM32 branch would be
>>> already there when pulling the thermal branch.
>>>
>>> I'll remove the patches.
>>>
>>> Sorry for the inconvenience.
>>
>> Daniel, please let me know if I will need to resend the thermal patches
>> for 5.15.
> 
> I'll drop:
> 
> "thermal/drivers/tegra: Add driver for Tegra30 thermal sensor"
> "thermal/drivers/tegra: Correct compile-testing of drivers"
> 
> but keep the bindings.
> 
> It won't be necessary to resend them.

Great, thank you!


^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2021-07-04 13:28 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-03 16:17 [GIT PULL] thermal for v5.14-rc1 Daniel Lezcano
2021-07-03 19:34 ` Linus Torvalds
2021-07-03 19:56   ` Dmitry Osipenko
2021-07-04  9:51     ` Daniel Lezcano
2021-07-04 12:04       ` Dmitry Osipenko
2021-07-04 13:19         ` Daniel Lezcano
2021-07-04 13:28           ` Dmitry Osipenko

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).