* [PATCH] binfmt: a.out: Fix bogus semicolon
@ 2021-09-05 9:30 Geert Uytterhoeven
2021-09-05 19:29 ` David Hildenbrand
0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2021-09-05 9:30 UTC (permalink / raw)
To: Linus Torvalds, David Hildenbrand, Alexander Viro
Cc: Christian König, Eric W . Biederman, linux-fsdevel,
linux-kernel, Geert Uytterhoeven, noreply
fs/binfmt_aout.c: In function ‘load_aout_library’:
fs/binfmt_aout.c:311:27: error: expected ‘)’ before ‘;’ token
311 | MAP_FIXED | MAP_PRIVATE;
| ^
fs/binfmt_aout.c:309:10: error: too few arguments to function ‘vm_mmap’
309 | error = vm_mmap(file, start_addr, ex.a_text + ex.a_data,
| ^~~~~~~
In file included from fs/binfmt_aout.c:12:
include/linux/mm.h:2626:35: note: declared here
2626 | extern unsigned long __must_check vm_mmap(struct file *, unsigned long,
| ^~~~~~~
Fix this by reverting the accidental replacement of a comma by a
semicolon.
Fixes: 42be8b42535183f8 ("binfmt: don't use MAP_DENYWRITE when loading shared libraries via uselib()")
Reported-by: noreply@ellerman.id.au
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
fs/binfmt_aout.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/binfmt_aout.c b/fs/binfmt_aout.c
index a47496d0f123355c..0dcfc691e7e218bc 100644
--- a/fs/binfmt_aout.c
+++ b/fs/binfmt_aout.c
@@ -308,7 +308,7 @@ static int load_aout_library(struct file *file)
/* Now use mmap to map the library into memory. */
error = vm_mmap(file, start_addr, ex.a_text + ex.a_data,
PROT_READ | PROT_WRITE | PROT_EXEC,
- MAP_FIXED | MAP_PRIVATE;
+ MAP_FIXED | MAP_PRIVATE,
N_TXTOFF(ex));
retval = error;
if (error != start_addr)
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] binfmt: a.out: Fix bogus semicolon
2021-09-05 9:30 [PATCH] binfmt: a.out: Fix bogus semicolon Geert Uytterhoeven
@ 2021-09-05 19:29 ` David Hildenbrand
0 siblings, 0 replies; 2+ messages in thread
From: David Hildenbrand @ 2021-09-05 19:29 UTC (permalink / raw)
To: Geert Uytterhoeven, Linus Torvalds, Alexander Viro
Cc: Christian König, Eric W . Biederman, linux-fsdevel,
linux-kernel, noreply
On 05.09.21 11:30, Geert Uytterhoeven wrote:
> fs/binfmt_aout.c: In function ‘load_aout_library’:
> fs/binfmt_aout.c:311:27: error: expected ‘)’ before ‘;’ token
> 311 | MAP_FIXED | MAP_PRIVATE;
> | ^
> fs/binfmt_aout.c:309:10: error: too few arguments to function ‘vm_mmap’
> 309 | error = vm_mmap(file, start_addr, ex.a_text + ex.a_data,
> | ^~~~~~~
> In file included from fs/binfmt_aout.c:12:
> include/linux/mm.h:2626:35: note: declared here
> 2626 | extern unsigned long __must_check vm_mmap(struct file *, unsigned long,
> | ^~~~~~~
>
> Fix this by reverting the accidental replacement of a comma by a
> semicolon.
>
> Fixes: 42be8b42535183f8 ("binfmt: don't use MAP_DENYWRITE when loading shared libraries via uselib()")
> Reported-by: noreply@ellerman.id.au
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
> fs/binfmt_aout.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/binfmt_aout.c b/fs/binfmt_aout.c
> index a47496d0f123355c..0dcfc691e7e218bc 100644
> --- a/fs/binfmt_aout.c
> +++ b/fs/binfmt_aout.c
> @@ -308,7 +308,7 @@ static int load_aout_library(struct file *file)
> /* Now use mmap to map the library into memory. */
> error = vm_mmap(file, start_addr, ex.a_text + ex.a_data,
> PROT_READ | PROT_WRITE | PROT_EXEC,
> - MAP_FIXED | MAP_PRIVATE;
> + MAP_FIXED | MAP_PRIVATE,
> N_TXTOFF(ex));
> retval = error;
> if (error != start_addr)
>
Reviewed-by: David Hildenbrand <david@redhat.com>
Thanks for reporting and fixing that quickly!
--
Thanks,
David / dhildenb
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-09-05 19:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-05 9:30 [PATCH] binfmt: a.out: Fix bogus semicolon Geert Uytterhoeven
2021-09-05 19:29 ` David Hildenbrand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).