From: Chao Yu <chao@kernel.org>
To: Gao Xiang <hsiangkao@linux.alibaba.com>, linux-erofs@lists.ozlabs.org
Cc: linux-fsdevel@vger.kernel.org, nvdimm@lists.linux.dev,
LKML <linux-kernel@vger.kernel.org>,
"Darrick J. Wong" <djwong@kernel.org>,
Liu Bo <bo.liu@linux.alibaba.com>,
Joseph Qi <joseph.qi@linux.alibaba.com>,
Liu Jiang <gerry@linux.alibaba.com>,
Huang Jianan <huangjianan@oppo.com>, Tao Ma <boyu.mt@taobao.com>
Subject: Re: [PATCH v3 2/3] erofs: dax support for non-tailpacking regular file
Date: Thu, 5 Aug 2021 11:01:43 +0800 [thread overview]
Message-ID: <7aa650b8-a853-368d-7a81-f435194eec33@kernel.org> (raw)
In-Reply-To: <20210805003601.183063-3-hsiangkao@linux.alibaba.com>
On 2021/8/5 8:36, Gao Xiang wrote:
> DAX is quite useful for some VM use cases in order to save guest
> memory extremely with minimal lightweight EROFS.
>
> In order to prepare for such use cases, add preliminary dax support
> for non-tailpacking regular files for now.
>
> Tested with the DRAM-emulated PMEM and the EROFS image generated by
> "mkfs.erofs -Enoinline_data enwik9.fsdax.img enwik9"
>
> Cc: nvdimm@lists.linux.dev
> Cc: linux-fsdevel@vger.kernel.org
> Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
> ---
> Documentation/filesystems/erofs.rst | 2 +
> fs/erofs/data.c | 42 +++++++++++++++++++-
> fs/erofs/inode.c | 4 ++
> fs/erofs/internal.h | 3 ++
> fs/erofs/super.c | 59 ++++++++++++++++++++++++++++-
> 5 files changed, 106 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/filesystems/erofs.rst b/Documentation/filesystems/erofs.rst
> index 832839fcf4c3..ffd2ae7be511 100644
> --- a/Documentation/filesystems/erofs.rst
> +++ b/Documentation/filesystems/erofs.rst
> @@ -84,6 +84,8 @@ cache_strategy=%s Select a strategy for cached decompression from now on:
> It still does in-place I/O decompression
> for the rest compressed physical clusters.
> ========== =============================================
> +dax Use direct access (no page cache). See
dax or dax=%s
Otherwise, it looks good to me.
Reviewed-by: Chao Yu <chao@kernel.org>
Thanks,
next prev parent reply other threads:[~2021-08-05 3:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-05 0:35 [PATCH v3 0/3] erofs: iomap support for uncompressed cases Gao Xiang
2021-08-05 0:35 ` [PATCH v3 1/3] erofs: iomap support for non-tailpacking DIO Gao Xiang
2021-08-05 0:36 ` [PATCH v3 2/3] erofs: dax support for non-tailpacking regular file Gao Xiang
2021-08-05 3:01 ` Chao Yu [this message]
2021-08-05 3:24 ` Gao Xiang
2021-08-06 9:12 ` Chao Yu
2021-08-05 0:36 ` [PATCH v3 3/3] erofs: convert all uncompressed cases to iomap Gao Xiang
2021-08-05 3:02 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7aa650b8-a853-368d-7a81-f435194eec33@kernel.org \
--to=chao@kernel.org \
--cc=bo.liu@linux.alibaba.com \
--cc=boyu.mt@taobao.com \
--cc=djwong@kernel.org \
--cc=gerry@linux.alibaba.com \
--cc=hsiangkao@linux.alibaba.com \
--cc=huangjianan@oppo.com \
--cc=joseph.qi@linux.alibaba.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).