From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69E7FC432BE for ; Thu, 5 Aug 2021 03:01:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4C618610A8 for ; Thu, 5 Aug 2021 03:01:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238415AbhHEDCE (ORCPT ); Wed, 4 Aug 2021 23:02:04 -0400 Received: from mail.kernel.org ([198.145.29.99]:38722 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232230AbhHEDCB (ORCPT ); Wed, 4 Aug 2021 23:02:01 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id BA57B60E97; Thu, 5 Aug 2021 03:01:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1628132507; bh=yAZJuzyctHp6akkNiCxo+Iu3DAhWAT7FwQvPoTN17og=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=K3xwqgWn6GLThh4Df0a+R5lEzlsHQFag5HSqF/U7UpYfxABWa4HZXjfKnutBycrPu nzYxqjdNS/UkE0L2jyi7A7E6a7tuns6i/mCB8MOY2cLnCq1gq5Zchz7EBNOlwTbQf4 NtSkAFA5aGQuABdOAjMHSHB6MgmyySmWDqHX2N6YgQeXJilNA4qanHm4TBkiV4G3ls 20fkk9a5g+tDJul41XU56r12byPPHTWv7yTQvo5x15CVRukMLC/v+qLBZ3Bw7aaCxC XPVrY1+IvkMRK+MGLH0x+VGiycMlX1Umy9mShBRwlRdAeUSLRCkgzEmd7JyFqF+D0L o+2MzLPzIGTfg== Subject: Re: [PATCH v3 2/3] erofs: dax support for non-tailpacking regular file To: Gao Xiang , linux-erofs@lists.ozlabs.org Cc: linux-fsdevel@vger.kernel.org, nvdimm@lists.linux.dev, LKML , "Darrick J. Wong" , Liu Bo , Joseph Qi , Liu Jiang , Huang Jianan , Tao Ma References: <20210805003601.183063-1-hsiangkao@linux.alibaba.com> <20210805003601.183063-3-hsiangkao@linux.alibaba.com> From: Chao Yu Message-ID: <7aa650b8-a853-368d-7a81-f435194eec33@kernel.org> Date: Thu, 5 Aug 2021 11:01:43 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210805003601.183063-3-hsiangkao@linux.alibaba.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/8/5 8:36, Gao Xiang wrote: > DAX is quite useful for some VM use cases in order to save guest > memory extremely with minimal lightweight EROFS. > > In order to prepare for such use cases, add preliminary dax support > for non-tailpacking regular files for now. > > Tested with the DRAM-emulated PMEM and the EROFS image generated by > "mkfs.erofs -Enoinline_data enwik9.fsdax.img enwik9" > > Cc: nvdimm@lists.linux.dev > Cc: linux-fsdevel@vger.kernel.org > Signed-off-by: Gao Xiang > --- > Documentation/filesystems/erofs.rst | 2 + > fs/erofs/data.c | 42 +++++++++++++++++++- > fs/erofs/inode.c | 4 ++ > fs/erofs/internal.h | 3 ++ > fs/erofs/super.c | 59 ++++++++++++++++++++++++++++- > 5 files changed, 106 insertions(+), 4 deletions(-) > > diff --git a/Documentation/filesystems/erofs.rst b/Documentation/filesystems/erofs.rst > index 832839fcf4c3..ffd2ae7be511 100644 > --- a/Documentation/filesystems/erofs.rst > +++ b/Documentation/filesystems/erofs.rst > @@ -84,6 +84,8 @@ cache_strategy=%s Select a strategy for cached decompression from now on: > It still does in-place I/O decompression > for the rest compressed physical clusters. > ========== ============================================= > +dax Use direct access (no page cache). See dax or dax=%s Otherwise, it looks good to me. Reviewed-by: Chao Yu Thanks,