From: Himanshu Madhani <himanshu.madhani@oracle.com>
To: Colin King <colin.king@canonical.com>,
Nilesh Javali <njavali@marvell.com>,
GR-QLogic-Storage-Upstream@marvell.com,
"James E . J . Bottomley" <jejb@linux.ibm.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next[next]] scsi: qla2xxx: Remove redundant initialization of variable num_cnt
Date: Wed, 4 Aug 2021 10:08:04 -0500 [thread overview]
Message-ID: <7ac5f319-fd4c-f2e0-e318-71a4d7661693@oracle.com> (raw)
In-Reply-To: <20210804131344.112635-1-colin.king@canonical.com>
On 8/4/21 8:13 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The variable num_cnt is being initialized with a value that is never
> read, it is being updated later on. The assignment is redundant and
> can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/scsi/qla2xxx/qla_edif.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/qla2xxx/qla_edif.c b/drivers/scsi/qla2xxx/qla_edif.c
> index fde410989c03..2db954a7aaf1 100644
> --- a/drivers/scsi/qla2xxx/qla_edif.c
> +++ b/drivers/scsi/qla2xxx/qla_edif.c
> @@ -875,7 +875,7 @@ static int
> qla_edif_app_getfcinfo(scsi_qla_host_t *vha, struct bsg_job *bsg_job)
> {
> int32_t rval = 0;
> - int32_t num_cnt = 1;
> + int32_t num_cnt;
> struct fc_bsg_reply *bsg_reply = bsg_job->reply;
> struct app_pinfo_req app_req;
> struct app_pinfo_reply *app_reply;
>
Looks Good.
(I am curious if that extra "next" in patch subject was a typo or some
workflow added that)
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
--
Himanshu Madhani Oracle Linux Engineering
next prev parent reply other threads:[~2021-08-04 15:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-04 13:13 [PATCH][next[next]] scsi: qla2xxx: Remove redundant initialization of variable num_cnt Colin King
2021-08-04 15:08 ` Himanshu Madhani [this message]
2021-08-04 15:09 ` Colin Ian King
2021-08-06 3:13 ` Martin K. Petersen
2021-08-10 5:20 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ac5f319-fd4c-f2e0-e318-71a4d7661693@oracle.com \
--to=himanshu.madhani@oracle.com \
--cc=GR-QLogic-Storage-Upstream@marvell.com \
--cc=colin.king@canonical.com \
--cc=jejb@linux.ibm.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=njavali@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).