From: Phil Elwell <phil@raspberrypi.org>
To: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
Christoph Hellwig <hch@lst.de>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Robin Murphy <robin.murphy@arm.com>
Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dma-contiguous: CMA: give precedence to cmdline
Date: Fri, 10 Jan 2020 17:36:30 +0000 [thread overview]
Message-ID: <7ae5bad5-eee6-407f-bfa1-aff34f1a0550@raspberrypi.org> (raw)
In-Reply-To: <20200110171933.15014-1-nsaenzjulienne@suse.de>
Hi Nicolas,
On 10/01/2020 17:19, Nicolas Saenz Julienne wrote:
> Although the device tree might contain a reserved-memory DT node
> dedicated as the default CMA pool, users might want to change CMA's
> parameters using the kernel command line for debugging purposes and
> whatnot. Honor this by bypassing the reserved memory CMA setup, which
> will ultimately end up freeing the memblock and allow the command line
> CMA configuration routine to run.
>
> Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
> ---
>
> NOTE: Tested this on arm and arm64 with the Raspberry Pi 4.
>
> kernel/dma/contiguous.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/kernel/dma/contiguous.c b/kernel/dma/contiguous.c
> index daa4e6eefdde..8bc6f2d670f9 100644
> --- a/kernel/dma/contiguous.c
> +++ b/kernel/dma/contiguous.c
> @@ -302,9 +302,16 @@ static int __init rmem_cma_setup(struct reserved_mem *rmem)
> phys_addr_t align = PAGE_SIZE << max(MAX_ORDER - 1, pageblock_order);
> phys_addr_t mask = align - 1;
> unsigned long node = rmem->fdt_node;
> + bool default_cma = of_get_flat_dt_prop(node, "linux,cma-default", NULL);
> struct cma *cma;
> int err;
>
> + if (size_cmdline != -1 && default_cma) {
> + pr_info("Reserved memory: bypass %s node, using cmdline CMA params instead\n",
> + rmem->name);
> + return -EBUSY;
> + }
> +
> if (!of_get_flat_dt_prop(node, "reusable", NULL) ||
> of_get_flat_dt_prop(node, "no-map", NULL))
> return -EINVAL;
> @@ -322,7 +329,7 @@ static int __init rmem_cma_setup(struct reserved_mem *rmem)
> /* Architecture specific contiguous memory fixup. */
> dma_contiguous_early_fixup(rmem->base, rmem->size);
>
> - if (of_get_flat_dt_prop(node, "linux,cma-default", NULL))
> + if (default_cma)
> dma_contiguous_set_default(cma);
>
> rmem->ops = &rmem_cma_ops;
>
For what it's worth,
Reviewed-by: Phil Elwell <phil@raspberrypi.org>
Phil
next prev parent reply other threads:[~2020-01-10 17:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-10 17:19 [PATCH] dma-contiguous: CMA: give precedence to cmdline Nicolas Saenz Julienne
2020-01-10 17:36 ` Phil Elwell [this message]
2020-01-30 13:42 ` Christoph Hellwig
2020-01-30 16:11 ` Nicolas Saenz Julienne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ae5bad5-eee6-407f-bfa1-aff34f1a0550@raspberrypi.org \
--to=phil@raspberrypi.org \
--cc=hch@lst.de \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=nsaenzjulienne@suse.de \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).