From: Jacek Anaszewski <jacek.anaszewski@gmail.com>
To: Felix Brack <fb@ltec.ch>,
riku.voipio@iki.fi, rpurdie@rpsys.net, pavel@ucw.cz,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: f.brack@eets.ch
Subject: Re: [PATCH] leds: pca9532: Extend pca9532 device tree support
Date: Thu, 9 Feb 2017 22:10:21 +0100 [thread overview]
Message-ID: <7aef407c-3b85-a18a-c19d-72545211a4cc@gmail.com> (raw)
In-Reply-To: <3bfc9206-18c7-470b-ca53-d7bdb9a34f0a@ltec.ch>
Hi Felix,
On 02/09/2017 09:41 AM, Felix Brack wrote:
> Hello Jacek,
>
> On 08.02.2017 20:42, Jacek Anaszewski wrote:
>> Hi Felix,
>>
>> On 02/08/2017 05:12 PM, Felix Brack wrote:
>>> Hello Jacek,
>>>
>>> On 07.02.2017 21:45, Jacek Anaszewski wrote:
>>>> Hi Felix,
>>>>
>>>> Thanks for the patch.
>>>>
>>>> On 02/07/2017 07:11 PM, Felix Brack wrote:
>>>>> This patch extends the device tree support for the pca9532 allowing LEDs to blink, dim or even being unchanged, i.e. not being turned off during driver initialization.
>>>>
>>>> Isn't it possible to apply desired settings with existing LED subsystem
>>>> brightness file, and delay_on/off files exposed by timer trigger?
>>>>
>>>> Best regards,
>>>> Jacek Anaszewski
>>>>
>>>
>>> This might be a misunderstanding. My patch is not meant to replace
>>> anything for driving the LEDs once the kernel is fully loaded. The LED
>>> subsystem offers quite a lot of possibilities to do this.
>>>
>>> My patch mainly deals with the 'default' state of the LEDs immediately
>>> when the driver gets loaded.
>>> Here is an example: I have a system with a LED named 'RUN' which is
>>> turned on steady by U-Boot (indicating "system booting"). When the
>>> PCA9532 driver loads this LED gets turned off due to initialization.
>>> However I would like it remain lit until later a script will make that
>>> 'RUN' LED blink (indicating "system running"). This script will of
>>> course use the existing LED subsystem to do so. To keep the 'RUN' LED
>>> lit I need the DT property 'default-state' being set to 'PCA9532_KEEP'.
>>
>> It looks like all you need is default-state property.
>
> For the example with keeping the 'RUN' led turned on, yes. However I
> would have to configure PSC and PWM registers to make the 'RUN' LED
> blink, for example.
>
>> I'd rather avoid exposing prescaler and pwm registers in DT.
>
> I don't see that exposing PSC and PWM registers to the DT would do any
> harm. Is there something I'm missing here?
It is driver's responsibility to configure registers basing on user
settings. Let's stick to this scheme.
--
Best regards,
Jacek Anaszewski
next prev parent reply other threads:[~2017-02-09 21:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-07 18:11 [PATCH] leds: pca9532: Extend pca9532 device tree support Felix Brack
2017-02-07 20:45 ` Jacek Anaszewski
2017-02-08 16:12 ` Felix Brack
2017-02-08 19:42 ` Jacek Anaszewski
2017-02-09 8:41 ` Felix Brack
2017-02-09 14:24 ` Pavel Machek
2017-02-09 21:04 ` Jacek Anaszewski
2017-02-10 16:26 ` Felix Brack
2017-02-09 21:10 ` Jacek Anaszewski [this message]
2017-03-29 14:26 ` Felix Brack
2017-03-29 18:29 ` Jacek Anaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7aef407c-3b85-a18a-c19d-72545211a4cc@gmail.com \
--to=jacek.anaszewski@gmail.com \
--cc=f.brack@eets.ch \
--cc=fb@ltec.ch \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=riku.voipio@iki.fi \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).