From: Mark Zhang <markzhang@nvidia.com>
To: Yang Li <yang.lee@linux.alibaba.com>, <saeedm@nvidia.com>
Cc: <leon@kernel.org>, <davem@davemloft.net>, <kuba@kernel.org>,
<netdev@vger.kernel.org>, <linux-rdma@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] net/mlx5e: Fix an error code in mlx5e_arfs_create_tables()
Date: Wed, 2 Jun 2021 19:49:19 +0800 [thread overview]
Message-ID: <7b14006a-4528-bdd9-dd12-0785d8409a5d@nvidia.com> (raw)
In-Reply-To: <1622628553-89257-1-git-send-email-yang.lee@linux.alibaba.com>
On 6/2/2021 6:09 PM, Yang Li wrote:
> When the code execute 'if (!priv->fs.arfs->wq)', the value of err is 0.
> So, we use -ENOMEM to indicate that the function
> create_singlethread_workqueue() return NULL.
>
> Clean up smatch warning:
> drivers/net/ethernet/mellanox/mlx5/core/en_arfs.c:373
> mlx5e_arfs_create_tables() warn: missing error code 'err'.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Fixes: 'commit f6755b80d693 ("net/mlx5e: Dynamic alloc arfs table for netdev when needed")'
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
> drivers/net/ethernet/mellanox/mlx5/core/en_arfs.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_arfs.c b/drivers/net/ethernet/mellanox/mlx5/core/en_arfs.c
> index 5cd466e..2949437 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/en_arfs.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_arfs.c
> @@ -369,8 +369,10 @@ int mlx5e_arfs_create_tables(struct mlx5e_priv *priv)
> spin_lock_init(&priv->fs.arfs->arfs_lock);
> INIT_LIST_HEAD(&priv->fs.arfs->rules);
> priv->fs.arfs->wq = create_singlethread_workqueue("mlx5e_arfs");
> - if (!priv->fs.arfs->wq)
> + if (!priv->fs.arfs->wq) {
> + err = -ENOMEM;
> goto err;
> + }
>
> for (i = 0; i < ARFS_NUM_TYPES; i++) {
> err = arfs_create_table(priv, i);
Maybe also need to "destroy_workqueue(priv->fs.arfs->wq);" in err_des.
next prev parent reply other threads:[~2021-06-02 11:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-02 10:09 [PATCH] net/mlx5e: Fix an error code in mlx5e_arfs_create_tables() Yang Li
2021-06-02 11:49 ` Mark Zhang [this message]
2021-06-03 19:28 ` Saeed Mahameed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b14006a-4528-bdd9-dd12-0785d8409a5d@nvidia.com \
--to=markzhang@nvidia.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=saeedm@nvidia.com \
--cc=yang.lee@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).