From: Colin Ian King <colin.king@canonical.com>
To: Joe Perches <joe@perches.com>, Ping-Ke Shih <pkshih@realtek.com>,
Kalle Valo <kvalo@codeaurora.org>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] rtlwifi: rtl8192de: make arrays static const, makes object smaller
Date: Tue, 3 Aug 2021 15:03:18 +0100 [thread overview]
Message-ID: <7b203ff8-a19a-4fb7-d003-558adaa08407@canonical.com> (raw)
In-Reply-To: <e96786f5772f8ed01ab3153e0d5d66820b2e920a.camel@perches.com>
On 02/08/2021 09:35, Joe Perches wrote:
> On Sat, 2021-07-31 at 13:40 +0100, Colin King wrote:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> Don't populate arrays the stack but instead make them static const
>> Makes the object code smaller by 852 bytes.
> []
>> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c
> []
>> @@ -1354,7 +1354,7 @@ static void _rtl92d_phy_switch_rf_setting(struct ieee80211_hw *hw, u8 channel)
>>
>>
>> u8 rtl92d_get_rightchnlplace_for_iqk(u8 chnl)
>> {
>> - u8 channel_all[59] = {
>> + static const u8 channel_all[59] = {
>> 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14,
>> 36, 38, 40, 42, 44, 46, 48, 50, 52, 54, 56, 58,
>> 60, 62, 64, 100, 102, 104, 106, 108, 110, 112,
>> @@ -3220,7 +3220,7 @@ void rtl92d_phy_config_macphymode_info(struct ieee80211_hw *hw)
>> u8 rtl92d_get_chnlgroup_fromarray(u8 chnl)
>> {
>> u8 group;
>> - u8 channel_info[59] = {
>> + static const u8 channel_info[59] = {
>> 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14,
>> 36, 38, 40, 42, 44, 46, 48, 50, 52, 54, 56,
>> 58, 60, 62, 64, 100, 102, 104, 106, 108,
>
> These two arrays (channel_info and channel_all) are identical but
> laid out differently and could be combined and use a single name.
>
Good spot, will send a V2.
>
next prev parent reply other threads:[~2021-08-03 14:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-31 12:40 [PATCH 1/2] rtlwifi: rtl8192de: Remove redundant variable initializations Colin King
2021-07-31 12:40 ` [PATCH 2/2] rtlwifi: rtl8192de: make arrays static const, makes object smaller Colin King
2021-08-02 8:04 ` Pkshih
2021-08-02 8:35 ` Joe Perches
2021-08-03 14:03 ` Colin Ian King [this message]
2021-08-02 8:04 ` [PATCH 1/2] rtlwifi: rtl8192de: Remove redundant variable initializations Pkshih
2021-08-02 8:35 ` Joe Perches
2021-08-03 14:03 ` Colin Ian King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b203ff8-a19a-4fb7-d003-558adaa08407@canonical.com \
--to=colin.king@canonical.com \
--cc=davem@davemloft.net \
--cc=joe@perches.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pkshih@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).