From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Namhyung Kim <namhyung@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf tests: evsel-tp-sched: Fix bitwise operator
Date: Wed, 23 Jan 2019 02:40:03 -0600 [thread overview]
Message-ID: <7b2a7cad-3feb-fe79-04aa-31d53de19fa7@embeddedor.com> (raw)
In-Reply-To: <20190123083338.GK27625@krava>
On 1/23/19 2:33 AM, Jiri Olsa wrote:
> On Tue, Jan 22, 2019 at 05:34:39PM -0600, Gustavo A. R. Silva wrote:
>> Notice that the use of the bitwise OR operator '|' always leads to
>> true in this particular case, which seems a bit suspicious due to
>> the context in which this expression is being used.
>>
>> Fix this by using bitwise AND operator '&' instead.
>>
>> This bug was detected with the help of Coccinelle.
>>
>> Fixes: 6a6cd11d4e57 ("perf test: Add test for the sched tracepoint format fields")
>> Cc: stable@vger.kernel.org
>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
>
> nice catch
>
Glad to help. :)
> Acked-by: Jiri Olsa <jolsa@kernel.org>
>
Thanks
--
Gustavo
> thanks,
> jirka
>
>
>> ---
>>
>> NOTE: Notice that this code has been there since 2012. So, it would
>> be helpful if someone can double-check this. Thanks.
>>
>> tools/perf/tests/evsel-tp-sched.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tools/perf/tests/evsel-tp-sched.c b/tools/perf/tests/evsel-tp-sched.c
>> index 5f8501c68da4..5cbba70bcdd0 100644
>> --- a/tools/perf/tests/evsel-tp-sched.c
>> +++ b/tools/perf/tests/evsel-tp-sched.c
>> @@ -17,7 +17,7 @@ static int perf_evsel__test_field(struct perf_evsel *evsel, const char *name,
>> return -1;
>> }
>>
>> - is_signed = !!(field->flags | TEP_FIELD_IS_SIGNED);
>> + is_signed = !!(field->flags & TEP_FIELD_IS_SIGNED);
>> if (should_be_signed && !is_signed) {
>> pr_debug("%s: \"%s\" signedness(%d) is wrong, should be %d\n",
>> evsel->name, name, is_signed, should_be_signed);
>> --
>> 2.20.1
>>
next prev parent reply other threads:[~2019-01-23 8:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-22 23:34 [PATCH] perf tests: evsel-tp-sched: Fix bitwise operator Gustavo A. R. Silva
2019-01-23 8:33 ` Jiri Olsa
2019-01-23 8:40 ` Gustavo A. R. Silva [this message]
2019-01-28 19:29 ` Gustavo A. R. Silva
2019-01-29 9:01 ` Arnaldo Carvalho de Melo
2019-02-09 12:19 ` [tip:perf/urgent] perf tests " tip-bot for Gustavo A. R. Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b2a7cad-3feb-fe79-04aa-31d53de19fa7@embeddedor.com \
--to=gustavo@embeddedor.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).