From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA6C9C282D8 for ; Fri, 1 Feb 2019 07:15:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7640720B1F for ; Fri, 1 Feb 2019 07:15:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="MoNUepWb"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="LHtgekLd" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727095AbfBAHPM (ORCPT ); Fri, 1 Feb 2019 02:15:12 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:53372 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726092AbfBAHPL (ORCPT ); Fri, 1 Feb 2019 02:15:11 -0500 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 4344660398; Fri, 1 Feb 2019 07:15:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1549005310; bh=fgXHety82sVfid/BbnL0u2VKRq4VXwOOCDX+GC8ZBus=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=MoNUepWbv9ywORid+Ed1TuoGFsmRbxIDEFVhYrmFV7kgafKbgyF2OgeerBToof/Om FEx6TvNSEQPRZ8UomcN1FhgoiJwfl6X6Gag6g+tThv70RggjYCBm5o74LYEHoxBbnv Mtd3yANO6It9xL4zCmSrRr1Bo2OLxR3OxnxUXTY8= Received: from [10.79.40.96] (blr-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.18.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: sibis@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id E657960398; Fri, 1 Feb 2019 07:15:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1549005308; bh=fgXHety82sVfid/BbnL0u2VKRq4VXwOOCDX+GC8ZBus=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=LHtgekLdmkYSgtgl20c5Cfk6tSahmysu4q5soSjZZ1+TMeq2CvjBmiEHoi0aUn5NP 3Z/6aq0z6zfxKoLk+FmZiIDJPGP9CPYkleuPqhKSEVJlOL1ZGkR5hiA/5SplVp80LF xJdXZZw34YZUDINREmuZC5etyAwTrzWqKrPprWoM= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org E657960398 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=sibis@codeaurora.org Subject: Re: [PATCH v5 06/10] soc: qcom: Add AOSS QMP genpd provider To: Bjorn Andersson , Andy Gross , David Brown Cc: Rob Herring , Mark Rutland , Ohad Ben-Cohen , Arun Kumar Neelakantam , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-remoteproc@vger.kernel.org References: <20190131003933.11436-1-bjorn.andersson@linaro.org> <20190131003933.11436-7-bjorn.andersson@linaro.org> From: Sibi Sankar Message-ID: <7b394c87-0da6-dc8c-4c0b-f640897b169f@codeaurora.org> Date: Fri, 1 Feb 2019 12:45:01 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190131003933.11436-7-bjorn.andersson@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hey Bjorn, On 01/31/2019 06:09 AM, Bjorn Andersson wrote: > The AOSS QMP genpd provider implements control over power-related > resources related to low-power state associated with the remoteprocs in > the system as well as control over a set of clocks related to debug > hardware in the SoC. > > Tested-by: Sai Prakash Ranjan > Signed-off-by: Bjorn Andersson > --- > > Changes since v4: > - None > > Changes since v3: > - None > > drivers/soc/qcom/Kconfig | 9 +++ > drivers/soc/qcom/Makefile | 1 + > drivers/soc/qcom/aoss-qmp-pd.c | 138 +++++++++++++++++++++++++++++++++ > 3 files changed, 148 insertions(+) > create mode 100644 drivers/soc/qcom/aoss-qmp-pd.c > > diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig > index 28ab19bf8c98..893b56b70957 100644 > --- a/drivers/soc/qcom/Kconfig > +++ b/drivers/soc/qcom/Kconfig > @@ -12,6 +12,15 @@ config QCOM_AOSS_QMP > micro-controller in the AOSS, using QMP, to control certain resource > that are not exposed through RPMh. > > +config QCOM_AOSS_QMP_PD > + tristate "Qualcomm AOSS Messaging Power Domain driver" > + depends on QCOM_AOSS_QMP > + select PM_GENERIC_DOMAINS > + help > + This driver provides the means of controlling the AOSS's handling of > + low-power state for resources related to the remoteproc subsystems as > + well as controlling the debug clocks. > + > config QCOM_COMMAND_DB > bool "Qualcomm Command DB" > depends on ARCH_QCOM || COMPILE_TEST > diff --git a/drivers/soc/qcom/Makefile b/drivers/soc/qcom/Makefile > index 2c04d27fbf9e..16913e73fddf 100644 > --- a/drivers/soc/qcom/Makefile > +++ b/drivers/soc/qcom/Makefile > @@ -1,6 +1,7 @@ > # SPDX-License-Identifier: GPL-2.0 > CFLAGS_rpmh-rsc.o := -I$(src) > obj-$(CONFIG_QCOM_AOSS_QMP) += aoss-qmp.o > +obj-$(CONFIG_QCOM_AOSS_QMP_PD) += aoss-qmp-pd.o > obj-$(CONFIG_QCOM_GENI_SE) += qcom-geni-se.o > obj-$(CONFIG_QCOM_COMMAND_DB) += cmd-db.o > obj-$(CONFIG_QCOM_GLINK_SSR) += glink_ssr.o > diff --git a/drivers/soc/qcom/aoss-qmp-pd.c b/drivers/soc/qcom/aoss-qmp-pd.c > new file mode 100644 > index 000000000000..82dd569a2bc9 > --- /dev/null > +++ b/drivers/soc/qcom/aoss-qmp-pd.c > @@ -0,0 +1,138 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Copyright (c) 2018, Linaro Ltd > + */ > +#include > +#include > +#include > +#include > +#include > + > +/* Requests are expected to be 96 bytes long */ > +#define AOSS_QMP_PD_MSG_LEN 96 > + > +struct qmp_pd { > + struct qmp *qmp; > + > + struct generic_pm_domain pd; > + > + const char *name; > +}; > + > +#define to_qmp_pd_resource(res) container_of(res, struct qmp_pd, pd) > + > +struct qmp_pd_resource { > + const char *name; > + int (*on)(struct generic_pm_domain *domain); > + int (*off)(struct generic_pm_domain *domain); > +}; > + > +static int qmp_pd_clock_toggle(struct qmp_pd *res, bool enable) > +{ > + char buf[AOSS_QMP_PD_MSG_LEN]; > + > + snprintf(buf, sizeof(buf), "{class: clock, res: %s, val: %d}", > + res->name, !!enable); > + return qmp_send(res->qmp, buf, sizeof(buf)); > +} > + > +static int qmp_pd_clock_on(struct generic_pm_domain *domain) > +{ > + return qmp_pd_clock_toggle(to_qmp_pd_resource(domain), true); > +} > + > +static int qmp_pd_clock_off(struct generic_pm_domain *domain) > +{ > + return qmp_pd_clock_toggle(to_qmp_pd_resource(domain), false); > +} > + > +static int qmp_pd_image_toggle(struct qmp_pd *res, bool enable) > +{ > + char buf[AOSS_QMP_PD_MSG_LEN]; > + > + snprintf(buf, sizeof(buf), > + "{class: image, res: load_state, name: %s, val: %s}", > + res->name, enable ? "on" : "off"); > + return qmp_send(res->qmp, buf, sizeof(buf)); > +} > + > +static int qmp_pd_image_on(struct generic_pm_domain *domain) > +{ > + return qmp_pd_image_toggle(to_qmp_pd_resource(domain), true); > +} > + > +static int qmp_pd_image_off(struct generic_pm_domain *domain) > +{ > + return qmp_pd_image_toggle(to_qmp_pd_resource(domain), false); > +} > + > +static const struct qmp_pd_resource sdm845_resources[] = { > + [AOSS_QMP_QDSS_CLK] = { "qdss", qmp_pd_clock_on, qmp_pd_clock_off }, > + [AOSS_QMP_LS_CDSP] = { "cdsp", qmp_pd_image_on, qmp_pd_image_off }, > + [AOSS_QMP_LS_LPASS] = { "adsp", qmp_pd_image_on, qmp_pd_image_off }, > + [AOSS_QMP_LS_MODEM] = { "modem", qmp_pd_image_on, qmp_pd_image_off }, > + [AOSS_QMP_LS_SLPI] = { "slpi", qmp_pd_image_on, qmp_pd_image_off }, > + [AOSS_QMP_LS_SPSS] = { "spss", qmp_pd_image_on, qmp_pd_image_off }, > + [AOSS_QMP_LS_VENUS] = { "venus", qmp_pd_image_on, qmp_pd_image_off }, > +}; > + > +static int qmp_pd_probe(struct platform_device *pdev) > +{ > + struct genpd_onecell_data *data; > + struct device *parent = pdev->dev.parent; > + struct qmp_pd *res; > + struct qmp *qmp; > + size_t num = ARRAY_SIZE(sdm845_resources); > + int i; > + > + qmp = dev_get_drvdata(pdev->dev.parent); > + if (!qmp) > + return -EINVAL; > + > + res = devm_kcalloc(&pdev->dev, num, sizeof(*res), GFP_KERNEL); > + if (!res) > + return -ENOMEM; > + > + data = devm_kzalloc(&pdev->dev, sizeof(*data), GFP_KERNEL); > + if (!data) > + return -ENOMEM; > + > + data->domains = devm_kcalloc(&pdev->dev, num, sizeof(*data->domains), > + GFP_KERNEL); shouldn't we error out here as well? if (!data->domains) return -ENOMEM; > + > + for (i = 0; i < num; i++) { > + pm_genpd_init(&res[i].pd, NULL, true); shouldn't we populate the pd name before the call to pm_genpd_init? Apart from the above nits Tested-by: Sibi Sankar Reviewed-by: Sibi Sankar > + res[i].qmp = qmp; > + res[i].name = sdm845_resources[i].name; > + > + res[i].pd.name = sdm845_resources[i].name; > + res[i].pd.power_on = sdm845_resources[i].on; > + res[i].pd.power_off = sdm845_resources[i].off; > + > + data->domains[data->num_domains++] = &res[i].pd; > + } > + > + return of_genpd_add_provider_onecell(parent->of_node, data); > +} > + > +static int qmp_pd_remove(struct platform_device *pdev) > +{ > + struct device *parent = pdev->dev.parent; > + > + of_genpd_del_provider(parent->of_node); > + > + return 0; > +} > + > +static struct platform_driver qmp_pd_driver = { > + .driver = { > + .name = "aoss_qmp_pd", > + }, > + .probe = qmp_pd_probe, > + .remove = qmp_pd_remove, > +}; > +module_platform_driver(qmp_pd_driver); > + > +MODULE_ALIAS("platform:aoss_qmp_pd"); > +MODULE_DESCRIPTION("Qualcomm AOSS QMP load-state driver"); > +MODULE_LICENSE("GPL v2"); > -- Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc, is a member of Code Aurora Forum, a Linux Foundation Collaborative Project