From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S933418AbdKAVPz (ORCPT <rfc822;w@1wt.eu>);
        Wed, 1 Nov 2017 17:15:55 -0400
Received: from mailout.easymail.ca ([64.68.200.34]:48432 "EHLO
        mailout.easymail.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S933191AbdKAVPy (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 1 Nov 2017 17:15:54 -0400
Reply-To: shuah@kernel.org
Subject: Re: [PATCH] selftests/ftrace: Do not use arch dependent do_IRQ as a
 target function
To: Masami Hiramatsu <mhiramat@kernel.org>,
        linux-kselftest@vger.kernel.org, Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org, sumit.semwal@linaro.org,
        naresh.kamboju@linaro.org, Shuah Khan <shuahkh@osg.samsung.com>,
        Shuah Khan <shuah@kernel.org>
References: <150908463014.28027.15385023102033596689.stgit@devbox>
From: Shuah Khan <shuah@kernel.org>
Message-ID: <7b45330e-1817-87d6-4469-c530e19b784d@kernel.org>
Date: Wed, 1 Nov 2017 15:15:40 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <150908463014.28027.15385023102033596689.stgit@devbox>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 10/27/2017 12:10 AM, Masami Hiramatsu wrote:
> Instead using arch-dependent do_IRQ, use do_softirq as a
> target function.
> 
> Applying do_IRQ to set_ftrace_filter always fail on arm/arm64 and any
> other architectures which don't define do_IRQ. So, instead of using
> that, use do_softirq which is defined in kernel/softirq.c.
> 
> Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
> ---
>  .../ftrace/test.d/ftrace/func_set_ftrace_file.tc   |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/ftrace/test.d/ftrace/func_set_ftrace_file.tc b/tools/testing/selftests/ftrace/test.d/ftrace/func_set_ftrace_file.tc
> index 113b4d9bc733..20f15c858af6 100644
> --- a/tools/testing/selftests/ftrace/test.d/ftrace/func_set_ftrace_file.tc
> +++ b/tools/testing/selftests/ftrace/test.d/ftrace/func_set_ftrace_file.tc
> @@ -32,7 +32,7 @@ do_reset
>  
>  FILTER=set_ftrace_filter
>  FUNC1="schedule"
> -FUNC2="do_IRQ"
> +FUNC2="do_softirq"
>  
>  ALL_FUNCS="#### all functions enabled ####"
>  
> 
> 
> 

Looks good to me. I will queue this for 4.15-rc1

thanks,
-- Shuah