From: Hans Verkuil <hverkuil@xs4all.nl>
To: Tomasz Figa <tfiga@chromium.org>, Philipp Zabel <p.zabel@pengutronix.de>
Cc: "Linux Media Mailing List" <linux-media@vger.kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Stanimir Varbanov" <stanimir.varbanov@linaro.org>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Pawel Osciak" <posciak@chromium.org>,
"Alexandre Courbot" <acourbot@chromium.org>,
kamil@wypas.org, a.hajda@samsung.com,
"Kyungmin Park" <kyungmin.park@samsung.com>,
jtp.park@samsung.com,
"Tiffany Lin (林慧珊)" <tiffany.lin@mediatek.com>,
"Andrew-CT Chen (陳智迪)" <andrew-ct.chen@mediatek.com>,
todor.tomov@linaro.org, nicolas@ndufresne.ca,
"Paul Kocialkowski" <paul.kocialkowski@bootlin.com>,
"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
dave.stevenson@raspberrypi.org,
"Ezequiel Garcia" <ezequiel@collabora.com>
Subject: Re: [PATCH 2/2] media: docs-rst: Document memory-to-memory video encoder interface
Date: Tue, 16 Oct 2018 15:49:58 +0200 [thread overview]
Message-ID: <7b8b56e7-1617-5de6-9fa9-a10897a8f2f1@xs4all.nl> (raw)
In-Reply-To: <CAAFQd5Djur9y+=UHTx9ZSx310p2ShCsBTqsEA1UHCMoawuDscA@mail.gmail.com>
On 10/16/18 09:36, Tomasz Figa wrote:
> On Tue, Aug 7, 2018 at 3:54 PM Tomasz Figa <tfiga@chromium.org> wrote:
>>>> + * The driver must expose following selection targets on ``OUTPUT``:
>>>> +
>>>> + ``V4L2_SEL_TGT_CROP_BOUNDS``
>>>> + maximum crop bounds within the source buffer supported by the
>>>> + encoder
>>>> +
>>>> + ``V4L2_SEL_TGT_CROP_DEFAULT``
>>>> + suggested cropping rectangle that covers the whole source picture
>>>> +
>>>> + ``V4L2_SEL_TGT_CROP``
>>>> + rectangle within the source buffer to be encoded into the
>>>> + ``CAPTURE`` stream; defaults to ``V4L2_SEL_TGT_CROP_DEFAULT``
>>>> +
>>>> + ``V4L2_SEL_TGT_COMPOSE_BOUNDS``
>>>> + maximum rectangle within the coded resolution, which the cropped
>>>> + source frame can be output into; always equal to (0, 0)x(width of
>>>> + ``V4L2_SEL_TGT_CROP``, height of ``V4L2_SEL_TGT_CROP``), if the
>>>> + hardware does not support compose/scaling
Re-reading this I would rewrite this a bit:
if the hardware does not support composition or scaling, then this is always
equal to (0, 0)x(width of ``V4L2_SEL_TGT_CROP``, height of ``V4L2_SEL_TGT_CROP``).
>>>> +
>>>> + ``V4L2_SEL_TGT_COMPOSE_DEFAULT``
>>>> + equal to ``V4L2_SEL_TGT_CROP``
>>>> +
>>>> + ``V4L2_SEL_TGT_COMPOSE``
>>>> + rectangle within the coded frame, which the cropped source frame
>>>> + is to be output into; defaults to
>>>> + ``V4L2_SEL_TGT_COMPOSE_DEFAULT``; read-only on hardware without
>>>> + additional compose/scaling capabilities; resulting stream will
>>>> + have this rectangle encoded as the visible rectangle in its
>>>> + metadata
>>>> +
>>>> + ``V4L2_SEL_TGT_COMPOSE_PADDED``
>>>> + always equal to coded resolution of the stream, as selected by the
>>>> + encoder based on source resolution and crop/compose rectangles
>>>
>>> Are there codec drivers that support composition? I can't remember seeing any.
>>>
>>
>> Hmm, I was convinced that MFC could scale and we just lacked support
>> in the driver, but I checked the documentation and it doesn't seem to
>> be able to do so. I guess we could drop the COMPOSE rectangles for
>> now, until we find any hardware that can do scaling or composing on
>> the fly.
>>
>
> On the other hand, having them defined already wouldn't complicate
> existing drivers too much either, because they would just handle all
> of them in the same switch case, i.e.
>
> case V4L2_SEL_TGT_COMPOSE_BOUNDS:
> case V4L2_SEL_TGT_COMPOSE_DEFAULT:
> case V4L2_SEL_TGT_COMPOSE:
> case V4L2_SEL_TGT_COMPOSE_PADDED:
> return visible_rectangle;
>
> That would need one change, though. We would define
> V4L2_SEL_TGT_COMPOSE_DEFAULT to be equal to (0, 0)x(width of
> V4L2_SEL_TGT_CROP - 1, height of ``V4L2_SEL_TGT_CROP - 1), which
" - 1"? Where does that come from?
Usually rectangles are specified as widthxheight@left,top.
> makes more sense than current definition, since it would bypass any
> compose/scaling by default.
I have no problem with drivers optionally implementing these rectangles,
even if they don't do scaling or composition. The question is, should it
be required for decoders? If there is a good reason, then I'm OK with it.
Regards,
Hans
next prev parent reply other threads:[~2018-10-16 13:50 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-24 14:06 [PATCH 0/2] Document memory-to-memory video codec interfaces Tomasz Figa
2018-07-24 14:06 ` [PATCH 1/2] media: docs-rst: Document memory-to-memory video decoder interface Tomasz Figa
2018-07-25 11:58 ` Hans Verkuil
2018-07-26 10:20 ` Tomasz Figa
2018-07-26 10:36 ` Philipp Zabel
2018-08-07 6:55 ` Tomasz Figa
2018-07-26 10:57 ` Hans Verkuil
2018-08-07 7:05 ` Tomasz Figa
2018-08-07 7:37 ` Hans Verkuil
2018-08-08 2:55 ` Tomasz Figa
2018-08-21 11:29 ` Stanimir Varbanov
2018-08-27 4:09 ` Tomasz Figa
2018-10-15 10:13 ` Tomasz Figa
2018-10-16 1:09 ` Nicolas Dufresne
2018-08-07 7:13 ` Hans Verkuil
2018-08-07 19:11 ` Maxime Jourdan
2018-08-08 3:07 ` Tomasz Figa
2018-08-08 7:19 ` Maxime Jourdan
2018-08-08 3:11 ` Tomasz Figa
2018-08-08 6:43 ` Hans Verkuil
2018-08-08 6:54 ` Ian Arkver
2018-09-19 10:17 ` Tomasz Figa
2018-10-08 12:22 ` Hans Verkuil
2018-10-09 4:23 ` Tomasz Figa
2018-10-09 6:39 ` Hans Verkuil
2018-07-30 12:52 ` Hans Verkuil
2018-08-07 7:08 ` Tomasz Figa
2018-08-08 2:46 ` Tomasz Figa
2018-08-20 13:04 ` Philipp Zabel
2018-08-20 13:12 ` Tomasz Figa
2018-08-20 14:13 ` Philipp Zabel
2018-08-20 14:27 ` Tomasz Figa
2018-08-20 15:33 ` Philipp Zabel
2018-08-27 4:03 ` Tomasz Figa
2018-08-31 8:26 ` Alexandre Courbot
2018-09-05 5:45 ` Tomasz Figa
2018-10-17 13:34 ` Laurent Pinchart
2018-10-18 10:03 ` Tomasz Figa
2018-10-18 11:22 ` Laurent Pinchart
2018-10-20 8:52 ` Tomasz Figa
2018-10-21 9:23 ` Laurent Pinchart
2018-10-22 6:19 ` Tomasz Figa
2018-10-20 10:24 ` Tomasz Figa
2018-10-21 9:26 ` Laurent Pinchart
2018-10-20 15:39 ` Tomasz Figa
2018-07-24 14:06 ` [PATCH 2/2] media: docs-rst: Document memory-to-memory video encoder interface Tomasz Figa
2018-07-25 13:41 ` Philipp Zabel
2018-08-07 6:07 ` Tomasz Figa
2018-07-25 13:57 ` Hans Verkuil
2018-08-07 6:54 ` Tomasz Figa
2018-08-07 7:25 ` Hans Verkuil
2018-10-16 7:36 ` Tomasz Figa
2018-10-16 13:49 ` Hans Verkuil [this message]
2018-10-22 4:50 ` Tomasz Figa
2018-09-07 20:17 ` Ezequiel Garcia
2018-09-10 3:34 ` Tomasz Figa
2018-10-17 15:19 ` Laurent Pinchart
2018-10-22 6:12 ` Tomasz Figa
2018-07-25 13:28 ` [PATCH 0/2] Document memory-to-memory video codec interfaces Philipp Zabel
2018-07-25 13:35 ` Tomasz Figa
2018-09-10 9:13 ` Hans Verkuil
2018-09-11 3:52 ` Tomasz Figa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b8b56e7-1617-5de6-9fa9-a10897a8f2f1@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=a.hajda@samsung.com \
--cc=acourbot@chromium.org \
--cc=andrew-ct.chen@mediatek.com \
--cc=dave.stevenson@raspberrypi.org \
--cc=ezequiel@collabora.com \
--cc=jtp.park@samsung.com \
--cc=kamil@wypas.org \
--cc=kyungmin.park@samsung.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=nicolas@ndufresne.ca \
--cc=p.zabel@pengutronix.de \
--cc=paul.kocialkowski@bootlin.com \
--cc=posciak@chromium.org \
--cc=stanimir.varbanov@linaro.org \
--cc=tfiga@chromium.org \
--cc=tiffany.lin@mediatek.com \
--cc=todor.tomov@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).