From: Ezequiel Garcia <ezequiel@collabora.com>
To: Tomasz Figa <tfiga@chromium.org>, Jonas Karlman <jonas@kwiboo.se>
Cc: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
Hans Verkuil <hverkuil@xs4all.nl>,
Boris Brezillon <boris.brezillon@collabora.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 2/5] media: hantro: Reduce H264 extra space for motion vectors
Date: Mon, 09 Dec 2019 15:11:41 -0300 [thread overview]
Message-ID: <7b92111b0c6443653de45f1eeec867645c127f32.camel@collabora.com> (raw)
In-Reply-To: <CAAFQd5CSWea=DNjySJxZmVi+2c5U4EKVPa1mf3vHh70+YrAQCA@mail.gmail.com>
On Wed, 2019-11-20 at 21:44 +0900, Tomasz Figa wrote:
> Hi Jonas,
>
> On Thu, Nov 7, 2019 at 7:34 AM Jonas Karlman <jonas@kwiboo.se> wrote:
> > A decoded 8-bit 4:2:0 frame need memory for up to 448 bytes per
> > macroblock with additional 32 bytes on multi-core variants.
> >
> > Memory layout is as follow:
> >
> > +---------------------------+
> > > Y-plane 256 bytes x MBs |
> > +---------------------------+
> > > UV-plane 128 bytes x MBs |
> > +---------------------------+
> > > MV buffer 64 bytes x MBs |
> > +---------------------------+
> > > MC sync 32 bytes |
> > +---------------------------+
> >
> > Reduce the extra space allocated now that motion vector buffer offset no
> > longer is based on the extra space.
> >
> > Only allocate extra space for 64 bytes x MBs of motion vector buffer
> > and 32 bytes for multi-core sync.
> >
> > Fixes: a9471e25629b ("media: hantro: Add core bits to support H264 decoding")
> > Signed-off-by: Jonas Karlman <jonas@kwiboo.se>
> > Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
> > ---
> > Changes in v3:
> > - add memory layout to code comment (Boris)
> > Changes in v2:
> > - updated commit message
> > ---
> > drivers/staging/media/hantro/hantro_v4l2.c | 20 ++++++++++++++++++--
> > 1 file changed, 18 insertions(+), 2 deletions(-)
> >
>
> Thanks for the patch!
>
> What platform did you test it on and how? Was it tested with IOMMU enabled?
Hello Tomasz,
Please note that this series has been picked-up and is merged
in v5.5-rc1.
IIRC, we tested these patches on RK3399 and RK3288 (that means
with an IOMMU). I've just ran some more extensive tests on RK3288,
on media/master; and I plan to test some more on RK3399 later this week.
Do you have any specific concern in mind?
Thanks,
Ezequiel
next prev parent reply other threads:[~2019-12-09 18:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-06 22:32 [PATCH v3 0/5] media: hantro: H264 fixes and improvements Jonas Karlman
2019-11-06 22:34 ` [PATCH v3 1/5] media: hantro: Fix H264 motion vector buffer offset Jonas Karlman
2019-11-20 12:40 ` Tomasz Figa
[not found] ` <20191106223408.2176-1-jonas@kwiboo.se>
2019-11-06 22:34 ` [PATCH v3 2/5] media: hantro: Reduce H264 extra space for motion vectors Jonas Karlman
2019-11-20 12:44 ` Tomasz Figa
2019-12-09 18:11 ` Ezequiel Garcia [this message]
2020-01-08 12:59 ` Tomasz Figa
2020-01-08 15:10 ` Jonas Karlman
2020-01-16 3:56 ` Tomasz Figa
2019-11-06 22:34 ` [PATCH v3 3/5] media: hantro: Use output buffer width and height for H264 decoding Jonas Karlman
2019-11-09 19:04 ` Boris Brezillon
2019-11-06 22:35 ` [PATCH v3 4/5] media: hantro: Remove now unused H264 pic_size Jonas Karlman
[not found] ` <20191106223456.2231-1-jonas@kwiboo.se>
2019-11-06 22:35 ` [PATCH v3 5/5] media: hantro: Set H264 FIELDPIC_FLAG_E flag correctly Jonas Karlman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b92111b0c6443653de45f1eeec867645c127f32.camel@collabora.com \
--to=ezequiel@collabora.com \
--cc=boris.brezillon@collabora.com \
--cc=hverkuil@xs4all.nl \
--cc=jonas@kwiboo.se \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab+samsung@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=tfiga@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).