From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Greg KH <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org, Kees Cook <keescook@chromium.org>
Subject: Re: [PATCH] parport: ieee1284: mark expected switch fall-through
Date: Wed, 20 Mar 2019 15:06:04 -0500 [thread overview]
Message-ID: <7b9bcd42-47fa-05cd-2e92-0124109f9aa2@embeddedor.com> (raw)
In-Reply-To: <4d221d8f-f4d0-90f7-dccf-3af67d4b0c53@embeddedor.com>
Greg,
Can you take this, please?
Thanks
--
Gustavo
On 2/25/19 12:23 PM, Gustavo A. R. Silva wrote:
> Hi,
>
> Friendly ping:
>
> Who can take this, please?
>
> Thanks
> --
> Gustavo
>
> On 2/12/19 11:43 AM, Gustavo A. R. Silva wrote:
>> In preparation to enabling -Wimplicit-fallthrough, mark switch
>> cases where we are expecting to fall through.
>>
>> This patch fixes the following warning:
>>
>> drivers/parport/ieee1284.c: In function ‘parport_read’:
>> drivers/parport/ieee1284.c:722:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
>> if (parport_negotiate (port, IEEE1284_MODE_NIBBLE)) {
>> ^
>> drivers/parport/ieee1284.c:726:2: note: here
>> case IEEE1284_MODE_NIBBLE:
>> ^~~~
>>
>> Warning level 3 was used: -Wimplicit-fallthrough=3
>>
>> Notice that, in this particular case, the code comment is modified
>> in accordance with what GCC is expecting to find.
>>
>> This patch is part of the ongoing efforts to enable
>> -Wimplicit-fallthrough.
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
>> ---
>> drivers/parport/ieee1284.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/parport/ieee1284.c b/drivers/parport/ieee1284.c
>> index f12b9da69255..90fb73575495 100644
>> --- a/drivers/parport/ieee1284.c
>> +++ b/drivers/parport/ieee1284.c
>> @@ -722,7 +722,7 @@ ssize_t parport_read (struct parport *port, void *buffer, size_t len)
>> if (parport_negotiate (port, IEEE1284_MODE_NIBBLE)) {
>> return -EIO;
>> }
>> - /* fall through to NIBBLE */
>> + /* fall through - to NIBBLE */
>> case IEEE1284_MODE_NIBBLE:
>> DPRINTK (KERN_DEBUG "%s: Using nibble mode\n", port->name);
>> fn = port->ops->nibble_read_data;
>>
next prev parent reply other threads:[~2019-03-20 20:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-12 17:43 [PATCH] parport: ieee1284: mark expected switch fall-through Gustavo A. R. Silva
2019-02-25 18:23 ` Gustavo A. R. Silva
2019-03-20 20:06 ` Gustavo A. R. Silva [this message]
2019-03-20 20:12 ` Greg KH
2019-03-20 20:21 ` Gustavo A. R. Silva
2019-03-24 18:33 ` Sudip Mukherjee
2019-03-29 15:20 Sudip Mukherjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b9bcd42-47fa-05cd-2e92-0124109f9aa2@embeddedor.com \
--to=gustavo@embeddedor.com \
--cc=gregkh@linuxfoundation.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).