From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4AEBC56202 for ; Thu, 26 Nov 2020 08:50:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4369E208CA for ; Thu, 26 Nov 2020 08:50:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388950AbgKZItz (ORCPT ); Thu, 26 Nov 2020 03:49:55 -0500 Received: from frasgout.his.huawei.com ([185.176.79.56]:2156 "EHLO frasgout.his.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726392AbgKZItz (ORCPT ); Thu, 26 Nov 2020 03:49:55 -0500 Received: from fraeml741-chm.china.huawei.com (unknown [172.18.147.207]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4ChWcR1vTFz67HgK; Thu, 26 Nov 2020 16:48:07 +0800 (CST) Received: from lhreml724-chm.china.huawei.com (10.201.108.75) by fraeml741-chm.china.huawei.com (10.206.15.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Thu, 26 Nov 2020 09:49:53 +0100 Received: from [10.210.172.213] (10.210.172.213) by lhreml724-chm.china.huawei.com (10.201.108.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1913.5; Thu, 26 Nov 2020 08:49:52 +0000 Subject: Re: [PATCH v3 2/5] ACPI: Make acpi_dev_irqresource_disabled() public To: "Rafael J. Wysocki" CC: "James E.J. Bottomley" , "Martin K. Petersen" , Len Brown , "Rafael J. Wysocki" , Greg Kroah-Hartman , Thomas Gleixner , "open list:TARGET SUBSYSTEM" , "Linux Kernel Mailing List" , Linuxarm , "ACPI Devel Maling List" , Marc Zyngier References: <1606324841-217570-1-git-send-email-john.garry@huawei.com> <1606324841-217570-3-git-send-email-john.garry@huawei.com> From: John Garry Message-ID: <7b9e1500-f520-24a8-548e-d4952dab028c@huawei.com> Date: Thu, 26 Nov 2020 08:49:30 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.1.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [10.210.172.213] X-ClientProxiedBy: lhreml707-chm.china.huawei.com (10.201.108.56) To lhreml724-chm.china.huawei.com (10.201.108.75) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25/11/2020 17:43, Rafael J. Wysocki wrote: > On Wed, Nov 25, 2020 at 6:25 PM John Garry wrote: >> To allow the platform device to "put" an irq, make the function to reset >> an ACPI companion device irq resource public. >> >> Signed-off-by: John Garry > I'd rather move it to kernel/resource.c as it is not ACPI-specific and > its only connection to ACPI is that it is used in the ACPI resources > management code. > Hi Rafael, That's ok, but we could also just put in include/linux/ioport.h as a static inline as it’s so small. Not so important, I guess. And I'm not sure how this part could be merged, so maybe I can do as 2x patches now - 1. add resource.c function 2. remove ACPI duplicate. - so we have the option to merge ACPI part later if it makes things easier. Thanks, John