From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1034604AbcIWTrn (ORCPT ); Fri, 23 Sep 2016 15:47:43 -0400 Received: from mout.web.de ([212.227.15.14]:51344 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965693AbcIWTrh (ORCPT ); Fri, 23 Sep 2016 15:47:37 -0400 Subject: [PATCH 4/4] i2c-dev: Adjust checks for null pointers in three functions To: linux-i2c@vger.kernel.org, Wolfram Sang References: <566ABCD9.1060404@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring Message-ID: <7ba4f7a9-9af4-4a83-776c-930fb33f9e9e@users.sourceforge.net> Date: Fri, 23 Sep 2016 21:47:31 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:l+Df/RisSUlrU+RwYvcjnwbsyotkpZcnEfyf+zguWTCRD1+Bgi2 GvPBKLFITlqjku8r94dzpykizYPQWAd4YNBwmwB3PBzqyYev4ZTbrLz74oPnJEU6+8DDDZ2 +Os+s4IOrvWd9yTgjQX5LkBBFiAe6QA85rSOcAJnqdNrSdHDTy3o6bn2ATsnHAvj6oLNluB nNcGff7F21Pnh3wf9gq0A== X-UI-Out-Filterresults: notjunk:1;V01:K0:ilt0ByMUfKs=:o+CtcLYp45klK4mR1iCYgf fw5NqPfe+p6wP8Hqn0SNL+4LOn3Nw4J1O9m3+O9tASYovl2ZrE8HP4SWekgXlEoQLuH1Yke3J 70Wk86h8zUTwE7hijRCFCQli4ry/UqN1Ts5gdJVTT3jX9gDXrn1r1n0J5Rt0EdCZ5D4nvIjMK tcNuT1B/L5cNpw9xwNNWl3rBu/o0Xh9ZNYvyh6fdxHbai34DUHRELmXrNLdUDTTspI1JTdJgR Ra6APh4biZjU/R772gYLzEGn3d5dXqwUl/jbJa4FsUNEQZ3AcOJRa16zHpGORQ/Vqv5+iR37p 2j8pSwTvmlwsH0F8a9fgvg2GpQo9FdYcoyyt9cwaGfh2zb7xRwzxWDpdXJzHnxXnEEWrqsn7p ybdQFZ1wzrgX3SX8R2FOqKoll+sHpV9v2z0P3rYEnmKykTq1+OafNWNe3otLBg4MUOdXfpapZ BC2+1xgjEWPP4Q9+NTCqj22TAgeQpa3rNS/Wdvy7PSXEfm3gBX8wrSTUrymOSX5itnJsv1aF3 WLxEbYOwiMIh52bBK5/zBm1HmHeBfXFgBACS7hlNsgvsGBvZ3a6mray+rNNb2Ko2v3p/bEMdz BlLgTRO9cHWRobDTkNezEXi+0H9eFdRcvwKmT4yRwHJVcBUMZ5oFV2llTx1BIXabRYV/g4QE1 LubaJGgG1Oi2wJfOuVGqlWA1Yz8ZA7nF6c6wvXSm6ikCACsIhHAk+TfyQh/AJm+eF8zx9ALaF QRAVvekKqj4pDy89iSfxPAHzLHNhqqdCGKKTNqua6IUoxkjPh6gZIewxOsBfJAgKmUIHUr8PI kULc0LR Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Fri, 23 Sep 2016 21:30:20 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The script "checkpatch.pl" can point information out like the following. Comparison to NULL could be written !… Thus fix the affected source code places. Signed-off-by: Markus Elfring --- drivers/i2c/i2c-dev.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/i2c/i2c-dev.c b/drivers/i2c/i2c-dev.c index 7d3e3ca..8f7eddd 100644 --- a/drivers/i2c/i2c-dev.c +++ b/drivers/i2c/i2c-dev.c @@ -147,7 +147,7 @@ static ssize_t i2cdev_read(struct file *file, char __user *buf, size_t count, count = 8192; tmp = kmalloc(count, GFP_KERNEL); - if (tmp == NULL) + if (!tmp) return -ENOMEM; pr_debug("i2c-dev: i2c-%d reading %zu bytes.\n", @@ -263,7 +263,7 @@ static noinline int i2cdev_ioctl_rdwr(struct i2c_client *client, data_ptrs = kmalloc_array(rdwr_arg.nmsgs, sizeof(*data_ptrs), GFP_KERNEL); - if (data_ptrs == NULL) { + if (!data_ptrs) { kfree(rdwr_pa); return -ENOMEM; } @@ -374,7 +374,7 @@ static noinline int i2cdev_ioctl_smbus(struct i2c_client *client, client->flags, data_arg.read_write, data_arg.command, data_arg.size, NULL); - if (data_arg.data == NULL) { + if (!data_arg.data) { dev_dbg(&client->adapter->dev, "data is NULL pointer in ioctl I2C_SMBUS.\n"); return -EINVAL; -- 2.10.0