From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751413AbdBFKPm (ORCPT ); Mon, 6 Feb 2017 05:15:42 -0500 Received: from smtpout.microchip.com ([198.175.253.82]:34582 "EHLO email.microchip.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750950AbdBFKPl (ORCPT ); Mon, 6 Feb 2017 05:15:41 -0500 Subject: Re: linux-next: build warnings after merge of the crypto tree To: Stephen Rothwell , Herbert Xu References: <20170206122837.0226fb89@canb.auug.org.au> CC: , From: Cyrille Pitchen Message-ID: <7bb7f79a-dcf0-3912-ab31-031378828f4e@atmel.com> Date: Mon, 6 Feb 2017 11:15:38 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <20170206122837.0226fb89@canb.auug.org.au> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit X-Brightmail-Tracker: H4sIAAAAAAAAC+NgFtrNKsWRWlGSWpSXmKPExsXCxeXDonvGZ0aEQdvHDfN5LbpfyVhc3jWHzeLgwjZGi617r7I7sHg03rjB5rHtgKrH501yAcxRrJl5SfkVCawZm7/1sBdMMqm48HMSUwPje40uRi4OIYHljBK/r35m72Lk5BAWcJP4ufE/C4gtIhAu0fFxCiuILSRgJjFpwSY2EJtZwEbizZLTYHE2AUOJtw+Ogtm8QPG/B/+C2SwCKhLfXswBs0UFIiTmP13FBFEjKHFy5hOw+ZwC5hI/Z65hhphpIHFkEUQ9s4C8RPPW2cwQe9UkFrasALMlBAIlziz4AmU7STxfd5MNwraTODz9IjuE7SDRteA3XM3TxxehbG2J7a/2sULYOhLbDvazQNi2EntmTGSCsN0lHjxaDmX7Ssx62ABVEyXRtmQz2wRGyVlIXpiF5OxZSM5ewMi8ilHa2cNPNzhM1zXC2cPAXC83OaNANzcxM08vOT93EyMkGnN2MK5ZHHGIUZKDSUmU19BjaoQQX1J+SmVGYnFGfFFpTmrxIUYZDg4lCd6pXjMihASLUtNTK9Iyc4BpASbNxMF5iFGCg0dJhPczSA1vcUFibnFmOkT+FKOklDjvLpCEAEgiozQPrvcSo6iUMC+HI1COpyC1KDezBCJ+i1GM4yETx2MmIZa8/LxUKaBTGYDAgPEVozgHo5Iw732QcTyZeSVwa14BXcAEdMG2K9NALihJREhJNTCKRUW7K+w0D3ycmZq97EE4eyIT89fCOPOjHTrra63TXj3tiY9/axmtaiIZ7c7G57j72eqjj3ufW23UfRdaKLteVC5k2rtTE844ZK38983r5mGGh7d+VfIGcy3+vc/GtFvWN2Lj36/tGtseaDxmbZvj2r8vUDJ9wjLdG+cObcpxm/rt98ldtiJKLMUZiYZazEXFiQAZ5TgwTgMAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi all, Le 06/02/2017 à 02:28, Stephen Rothwell a écrit : > Hi Herbert, > > After merging the crypto tree, today's linux-next build (x86_64 > allmodconfig) produced these warnings: > > warning: (CRYPTO_DEV_ATMEL_AUTHENC) selects CRYPTO_DEV_ATMEL_SHA which has unmet direct dependencies (CRYPTO && CRYPTO_HW && ARCH_AT91) > warning: (CRYPTO_DEV_ATMEL_AUTHENC) selects CRYPTO_DEV_ATMEL_SHA which has unmet direct dependencies (CRYPTO && CRYPTO_HW && ARCH_AT91) > > Introduced by commit > > 89a82ef87e01 ("crypto: atmel-authenc - add support to authenc(hmac(shaX), Y(aes)) modes") > > In file included from include/linux/printk.h:329:0, > from include/linux/kernel.h:13, > from drivers/crypto/atmel-sha.c:17: > drivers/crypto/atmel-sha.c: In function 'atmel_sha_xmit_cpu': > drivers/crypto/atmel-sha.c:571:19: warning: format '%d' expects argument of type 'int', but argument 6 has type 'size_t {aka long unsigned int}' [-Wformat=] > dev_dbg(dd->dev, "xmit_cpu: digcnt: 0x%llx 0x%llx, length: %d, final: %d\n", > ^ > include/linux/dynamic_debug.h:134:39: note: in definition of macro 'dynamic_dev_dbg' > __dynamic_dev_dbg(&descriptor, dev, fmt, \ > ^ > drivers/crypto/atmel-sha.c:571:2: note: in expansion of macro 'dev_dbg' > dev_dbg(dd->dev, "xmit_cpu: digcnt: 0x%llx 0x%llx, length: %d, final: %d\n", > ^ > drivers/crypto/atmel-sha.c: In function 'atmel_sha_xmit_pdc': > drivers/crypto/atmel-sha.c:600:19: warning: format '%d' expects argument of type 'int', but argument 6 has type 'size_t {aka long unsigned int}' [-Wformat=] > dev_dbg(dd->dev, "xmit_pdc: digcnt: 0x%llx 0x%llx, length: %d, final: %d\n", > ^ > include/linux/dynamic_debug.h:134:39: note: in definition of macro 'dynamic_dev_dbg' > __dynamic_dev_dbg(&descriptor, dev, fmt, \ > ^ > drivers/crypto/atmel-sha.c:600:2: note: in expansion of macro 'dev_dbg' > dev_dbg(dd->dev, "xmit_pdc: digcnt: 0x%llx 0x%llx, length: %d, final: %d\n", > ^ > drivers/crypto/atmel-sha.c: In function 'atmel_sha_xmit_dma': > drivers/crypto/atmel-sha.c:647:19: warning: format '%d' expects argument of type 'int', but argument 6 has type 'size_t {aka long unsigned int}' [-Wformat=] > dev_dbg(dd->dev, "xmit_dma: digcnt: 0x%llx 0x%llx, length: %d, final: %d\n", > ^ > include/linux/dynamic_debug.h:134:39: note: in definition of macro 'dynamic_dev_dbg' > __dynamic_dev_dbg(&descriptor, dev, fmt, \ > ^ > drivers/crypto/atmel-sha.c:647:2: note: in expansion of macro 'dev_dbg' > dev_dbg(dd->dev, "xmit_dma: digcnt: 0x%llx 0x%llx, length: %d, final: %d\n", > ^ > drivers/crypto/atmel-sha.c: In function 'atmel_sha_xmit_dma_map': > drivers/crypto/atmel-sha.c:726:20: warning: format '%u' expects argument of type 'unsigned int', but argument 3 has type 'size_t {aka long unsigned int}' [-Wformat=] > dev_err(dd->dev, "dma %u bytes error\n", ctx->buflen + > ^ > In file included from include/linux/printk.h:329:0, > from include/linux/kernel.h:13, > from drivers/crypto/atmel-sha.c:17: > drivers/crypto/atmel-sha.c: In function 'atmel_sha_update_dma_slow': > drivers/crypto/atmel-sha.c:747:19: warning: format '%u' expects argument of type 'unsigned int', but argument 4 has type 'size_t {aka long unsigned int}' [-Wformat=] > dev_dbg(dd->dev, "slow: bufcnt: %u, digcnt: 0x%llx 0x%llx, final: %d\n", > ^ > include/linux/dynamic_debug.h:134:39: note: in definition of macro 'dynamic_dev_dbg' > __dynamic_dev_dbg(&descriptor, dev, fmt, \ > ^ > drivers/crypto/atmel-sha.c:747:2: note: in expansion of macro 'dev_dbg' > dev_dbg(dd->dev, "slow: bufcnt: %u, digcnt: 0x%llx 0x%llx, final: %d\n", > ^ > drivers/crypto/atmel-sha.c: In function 'atmel_sha_update_dma_start': > drivers/crypto/atmel-sha.c:775:19: warning: format '%u' expects argument of type 'unsigned int', but argument 6 has type 'size_t {aka long unsigned int}' [-Wformat=] > dev_dbg(dd->dev, "fast: digcnt: 0x%llx 0x%llx, bufcnt: %u, total: %u\n", > ^ > include/linux/dynamic_debug.h:134:39: note: in definition of macro 'dynamic_dev_dbg' > __dynamic_dev_dbg(&descriptor, dev, fmt, \ > ^ > drivers/crypto/atmel-sha.c:775:2: note: in expansion of macro 'dev_dbg' > dev_dbg(dd->dev, "fast: digcnt: 0x%llx 0x%llx, bufcnt: %u, total: %u\n", > ^ > drivers/crypto/atmel-sha.c:817:21: warning: format '%u' expects argument of type 'unsigned int', but argument 3 has type 'size_t {aka long unsigned int}' [-Wformat=] > dev_err(dd->dev, "dma %u bytes error\n", > ^ > In file included from include/linux/printk.h:329:0, > from include/linux/kernel.h:13, > from drivers/crypto/atmel-sha.c:17: > drivers/crypto/atmel-sha.c: In function 'atmel_sha_finish': > drivers/crypto/atmel-sha.c:997:19: warning: format '%d' expects argument of type 'int', but argument 6 has type 'size_t {aka long unsigned int}' [-Wformat=] > dev_dbg(dd->dev, "digcnt: 0x%llx 0x%llx, bufcnt: %d\n", ctx->digcnt[1], > ^ > include/linux/dynamic_debug.h:134:39: note: in definition of macro 'dynamic_dev_dbg' > __dynamic_dev_dbg(&descriptor, dev, fmt, \ > ^ > drivers/crypto/atmel-sha.c:997:2: note: in expansion of macro 'dev_dbg' > dev_dbg(dd->dev, "digcnt: 0x%llx 0x%llx, bufcnt: %d\n", ctx->digcnt[1], > ^ > > I am not sure what caused this, but it may be that this code has not > been built for this platform before? > Indeed, the drivers/crypto/atmel-sha.c driver has never been built for x86_64. CRYPTO_DEV_ATMEL_AUTHENC must select both CRYPTO_DEV_ATMEL_AES and CRYPTO_DEV_ATMEL_SHA. I thought I could add a dependency to COMPILE_TEST for CRYPTO_DEV_ATMEL_AUTHENC since CRYPTO_DEV_ATMEL_AES already had such a dependency, hence could be compiled on architectures other than AT91 but I didn't check the same for CRYPTO_DEV_ATMEL_SHA. So maybe the easiest solution could be to remove the COMPILE_TEST dependency on CRYPTO_DEV_ATMEL_AUTHENC for now, then I could try to fix all these dev_dbg() format strings to make them become cross-platform compliant. Herbert, if you think this solution is suitable I can prepare a first patch to remove the COMPILE_TEST dependency on CRYPTO_DEV_ATMEL_AUTHENC. Best regards, Cyrille