From: Philipp Zabel <p.zabel@pengutronix.de>
To: Corentin Labbe <clabbe.montjoie@gmail.com>,
davem@davemloft.net, herbert@gondor.apana.org.au,
mark.rutland@arm.com, mripard@kernel.org, robh+dt@kernel.org,
wens@csie.org
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-sunxi@googlegroups.com
Subject: Re: [PATCH v3 1/4] crypto: Add Allwinner sun8i-ss cryptographic offloader
Date: Mon, 28 Oct 2019 14:00:28 +0100 [thread overview]
Message-ID: <7bbd6c77117d2391f6669a9eb958730717ea295c.camel@pengutronix.de> (raw)
In-Reply-To: <20191025185128.24068-2-clabbe.montjoie@gmail.com>
Hi Corentin,
On Fri, 2019-10-25 at 20:51 +0200, Corentin Labbe wrote:
> The Security System is an hardware cryptographic offloader present
> on Allwinner SoCs A80 and A83T.
> It is different from the previous sun4i-ss.
>
> This driver supports AES cipher in CBC and ECB mode.
>
> Acked-by: Maxime Ripard <mripard@kernel.org>
> Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
> ---
[...]
> +static int sun8i_ss_probe(struct platform_device *pdev)
> +{
> + struct sun8i_ss_dev *ss;
> + int err, irq;
> + u32 v;
> +
> + ss = devm_kzalloc(&pdev->dev, sizeof(*ss), GFP_KERNEL);
> + if (!ss)
> + return -ENOMEM;
[...]
> +
> + ss->reset = devm_reset_control_get(&pdev->dev, NULL);
It looks like this driver could use devm_reset_control_get_shared() to
get a (clk-like) refcounted reset control. Otherwise, please use
devm_reset_control_get_exclusive() instead of devm_reset_control_get().
See the kerneldoc comment for reset_control_get_shared() for details.
regards
Philipp
next prev parent reply other threads:[~2019-10-28 13:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-25 18:51 [PATCH v3 0/4] crypto: add sun8i-ss driver for Allwinner Security System Corentin Labbe
2019-10-25 18:51 ` [PATCH v3 1/4] crypto: Add Allwinner sun8i-ss cryptographic offloader Corentin Labbe
2019-10-28 13:00 ` Philipp Zabel [this message]
2019-10-25 18:51 ` [PATCH v3 2/4] dt-bindings: crypto: Add DT bindings documentation for sun8i-ss Security System Corentin Labbe
2019-10-27 9:59 ` Maxime Ripard
2019-10-29 22:13 ` Rob Herring
2019-10-25 18:51 ` [PATCH v3 3/4] ARM: dts: sun8i: a83t: Add Security System node Corentin Labbe
2019-10-25 18:51 ` [PATCH v3 4/4] ARM: dts: sun9i: a80: " Corentin Labbe
2019-11-01 6:11 ` [PATCH v3 0/4] crypto: add sun8i-ss driver for Allwinner Security System Herbert Xu
2019-11-01 8:58 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7bbd6c77117d2391f6669a9eb958730717ea295c.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=clabbe.montjoie@gmail.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=mark.rutland@arm.com \
--cc=mripard@kernel.org \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).