From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CF37C54FCC for ; Tue, 21 Apr 2020 15:25:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CA5992068F for ; Tue, 21 Apr 2020 15:25:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=walle.cc header.i=@walle.cc header.b="duObSLhe" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726337AbgDUPZW (ORCPT ); Tue, 21 Apr 2020 11:25:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57184 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725613AbgDUPZV (ORCPT ); Tue, 21 Apr 2020 11:25:21 -0400 Received: from ssl.serverraum.org (ssl.serverraum.org [IPv6:2a01:4f8:151:8464::1:2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 82B28C061A10; Tue, 21 Apr 2020 08:25:21 -0700 (PDT) Received: from ssl.serverraum.org (web.serverraum.org [172.16.0.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ssl.serverraum.org (Postfix) with ESMTPSA id 5776323059; Tue, 21 Apr 2020 17:25:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2016061301; t=1587482719; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8QsvXJy4QN7Mhtq+sVqR6fne5if5MqXv+cU/VAiszjI=; b=duObSLhe+gutB6BVnKAuL4/s+7UfON76l+ghN0faiJPKhgX5tO8nEWxTY0MP5SYpK1JIAH rnmWQnFQXlD0Tm+4rra8AJBa2J4atfb24lZZywzwVoCVQYkOyhXa+ziy+9URAKUPtsVaAR CySjExY++bC35ycrNpAGcPDvonBn1tI= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 21 Apr 2020 17:25:19 +0200 From: Michael Walle To: linux-kernel@vger.kernel.org, netdev@vger.kernel.org Cc: Andrew Lunn , Florian Fainelli , Heiner Kallweit , Russell King , "David S . Miller" , Vladimir Oltean Subject: Re: [RFC PATCH net-next 1/3] net: phy: add concept of shared storage for PHYs In-Reply-To: <20200420232624.9127-1-michael@walle.cc> References: <20200420232624.9127-1-michael@walle.cc> Message-ID: <7bcd7a65740a6f85637ef17ed6b6a1e3@walle.cc> X-Sender: michael@walle.cc User-Agent: Roundcube Webmail/1.3.10 X-Spamd-Bar: + X-Rspamd-Server: web X-Rspamd-Queue-Id: 5776323059 X-Spamd-Result: default: False [1.40 / 15.00]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TAGGED_RCPT(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DKIM_SIGNED(0.00)[]; RCPT_COUNT_SEVEN(0.00)[8]; NEURAL_HAM(-0.00)[-0.972]; RCVD_COUNT_ZERO(0.00)[0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_CC(0.00)[lunn.ch,gmail.com,armlinux.org.uk,davemloft.net,nxp.com]; MID_RHS_MATCH_FROM(0.00)[]; SUSPICIOUS_RECIPS(1.50)[] Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 2020-04-21 01:26, schrieb Michael Walle: > + > +/* Represents a shared structure between different phydev's in the > same > + * package, for example a quad PHY. See phy_package_join() and > + * phy_package_leave(). > + */ > +struct phy_package_shared { > + int addr; > + refcount_t refcnt; > + unsigned long flags; > + > + /* private data pointer */ > + /* note that this pointer is shared between different phydevs and > + * the user has to take care of appropriate locking. > + */ > + void *priv; btw. how should a driver actually use this? I mean, it can allocate memory if its still NULL but when will it be freed again. Do we need a callback? Is there something better than a callback? -michael