From: Yuehaibing <yuehaibing@huawei.com>
To: Florian Fainelli <f.fainelli@gmail.com>,
<herbert@gondor.apana.org.au>, <mpm@selenic.com>, <arnd@arndb.de>,
<gregkh@linuxfoundation.org>, <nicolas.ferre@microchip.com>,
<alexandre.belloni@bootlin.com>,
<ludovic.desroches@microchip.com>, <rjui@broadcom.com>,
<sbranden@broadcom.com>, <bcm-kernel-feedback-list@broadcom.com>,
<eric@anholt.net>, <wahrenst@gmx.net>, <l.stelmach@samsung.com>,
<kgene@kernel.org>, <krzk@kernel.org>, <khilman@baylibre.com>,
<dsaxena@plexity.net>, <patrice.chotard@st.com>
Cc: <linux-crypto@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
<linux-rpi-kernel@lists.infradead.org>,
<linux-samsung-soc@vger.kernel.org>,
<linux-amlogic@lists.infradead.org>,
<linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH -next 00/13] hwrng: use devm_platform_ioremap_resource() to simplify code
Date: Thu, 17 Oct 2019 09:27:13 +0800 [thread overview]
Message-ID: <7c0269b6-cab3-bded-7f9d-76430be89f9c@huawei.com> (raw)
In-Reply-To: <2c60b926-1e98-cca0-ec17-6b45f9da404a@gmail.com>
On 2019/10/17 0:44, Florian Fainelli wrote:
> On 10/16/19 3:46 AM, YueHaibing wrote:
>> devm_platform_ioremap_resource() internally have platform_get_resource()
>> and devm_ioremap_resource() in it. So instead of calling them separately
>> use devm_platform_ioremap_resource() directly.
>
> Did your coccinelle script not cover
> drivers/char/hw_random/iproc-rng200.c somehow? Do you mind including it
> as a separate patch?
A patch from Markus Elfring has be queued:
commit a68b931932c5574aa5bd459529c766ba577c72b3
Author: Markus Elfring <elfring@users.sourceforge.net>
Date: Wed Sep 18 09:09:22 2019 +0200
hwrng: iproc-rng200 - Use devm_platform_ioremap_resource() in iproc_rng200_probe()
Simplify this function implementation by using a known wrapper function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Reviewed-by: Ray Jui <ray.jui@broadcom.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
> Thanks
>
>>
>> YueHaibing (13):
>> hwrng: atmel - use devm_platform_ioremap_resource() to simplify code
>> hwrng: bcm2835 - use devm_platform_ioremap_resource() to simplify code
>> hwrng: exynos - use devm_platform_ioremap_resource() to simplify code
>> hwrng: hisi - use devm_platform_ioremap_resource() to simplify code
>> hwrng: ks-sa - use devm_platform_ioremap_resource() to simplify code
>> hwrng: meson - use devm_platform_ioremap_resource() to simplify code
>> hwrng: npcm - use devm_platform_ioremap_resource() to simplify code
>> hwrng: omap - use devm_platform_ioremap_resource() to simplify code
>> hwrng: pasemi - use devm_platform_ioremap_resource() to simplify code
>> hwrng: pic32 - use devm_platform_ioremap_resource() to simplify code
>> hwrng: st - use devm_platform_ioremap_resource() to simplify code
>> hwrng: tx4939 - use devm_platform_ioremap_resource() to simplify code
>> hwrng: xgene - use devm_platform_ioremap_resource() to simplify code
>>
>> drivers/char/hw_random/atmel-rng.c | 4 +---
>> drivers/char/hw_random/bcm2835-rng.c | 5 +----
>> drivers/char/hw_random/exynos-trng.c | 4 +---
>> drivers/char/hw_random/hisi-rng.c | 4 +---
>> drivers/char/hw_random/ks-sa-rng.c | 4 +---
>> drivers/char/hw_random/meson-rng.c | 4 +---
>> drivers/char/hw_random/npcm-rng.c | 4 +---
>> drivers/char/hw_random/omap-rng.c | 4 +---
>> drivers/char/hw_random/pasemi-rng.c | 4 +---
>> drivers/char/hw_random/pic32-rng.c | 4 +---
>> drivers/char/hw_random/st-rng.c | 4 +---
>> drivers/char/hw_random/tx4939-rng.c | 4 +---
>> drivers/char/hw_random/xgene-rng.c | 4 +---
>> 13 files changed, 13 insertions(+), 40 deletions(-)
>>
>
>
next prev parent reply other threads:[~2019-10-17 1:27 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-16 10:46 [PATCH -next 00/13] hwrng: use devm_platform_ioremap_resource() to simplify code YueHaibing
2019-10-16 10:46 ` [PATCH -next 01/13] hwrng: atmel - " YueHaibing
2019-10-17 9:32 ` Ludovic Desroches
2019-10-16 10:46 ` [PATCH -next 02/13] hwrng: bcm2835 " YueHaibing
2019-10-16 16:41 ` Florian Fainelli
2019-10-16 10:46 ` [PATCH -next 03/13] hwrng: exynos " YueHaibing
[not found] ` <CGME20191018150543eucas1p1cf4312467597ad7c76f258e924d8184a@eucas1p1.samsung.com>
2019-10-18 15:05 ` Łukasz Stelmach
2019-10-16 10:46 ` [PATCH -next 04/13] hwrng: hisi " YueHaibing
2019-10-16 10:46 ` [PATCH -next 05/13] hwrng: ks-sa " YueHaibing
2019-10-16 10:46 ` [PATCH -next 06/13] hwrng: meson " YueHaibing
2019-10-16 16:26 ` Kevin Hilman
2019-10-16 10:46 ` [PATCH -next 07/13] hwrng: npcm " YueHaibing
2019-10-16 10:46 ` [PATCH -next 08/13] hwrng: omap " YueHaibing
2019-10-16 10:46 ` [PATCH -next 09/13] hwrng: pasemi " YueHaibing
2019-10-16 10:46 ` [PATCH -next 10/13] hwrng: pic32 " YueHaibing
2019-10-16 10:46 ` [PATCH -next 11/13] hwrng: st " YueHaibing
2019-10-16 11:29 ` Patrice CHOTARD
2019-10-16 10:46 ` [PATCH -next 12/13] hwrng: tx4939 " YueHaibing
2019-10-16 10:46 ` [PATCH -next 13/13] hwrng: xgene " YueHaibing
2019-10-16 16:44 ` [PATCH -next 00/13] hwrng: " Florian Fainelli
2019-10-17 1:27 ` Yuehaibing [this message]
2019-10-25 15:20 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7c0269b6-cab3-bded-7f9d-76430be89f9c@huawei.com \
--to=yuehaibing@huawei.com \
--cc=alexandre.belloni@bootlin.com \
--cc=arnd@arndb.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=dsaxena@plexity.net \
--cc=eric@anholt.net \
--cc=f.fainelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=herbert@gondor.apana.org.au \
--cc=kgene@kernel.org \
--cc=khilman@baylibre.com \
--cc=krzk@kernel.org \
--cc=l.stelmach@samsung.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=ludovic.desroches@microchip.com \
--cc=mpm@selenic.com \
--cc=nicolas.ferre@microchip.com \
--cc=patrice.chotard@st.com \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=wahrenst@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).