From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965914AbdEWGtl (ORCPT ); Tue, 23 May 2017 02:49:41 -0400 Received: from mail-db5eur01on0097.outbound.protection.outlook.com ([104.47.2.97]:59744 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933142AbdEWGtf (ORCPT ); Tue, 23 May 2017 02:49:35 -0400 Authentication-Results: vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=axentia.se; Subject: Re: struct i2c_mux_pinctrl_platform_data for the i2c-mux-pinctrl driver To: Stephen Warren , Stephen Warren Cc: "linux-i2c@vger.kernel.org" , "linux-kernel@vger.kernel.org" References: <264eee82-8e0f-7d63-5c2f-e4070bf56c63@axentia.se> <71dc13f9-f723-fb4b-a101-f7be8caacf1c@wwwdotorg.org> From: Peter Rosin Organization: Axentia Technologies AB Message-ID: <7c06a6f0-e8ef-3abc-3c68-dec7dedbf0ae@axentia.se> Date: Tue, 23 May 2017 08:49:19 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <71dc13f9-f723-fb4b-a101-f7be8caacf1c@wwwdotorg.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [81.224.171.159] X-ClientProxiedBy: VI1PR0701CA0048.eurprd07.prod.outlook.com (10.173.77.34) To VI1PR0202MB2557.eurprd02.prod.outlook.com (10.173.79.136) X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VI1PR0202MB2557: X-MS-Office365-Filtering-Correlation-Id: bef1e4ae-5327-4215-fbe6-08d4a1a7dda2 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(201703131423075);SRVR:VI1PR0202MB2557; X-Microsoft-Exchange-Diagnostics: 1;VI1PR0202MB2557;3:M7cseBZzEfB2ktu4EaOqBe9rjIOdK/y0Qu2nkZWiby/rUNvqeyMqljw7t8ocwkcHdDzD0rfSS5puVjWbs1Cp+kZaXhYOenakYXz/ZGktJNoF9eCvl43gcs4OBuGiKuQx8br4uff81GAwIMkbk0l45ZwsYlpzDTdghlo/Xbxtaiw5eSnswTkmBXjg4JQ4IjZvAmXizf5iIUOYkcKntJ5ABwF5+CMBOgYXRga5FuI/nvs1ckop0EX/2QRRu6tDLeSvx3l78Pe96xxBBlp2ymBcD125AGNBNDbcjeXFhgzZXrg=;25:BMsnuvzOnt42qAolzXhAJSCWieIitoKRw5UPaiF1ae2CKUQ0SWNqFlzKZY8KkZBHvKfI2AbAZlwbu3oJQVku90w9Wd40KZBdjKr8aNqN132RKMRdquY/35eMOotusw7RvKmog+DUrfum2XiI0fliB86GXhSO3s0SAiQPF54kY5tdZm51GYf6nsRJoykFnNnKbQm3PG4kU+cQuZyCpyN5+ADFOjIFZTRf7tj+sCXCE7nmNg1EdzvB0VuAuEByhf9PSAcO8oIknKh8IfHEYX28gmsgpNi58Ii4HvmIHBvOxUFEvzRQLa2QWTFomDygga0oB60vlJAL1Ga/GVBQ4VnrziocCsRsS8CbRMhEjoJreYzJ2UKd8m0Rbnu7mqJdJ1u+AGlzoY5kQqC5lsoCDthyZgbU44v8i7rmGBMCvKJcuuL9Cd/Nx1qWdS4XA0Th7mRz2dE6FsuT04sHnNR95n3nSzQN0OPw9CZKn+VbrzHvR7M= X-Microsoft-Exchange-Diagnostics: 1;VI1PR0202MB2557;31:zPi+fVDMCTo7kIV4bB+XkHotGxGh0nrQgskpllVphNLS7eww1N4lQvno98yfMAalXunx7FZZrKGQrEi/OuSEOSgEf9LtB0dKGwKPTgWiuJKIWzS3Yye1+nk3evoLKXsQ5d1eNiIjgWwr1ry4+YQ+ANUZ2y7iMwFHCu97VBQwh6y4TPbynqDAN8v6bHXv5srntFFgWU5aobRr0otvWp6onvnmFH200vMYBPDrKcHZVuavoKq5VPUGOKZLqIpDdcfEEVZhRJuGABrbIGTVEdrc4Q== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(209352067349851); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(93006095)(93001095)(6041248)(2016111802025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123560025)(20161123562025)(20161123558100)(6043046)(6072148);SRVR:VI1PR0202MB2557;BCL:0;PCL:0;RULEID:;SRVR:VI1PR0202MB2557; X-Microsoft-Exchange-Diagnostics: 1;VI1PR0202MB2557;4:+N4Okq39Y6SoMXLiXFH6y7JrLzzMFybLuqoI/uETccoNdQTXg689iwxHG8E6i15O4jREVVoNOmD/quCNvCjgfEwjednmGa9E7tbYZc2TKDn9Nntlo14LD0Zs1xtnDekUNmO200iYCbNvRZ8oJMhMvh4V6b4N/qlxeRlRzy9yxvX34pzGxAZoZRNRUCpW2uSwOrQh+tlYdffbmgyW5mCZrfox6z0DGlCrEWzlH2oJdObjrR36YkfGhhLu415B4uQYIZCE+vz3u5ffDCL+uGB71sd3L+w8n+yY4HqqYHf9DlFEpUuds2fXqLtt0Qar7lUakRHXwstfw1yc5wbBZdi4Jtra2JklZ3VgncA4OJErTjDZXMnQxPYf8FtRijPvuvg3FFoIhC0BF9jIpCBriQ6j0LjmhfB5OqLGqC7Z9241WAV7/ovUXFPavt0jXpEuztAUocLRDPMD1Ncm27g7HU9Ztso1wFEFLKP9867cscSUSoE0EM0Unwmw/kfKmp+42musvbeMxZCr8JA9T/EEO2AzIGuGcWn67mFFf5seFApGJEwx9gwl5TnfU2JGxVxZ0Dvs1I8O66eeUKbLr7hsFAw5PxtHUwcdZGoNbJk+jBKNU19bxtWC+Ly5/tmqTPLaLn1tOcSzmhm9wVEe7zvkv5HuJgKxlZE0M7R4M1Q8MuTB7oOWhxxJW4NZdxLe10ZWMxd3HqLrvg635aGatgfvL/3sLrJmdMcvjYBp/98TJUe+xPe5nLuflJt20X+VYYQmgXiWbJE2V/PwHqLOYjbVE89TaPzjkuWjl95PUKdkUnAnkAV6MUJStChyIsAWfmWKbQv3Zk7n7dV+lGXxbl+KLU9NI71tcAeubHDcHDQSAya25hbaKi/BQ/cUpw2qB43XKKNZ X-Forefront-PRVS: 0316567485 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(6049001)(39400400002)(39410400002)(39450400003)(39830400002)(377454003)(24454002)(377424004)(74482002)(478600001)(53936002)(3846002)(229853002)(50466002)(5660300001)(230700001)(50986999)(36756003)(6116002)(6246003)(81166006)(6486002)(305945005)(54906002)(77096006)(7736002)(31696002)(90366009)(38730400002)(47776003)(33646002)(42186005)(25786009)(189998001)(54356999)(76176999)(2906002)(8676002)(230783001)(66066001)(31686004)(86362001)(2950100002)(23676002)(4326008)(117156002)(53546009)(6666003)(15760500002)(42262002);DIR:OUT;SFP:1102;SCL:1;SRVR:VI1PR0202MB2557;H:[192.168.0.125];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtWSTFQUjAyMDJNQjI1NTc7MjM6UjN0R1M0V1Y5bjBicnU3RGVBOU5sUHRk?= =?utf-8?B?ZVBGUUp6bUduaCtRdGsrYXpXRGVFT0o0a0ZpSmR2SlFOQjBTWkhlUTk4eXRp?= =?utf-8?B?OGRCUTRPUWR6V2d4YnAyZ1dyRCtFQ3RYVFY5anN1RWxpZmdoRFVsUDRWUmla?= =?utf-8?B?UGgrbXhHcVgzNHVXeFJEZ1F1M0dKbWxsc2RvbWZaVm42d1kwT0ZKQnpCU2Rk?= =?utf-8?B?TEY5RDdUNytrWENSZlZDYm1nRVRwVjFpZlJsQUFEQkFOb3RzSGJldWo5ZE1j?= =?utf-8?B?V3k2VXdVOVNEaDNCSHMzYVluWFI4Qk5OUVNsMzNmMkRLcDg4ZXE4enB3LytW?= =?utf-8?B?Njl5L0JHWEVIcU0rQm84ZmlsZHZoNUQzRUFkc3FJRFZ6b1hzVWthTS9COGFX?= =?utf-8?B?THlGckNKSGdyYklwdCtKTmlpV09INFh3UnA1THVoTEdNZ1NZREkvaUdkZUJ2?= =?utf-8?B?MGMrcTcxYUgzdjFDbXVqZzZFcitzV0ljWDVNV3RHUE10NWpyU1VzQmhWZ0Fq?= =?utf-8?B?Q0wwVmNsamFTKzRzeDBuNlhrRnJhOEROaHhWU3pzeklvR3BUaXNTOVE4OW9K?= =?utf-8?B?REIwaFFwb2lGZmcvR3NJSW9DdnRUQ1dLZEpzUlNZWXVDYng4QTdjb0N5Smo0?= =?utf-8?B?UjFNR2ZyWVhWR2ZrVEovaVlnbWJGWEFJbjlEODBzQnBrMnY5ajJZTjV4aVJ4?= =?utf-8?B?bUwxQ2dxb0tiMnRjb2hRaVRKYjRmWXgxcUhWMjNhT2xwNUhwb01FMFdxUW9l?= =?utf-8?B?SmpIU2RCVHJEMWRWanhWYnRVZmF4amJDZ0VvZWFaK0ZtYm02SWVUdkZRMnY3?= =?utf-8?B?NmpTOW1OK2w1Y3l5UTRGQ0pMcmc1YVpPLzltSmlBWTI4eU9VZ1NVYjJtTDRr?= =?utf-8?B?aENjVXp0TTMrVGtFSzBFNGQzR29xQU5xUEhWOFpvcDd1NDV2N0g0c2x4bjZx?= =?utf-8?B?QzVMRXVXRFpsYWF2S0VWa2VpZnhWZTBkRkZsWDgvbThDeDQ5RWFXTnNEWjR3?= =?utf-8?B?NGN3VHQwemVCZEk3Rm1BQlBxN3djVnVWRDgySjkvS0dXbnBEcnRadDlMcHpJ?= =?utf-8?B?Zy9QQWRZbDZSVkt2RlhtQ0dnRnBWN2FyOEVOa09JcWcrdGxuUmZ4QkRJb1JS?= =?utf-8?B?RjljL2VDd2JqeVpBelJCSThJMncxazlST3ZOZFBad3pTNjVsTnBIczNRZE54?= =?utf-8?B?b0ZsS09kZFh3dzJsOFJxRjVZM21oT0RsL0E4QU93YWZNcGo4NnVINTRDMlVN?= =?utf-8?B?QTU1Tm1KYzVUaFBkazR4ZXNOZUpUMmVzQ2VFTGtLNVBhZThxOUlsQktuWGtL?= =?utf-8?B?RCtpb2MxTEFSZ2dlM2wwbnRvYS9sejgyRjMrNFpXUzVyYVRDS3VDYm1mNTNS?= =?utf-8?B?dnBod2dBNXpKbW5tVzRrdDdWSHU0ZDc2TzV6WXFxZWkrSlNGY3BpWFI2QmdV?= =?utf-8?B?aXU3MU0xcFhTdlhodmo0aDRvTDEzenoyc09vYm11WnV1RU9jY1oxTzFocjRX?= =?utf-8?B?THU2YUVJSVY3WmtnbzhjbjNzUis0TzB3T2NSWTVGRk5KK2xjRXhFQjdtdmpx?= =?utf-8?B?RGNxdUxoaEdnSnFGaExKWG5DWjJrWlhvQThtY0lEdE9JbW9Mb0hha3Jqbnk4?= =?utf-8?B?OGRiUVdWRHhxYk92c1FlMzAvWGVyeFNGanQxK3FSTlVZSS9hM1dudnVVOVlJ?= =?utf-8?B?WnV6TENEQXFLQ0pqbm5jMUtsdUJjVTlla3J1dkN0K0JPN2lLU1FmSkF1bjBu?= =?utf-8?B?bXBteDJNdHY2dVRBaU5PWVp3PT0=?= X-Microsoft-Exchange-Diagnostics: 1;VI1PR0202MB2557;6:OLzz+v4DbXTIaueAY82LCaLkSZVdwlRJFtHL8woJOQa71kATT/ILQa2eyzkMHFQBjEX+kQ2z/VuQ29XUI9cZYCeXmunHxPJiabexEu8IT/hjc7b+K1NdA10joUKXLqGBeuuczPtwrmohYKNMAr7FzEi63NJ4irO+2WSwvedJr+gGRAQmen49RYA2mUqXizFEN6n7PKCVKmzmqF7B47b9b761kh00ledV8bccKbZmv84YINQsc9abCXaITWAo1t6A+nuHIt/Nbio1+GeMj+OKapVsz6lnz0ASH25uwkgUAQ0ChvzmoCbg6BBo+tphX5/cYfBXVLH+G/franp4wUfq905vUfUYTyeQje9Fw3OjhFAID0I5HmY4Pi1swIAaunFJYQGy35rmhfEZKv6lYpGK4AQkmAU/DtCrL48t/NjuV/JrV5k0EIIruOywkGkf/yCRsR4Z2A5VdOY9qA0vIfYBQRxpO5K/jJHq0TiP/v0Y4ElIPLX6nufleWGhBLJ5pc+AenhvcG8B6a47clhDKXeviA==;5:R4LsdeHjE7+q7n0e6vOltIqq8M0fVhgDUNy6nncaVhS8r4pOZRuUWr1vDlUEDWHqdP3hBus1SdXxKhM/an81G50Sr7aSeqCojsnzeI6AOyfNNvF02QCKV5YzqnM+/58WJ60WXoszhT87415SfUOefQ==;24:1y2tBnNbmeGGNxMG0H9LgfKS4i6hVLtYy0uF8nv4lZTH8xmdMxrfs0TyjYxM3fV0qJMJ/boMMolmYT5dwv8tXsoxFQ8o00wzGhdhtBsIbvg= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;VI1PR0202MB2557;7:3SS6daqDVBM08Mr3m3noP6wAbD/rJRJQSiV+UUpxdEGLy9rybWwc6kLTNmkzrqUV5CT5B0TE0gOv/PYuT9g6WB+4XNRDWtBg2dYPwNZTSZQSLhHJ6aJmceiO0s83toWlfens+JOP/ZeMW1ZoQNLEUD05AgIIlH6myMlcq8tLIodWi6g358JJesP71QOwkPc+rdJpz8BX/yZN1Sve0KF2L2Ni1QxauxRHoI74OmvxgT7PFxq8lP3PU12V1vUFKN9+0jhlnRTlXasAlFgKdSgl3C0rX8lA4uWdJkYW62q5xDheX3SEVmVoGWTDzbUwz0YrQnndr7CrKgK3E8mlTA0eCQ== X-OriginatorOrg: axentia.se X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2017 06:49:31.1164 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0202MB2557 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017-05-22 17:51, Stephen Warren wrote: > On 05/22/2017 02:24 AM, Peter Rosin wrote: >> Hi Stephen, >> >> I was looking at the i2c-mux-pinctrl driver and noticed that it has >> code to feed it platform data from C code. There has never been any >> in-kernel users of this interface and I would like to remove it. I >> wonder if you added it way back when just because the i2c-mux-gpio >> driver have such an interface or if, to your knowledge, any external >> platform exists that depends on this? >> >> I.e. I'm talking about removing include/linux/i2c-mux-pinctrl.h and >> the code supporting it in the driver, thus only allowing devicetree >> as source for the platform data. > > I'm not aware of any in- or out-of-tree users of that structure/feature. > > I added it because at the time I wrote that driver, it was common place > to support both DT-based and platform-data-based > instantiation/configuration of devices, so I did the same. If you're That's what I suspected, thanks for confirming! > removing pdata-based configuration, it would make sense to do a blanket > removal across the entire I2C subsystem (and other subsystems too) I > suspect, but that's LinusW's call in the end. (Wolfram Sang is the I2C maintainer) Well, a couple of other drivers I looked at still have in-tree users. This driver stands out in that it never ever had any in-tree user, and I find no traces of any out-of-tree user either. That last bit might of course be due to lacking google-fu on my part or that the out-of- tree user was never available online in the first place. But it is a data point. Also, removing a third or so of the driver and at the same time making it easier to follow the code sounds like something I want to do. Embarking on the bigger project is however not something I'm signing up for, not that I don't think it would be worthwhile. I'll send a patch when I have done some further tests with what I have cooking... Cheers, peda