From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 979D4C433ED for ; Tue, 18 May 2021 18:04:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7697E611CE for ; Tue, 18 May 2021 18:04:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351446AbhERSFk (ORCPT ); Tue, 18 May 2021 14:05:40 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:21789 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344188AbhERSFj (ORCPT ); Tue, 18 May 2021 14:05:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621361060; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=++IBdwTXrkj6TN5tFUW8jJ28IMikx/q1mGUkdBnMJhQ=; b=N32fpPzze0JWs7ShoENSTcIswkdafhGLZGjQSLG0G38rR1ncWLN1x0pB9Xou574N4yE7CX cNmYiSaV06Qb+1W1TY2jgO3gHbdn4s/KA/aRTgLmcE4vW6u1woSX4wW7xTQjDDmpA/p+xW wB0ixUt1+Eqe35+o1RSgtB2hL7mEoNY= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-210-BaNTfrXoMIeBuby8Qub_vw-1; Tue, 18 May 2021 14:04:18 -0400 X-MC-Unique: BaNTfrXoMIeBuby8Qub_vw-1 Received: by mail-wm1-f70.google.com with SMTP id j128-20020a1c55860000b02901384b712094so795030wmb.2 for ; Tue, 18 May 2021 11:04:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version; bh=++IBdwTXrkj6TN5tFUW8jJ28IMikx/q1mGUkdBnMJhQ=; b=frz8Yc4ZbAJ9/7fZX/Et5kwUl9/eMGECBD0TPj2P7aI8pdlNQFk778wIKgCNbrsV3D 2mIhUtSUxJrGmc/gl9Xchrpeuk6SFlY0nfBOKD9P37hXoAbMdfz8jCDBoZu27+KD/qXc Kzw5HhBdsEv7/I6X1G1DAPc0qyY6DpiaPTmxewKjjxlfv8vuF11i/EHcwlDqDwBnIRIz +Sr5spd8XLWIc0X9WT0scuQacd+SiAK4jJW4orUvMRauQ1uzCnp78MlUFKMD0BCXwJRg Tilyww0+P5SI1M1/qSbVk8n/cTIsSBERcUibTHZ+ENzSesfrXHqPX0HHSbQdzjrY+tkT l16A== X-Gm-Message-State: AOAM532qfuukzrUFMLE0JRYHzDt4yrEUrc1Gz8k0IhTRbT1giI7h6Enj KWwh71JC2Ipm/r2GcIY5iAoesJ1kEcdY5ZReMkEeJ2Pn2bjQLRZ5aUbGyIHhUFezVUvQUbageug m4wQPblthePYRe6BVtyjw2YHd X-Received: by 2002:a5d:4d4f:: with SMTP id a15mr8504151wru.187.1621361057349; Tue, 18 May 2021 11:04:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxz2ecus/fq0739wSNsydOGIu6BVxS+/X8uhGrDB66UzjMvRLyJ2oO3ndANIDXUitrRYiOjxA== X-Received: by 2002:a5d:4d4f:: with SMTP id a15mr8504127wru.187.1621361057141; Tue, 18 May 2021 11:04:17 -0700 (PDT) Received: from ?IPv6:2001:16b8:2613:bffc::185? (200116b82613bffc0000000000000185.dip.versatel-1u1.de. [2001:16b8:2613:bffc::185]) by smtp.gmail.com with ESMTPSA id t7sm15798905wrs.87.2021.05.18.11.04.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 May 2021 11:04:16 -0700 (PDT) Message-ID: <7c09a6bf2ee0a644863f1ec8b333c871cf83d5b8.camel@redhat.com> Subject: Re: [PATCH] usb: typec: ucsi: Clear pending after acking connector change From: Benjamin Berg To: Heikki Krogerus Cc: Bjorn Andersson , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Date: Tue, 18 May 2021 20:04:14 +0200 In-Reply-To: References: <20210516040953.622409-1-bjorn.andersson@linaro.org> Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-8Z+unxOuqkr2aCvCa/tM" User-Agent: Evolution 3.40.0 (3.40.0-1.fc34) MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-8Z+unxOuqkr2aCvCa/tM Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2021-05-18 at 16:29 +0300, Heikki Krogerus wrote: > On Mon, May 17, 2021 at 02:57:28PM +0200, Benjamin Berg wrote: > >=20 > > [SNIP] > > Unfortunately, I don't feel it'll work. The problem that I was > > seeing > > looked like a race condition in the PPM itself, where the window is > > the > > time between the UCSI_GET_CONNECTOR_STATUS command and the > > subsequent > > ACK. > > For such a firmware level bug in the PPM, we need a way to detect > > the > > race condition when it happens (or get a fix for the firmware). >=20 > OK. Let me know does the patch bring the issue back for you. So, I just tried the patch, and I can occasionally reproduce the issue where "online" for the ucsi power adapter is stuck at "1" after unplugging with the patch applied. Benjamin --=-8Z+unxOuqkr2aCvCa/tM Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEED2NO4vMS33W8E4AFq6ZWhpmFY3AFAmCkAZ4ACgkQq6ZWhpmF Y3CUXQ/+JPiXi/zXLZ1HUWY+VnsNNMv4cFtjtbtcc1AapCU34szVwLnwuycWtBpO 1wHuiAH4SV+YwFEn5w2qNv4KI268p7bKZPiAtAcohloNGfC45TJ7GCVZmGzIE98I 7nsIyfiB0IgQBAh5LDf7M8WTyANQgrPqx4urq7jBWdPX9vrqvELnNKK6awfuYFJe 3MZVfWwM94JEZ40TcQPfLpO35Wth4ZN7B9BimMD8ZmqoXri9cHxnJQXE9/LtXEht rM5JTItnd4V1V84ytPfy62GblTR0DhHjAWpDKYU03kKH6F11qj0usNd3D1lpWabo rr1dFup7h85iJxHH5FaBqGWFBJu4Vi0jU4/q/lGPde2uGxnPI2v+vSMtFzzCEJer mThkDvLZAIik+f7Gpv4qAF1Rmi7E5xFVQfHV7Pi2ntQCJDKPlf6bvL6PAu8ICwIf aXvInWh7pROGtxkA41GPc/fzKBOL/kZcxcBPokp+JOWNoM2/XF3zN9v7mN0GeNqr uKz43aclO5qi+dI/H21EBNi3rIuCN64yS1GTq65aa4KkGBcyPjzGo+5BYQ34pmkl gVp/oWOqNMhBkh6w+FE9CrDxiNUEqpPYK5ND8FMmsMHorQybkP+k0Cp7ff7f+chw TxQcBPQQUZBlLMAuz2l23eVk4vFKFtHQOJ6nd7lQwonjF++u7ds= =NiPb -----END PGP SIGNATURE----- --=-8Z+unxOuqkr2aCvCa/tM--