From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757226AbcIGMtI (ORCPT ); Wed, 7 Sep 2016 08:49:08 -0400 Received: from mailout4.w1.samsung.com ([210.118.77.14]:54219 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754337AbcIGMtG (ORCPT ); Wed, 7 Sep 2016 08:49:06 -0400 X-AuditID: cbfec7f4-f79cb6d000001359-6d-57d00cbe86ff Subject: Re: [patch] leds: add driver for Mellanox systems leds To: vadimp@mellanox.com, rpurdie@rpsys.net References: <1473255323-191745-1-git-send-email-vadimp@mellanox.com> Cc: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, jiri@resnulli.us, michaelsh@mellanox.com From: Jacek Anaszewski Message-id: <7c223316-4288-1a79-b8d5-67df583f1c0e@samsung.com> Date: Wed, 07 Sep 2016 14:49:00 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-version: 1.0 In-reply-to: <1473255323-191745-1-git-send-email-vadimp@mellanox.com> Content-type: text/plain; charset=windows-1252; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrLLMWRmVeSWpSXmKPExsVy+t/xq7r7eC6EG3xdLGRx8Wq6xeVdc9gs tr5Zx2jxZ/9DJovdu56yWpxfv5vFgc3j2fTDTB5Xb1Z77Jn/g9Xj8ya5AJYoLpuU1JzMstQi fbsEroymjTfZC16zV/xo/MDUwHiArYuRk0NCwETi2rJ1LBC2mMSFe+uB4lwcQgJLGSUW7ZkC lhASeMYocWSxIYgtLGAvcfLARcYuRg4OEQEtibaFUhAlLhLf2w4wgdjMAhkSD39tZwWx2QQM JX6+eA0W5xWwk1i/Zg87SCuLgKrElPWiIGFRgQiJW6s+MkKUCEr8mHwPbCungKvEm7/r2SBG 2koseA9xJrOAvMTmNW+ZJzAKzELSMgtJ2SwkZQsYmVcxiqaWJhcUJ6XnGuoVJ+YWl+al6yXn 525ihATylx2Mi49ZHWIU4GBU4uGt2H0uXIg1say4MvcQowQHs5II71f2C+FCvCmJlVWpRfnx RaU5qcWHGKU5WJTEeefueh8iJJCeWJKanZpakFoEk2Xi4JRqYOzdKLs55UCw1AVOt8IPWs8S 05+sYvR7bHPbq+Bo7ErXF22RLzT4czyPv/2tUp248F9J9q6Puqkn2fPMk10MJ69iNjHqFfsc k6wr9eazgaoWw+Pve/ctDp3akvjoodhZRit57YizjJ/c13X0zWaJtSqtm5bKxvStKu+Rg8Kb ndu+ZVz6seh7ghJLcUaioRZzUXEiANqASJRgAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Vadim, On 09/07/2016 03:35 PM, vadimp@mellanox.com wrote: > From: Vadim Pasternak > > This makes it possible to create a set of LEDs for Mellanox systems: > "msx6710", "msx6720", "msb7700", "msn2700", "msx1410", "msn2410", > "msb7800", "msn2740", "msn2100". > > Driver obtains led devices according to system configuration, provided > through system DMI data, like fan1:green, fan1:red and creates devices in > form: "devicename:colour:function". > > led setting is controlled through on board CPLD Lattice device. > For setting particular led off, solid, > blink (blink requires ledtrig-timer module): > echo 0 > /sys/class/leds/status\:green/brightness > echo 1 > /sys/class/leds/status\:green/brightness > echo timer > /sys/class/leds/status\:green/trigger > Thanks for the update, will review it soon. One important detail - please update patch version each time you're sending a new one, like [PATCH v2]. -- Best regards, Jacek Anaszewski