From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756651AbcIMUmR (ORCPT ); Tue, 13 Sep 2016 16:42:17 -0400 Received: from mout.web.de ([212.227.17.12]:51619 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754804AbcIMUmP (ORCPT ); Tue, 13 Sep 2016 16:42:15 -0400 Subject: [PATCH 1/7] AGPGART: Use kmalloc_array() in compat_agpioc_reserve_wrap() To: kernel-janitors@vger.kernel.org, David Airlie References: <566ABCD9.1060404@users.sourceforge.net> <5204ca92-2cdf-8115-567c-4ac29816fcec@users.sourceforge.net> Cc: LKML , Julia Lawall From: SF Markus Elfring Message-ID: <7c2df723-e456-37d3-faf0-76514c672515@users.sourceforge.net> Date: Tue, 13 Sep 2016 22:42:09 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <5204ca92-2cdf-8115-567c-4ac29816fcec@users.sourceforge.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:78eCF3lOCRcWO5gU5RvMBAgRCNxjxbnP7JEAnJs4XYK59DyL/4K UF+Ks3m118J3lq2pj0FzuRozwV0FO+z6N9xBZS9x0xcAqfZEWp0uotJOFJ8NvgSg76rXdAf 1gZCOWMaA651BhNUskya2L8/gzFXIbYjFvR991LPFc9BNPgO+YqHBWH+3QpFDXYEuy8DoIh xCMwlQ6gKTWMWtow7Ttcw== X-UI-Out-Filterresults: notjunk:1;V01:K0:A5XH4K+CVSg=:R/TDMPEZshy0xcYCA9jurm BSRx75ICaMA9itZo7PUo73UEtcKXui0jN55ciRCdugcKBju4VbfOMlBPDsID/zgRDPWd24w0p fnY75KAnAB+WBTiXKgzJs7Ao270/g+mAylUZZIkQitWLze3dhmYpwL6GTw3dpA1ThJgTPi/64 q4uUsvEFyXtlxNj25zvJOxQ8oKCUfmr9U9ugUd3msUwApFwBzxX3H2U0B8CClcTKhcr+ADPs8 Y24U9Xb/87geV17FopELbL0HVUhcv7DYktIx7Z6/g2doA+c5vYkzYuqtVywq/efN432csEoeL Cxzxr8uJDfr8W+0j44y/tBiPwcNAdGGoLdX1xIYpNaXAwV2APZuRwQKXV8KZr9vib2TyTG9LB hxw0I4lul5YIjT8W5GXtMTgarFlcHeS/vfCzKCv7T/ZmnfdTjdErX2+0FRlEJLnw5zuDSD8x8 tHiOgvx8Rh3jLahFlfrRx4Rute9rBjZNCnWPpcdEXZGdG6zC0OeMS4prrMAn4vjgGRXmaX4jF P8Tl4OFx4kFEijyoykd9lgaVjF6prdSHeGd99QYD+0bhApI5s5ZLz0mdoaavNARaUhHa47H/2 NHZHaPCUnDR45A/ziGQhpOs/MVRAr33zvBK6U0iYDc1HJqUY0Zsx2FHuonrK+1rzS87HQ+zwg y8XQRgB88hcL4DJRZJa20AMsbiikpQdtBQU2nh6JgHrgGaEcfp6/SNx2ehMDOqet7vFaBBqMR oXcecsdmI9g6T1wGbF3vuT4C7PK/etRZCDSIG3qjDuRNg6OPkY7aVD70MMes9dxmVRGHt+/VK j4rjabU Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Tue, 13 Sep 2016 17:51:32 +0200 Multiplications for the size determination of memory allocations indicated that array data structures should be processed. Thus use the corresponding function "kmalloc_array". This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/char/agp/compat_ioctl.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/char/agp/compat_ioctl.c b/drivers/char/agp/compat_ioctl.c index a48e05b..a2b69db 100644 --- a/drivers/char/agp/compat_ioctl.c +++ b/drivers/char/agp/compat_ioctl.c @@ -98,11 +98,15 @@ static int compat_agpioc_reserve_wrap(struct agp_file_private *priv, void __user if (ureserve.seg_count >= 16384) return -EINVAL; - usegment = kmalloc(sizeof(*usegment) * ureserve.seg_count, GFP_KERNEL); + usegment = kmalloc_array(ureserve.seg_count, + sizeof(*usegment), + GFP_KERNEL); if (!usegment) return -ENOMEM; - ksegment = kmalloc(sizeof(*ksegment) * kreserve.seg_count, GFP_KERNEL); + ksegment = kmalloc_array(kreserve.seg_count, + sizeof(*ksegment), + GFP_KERNEL); if (!ksegment) { kfree(usegment); return -ENOMEM; -- 2.10.0