From: Paolo Bonzini <pbonzini@redhat.com>
To: Chenyi Qiang <chenyi.qiang@intel.com>,
Sean Christopherson <seanjc@google.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
Wanpeng Li <wanpengli@tencent.com>,
Jim Mattson <jmattson@google.com>, Joerg Roedel <joro@8bytes.org>,
Xiaoyao Li <xiaoyao.li@intel.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 0/3] Introduce Notify VM exit
Date: Mon, 23 May 2022 21:30:08 +0200 [thread overview]
Message-ID: <7c4ebffe-7b61-9ca8-26b6-1fbaaac5243e@redhat.com> (raw)
In-Reply-To: <20220421072958.16375-1-chenyi.qiang@intel.com>
On 4/21/22 09:29, Chenyi Qiang wrote:
> Virtual machines can exploit Intel ISA characterstics to cause
> functional denial of service to the VMM. This series introduces a new
> feature named Notify VM exit, which can help mitigate such kind of
> attacks.
>
> Patch 1: An extension of KVM_SET_VCPU_EVENTS ioctl to inject a
> synthesized shutdown event from user space. This is also a fix for other
> synthesized triple fault, e.g. the RSM patch or nested_vmx_abort(),
> which could get lost when exit to userspace to do migrate.
>
> Patch 2: A selftest about get/set triple fault event.
>
> Patch 3: The main patch to enable Notify VM exit.
Chenyi, can you send v7 for inclusion?
Paolo
> ---
> Change logs:
> v5 -> v6
> - Do some changes in document.
> - Add a selftest about get/set triple fault event. (Sean)
> - extend the argument to include both the notify window and some flags
> when enabling KVM_CAP_X86_BUS_LOCK_EXIT CAP. (Sean)
> - Change to use KVM_VCPUEVENT_VALID_TRIPE_FAULT in flags field and add
> pending_triple_fault field in struct kvm_vcpu_events, which allows
> userspace to make/clear triple fault request. (Sean)
> - Add a flag in kvm_x86_ops to avoid the kvm_has_notify_vmexit global
> varialbe and its export.(Sean)
> - v5: https://lore.kernel.org/lkml/20220318074955.22428-1-chenyi.qiang@intel.com/
>
> v4 -> v5
> - rename KVM_VCPUEVENTS_SHUTDOWN to KVM_VCPUEVENTS_TRIPLE_FAULT. Make it
> bidirection and add it to get_vcpu_events. (Sean)
> - v4: https://lore.kernel.org/all/20220310084001.10235-1-chenyi.qiang@intel.com/
>
> v3 -> v4
> - Change this feature to per-VM scope. (Jim)
> - Once VM_CONTEXT_INVALID set in exit_qualification, exit to user space
> notify this fatal case, especially the notify VM exit happens in L2.
> (Jim)
> - extend KVM_SET_VCPU_EVENTS to allow user space to inject a shutdown
> event. (Jim)
> - A minor code changes.
> - Add document for the new KVM capability.
> - v3: https://lore.kernel.org/lkml/20220223062412.22334-1-chenyi.qiang@intel.com/
>
> v2 -> v3
> - add a vcpu state notify_window_exits to record the number of
> occurence as well as a pr_warn output. (Sean)
> - Add the handling in nested VM to prevent L1 bypassing the restriction
> through launching a L2. (Sean)
> - Only kill L2 when L2 VM is context invalid, synthesize a
> EXIT_REASON_TRIPLE_FAULT to L1 (Sean)
> - To ease the current implementation, make module parameter
> notify_window read-only. (Sean)
> - Disable notify window exit by default.
> - v2: https://lore.kernel.org/lkml/20210525051204.1480610-1-tao3.xu@intel.com/
>
> v1 -> v2
> - Default set notify window to 0, less than 0 to disable.
> - Add more description in commit message.
> ---
>
> Chenyi Qiang (2):
> KVM: X86: Save&restore the triple fault request
> KVM: selftests: Add a test to get/set triple fault event
>
> Tao Xu (1):
> KVM: VMX: Enable Notify VM exit
>
> Documentation/virt/kvm/api.rst | 55 +++++++++++
> arch/x86/include/asm/kvm_host.h | 9 ++
> arch/x86/include/asm/vmx.h | 7 ++
> arch/x86/include/asm/vmxfeatures.h | 1 +
> arch/x86/include/uapi/asm/kvm.h | 4 +-
> arch/x86/include/uapi/asm/vmx.h | 4 +-
> arch/x86/kvm/vmx/capabilities.h | 6 ++
> arch/x86/kvm/vmx/nested.c | 8 ++
> arch/x86/kvm/vmx/vmx.c | 48 +++++++++-
> arch/x86/kvm/x86.c | 33 ++++++-
> arch/x86/kvm/x86.h | 5 +
> include/uapi/linux/kvm.h | 10 ++
> tools/testing/selftests/kvm/.gitignore | 1 +
> tools/testing/selftests/kvm/Makefile | 1 +
> .../kvm/x86_64/triple_fault_event_test.c | 96 +++++++++++++++++++
> 15 files changed, 280 insertions(+), 8 deletions(-)
> create mode 100644 tools/testing/selftests/kvm/x86_64/triple_fault_event_test.c
>
next prev parent reply other threads:[~2022-05-23 19:39 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-21 7:29 [PATCH v6 0/3] Introduce Notify VM exit Chenyi Qiang
2022-04-21 7:29 ` [PATCH v6 1/3] KVM: X86: Save&restore the triple fault request Chenyi Qiang
2022-05-18 18:42 ` Sean Christopherson
2022-05-19 6:25 ` Chenyi Qiang
2022-04-21 7:29 ` [PATCH v6 2/3] KVM: selftests: Add a test to get/set triple fault event Chenyi Qiang
2022-05-18 19:20 ` Sean Christopherson
2022-05-23 6:46 ` Chenyi Qiang
2022-05-23 16:23 ` Sean Christopherson
2022-05-24 13:27 ` Chenyi Qiang
2022-04-21 7:29 ` [PATCH v6 3/3] KVM: VMX: Enable Notify VM exit Chenyi Qiang
2022-05-17 0:59 ` Chenyi Qiang
2022-05-18 22:30 ` Sean Christopherson
2022-05-19 10:38 ` Chenyi Qiang
2022-05-19 15:22 ` Sean Christopherson
2022-05-06 2:43 ` [PATCH v6 0/3] Introduce " Chenyi Qiang
2022-05-23 19:30 ` Paolo Bonzini [this message]
2022-05-24 14:00 ` Chenyi Qiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7c4ebffe-7b61-9ca8-26b6-1fbaaac5243e@redhat.com \
--to=pbonzini@redhat.com \
--cc=chenyi.qiang@intel.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=seanjc@google.com \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
--cc=xiaoyao.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).