From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752945AbcHXF2x (ORCPT ); Wed, 24 Aug 2016 01:28:53 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:21854 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750947AbcHXF2v (ORCPT ); Wed, 24 Aug 2016 01:28:51 -0400 X-AuditID: cbfec7f4-f796c6d000001486-13-57bd308e4255 Subject: Re: [PATCH v2 1/4] ARM: dts: exynos: Enable HDMI for Arndale Octa board To: Milo Kim , Kukjin Kim , Krzysztof Kozlowski , David Airlie References: <1472005524-3489-1-git-send-email-woogyom.kim@gmail.com> <1472005524-3489-2-git-send-email-woogyom.kim@gmail.com> Cc: devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Seung-Woo Kim , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Kyungmin Park , Rob Herring , linux-arm-kernel@lists.infradead.org From: Andrzej Hajda Message-id: <7c58bbae-91ce-a6e7-14be-282b6fa40e42@samsung.com> Date: Wed, 24 Aug 2016 07:28:38 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-version: 1.0 In-reply-to: <1472005524-3489-2-git-send-email-woogyom.kim@gmail.com> Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrDLMWRmVeSWpSXmKPExsVy+t/xq7p9BnvDDTY/MbHoPXeSyWL+kXOs Fle+vmezeP3C0KL/8Wtmi7NNb9gtNj2+xmpxedccNosZ5/cxWbTuPcJuMWPySzaL25Onsznw eOycdZfdY9OqTjaP7d8esHrc7z7O5LF5Sb1H35ZVjB6fN8kFsEdx2aSk5mSWpRbp2yVwZczq 2M9e0CZQ0XLvKmMDYx9vFyMnh4SAicSq40cZIWwxiQv31rN1MXJxCAksZZRou/uZEcJ5ziix 7fwvZpAqYYEAiUOb14IlRASmMkrc7r3ACpIQEqiXOPVhOTtIgllgIZNE38YGFpAEm4CmxN/N N9lAbF4BO4lvp18DdXNwsAioSkzrsgcJiwpESNxa9ZERokRQ4sfke2CtnAKuEnP3PWYDKWcW UJeYMiUXJMwsIC+xec1b5gmMArOQdMxCqJqFpGoBI/MqRtHU0uSC4qT0XEO94sTc4tK8dL3k /NxNjJA4+bKDcfExq0OMAhyMSjy8HSF7woVYE8uKK3MPMUpwMCuJ8O5U2RsuxJuSWFmVWpQf X1Sak1p8iFGag0VJnHfurvchQgLpiSWp2ampBalFMFkmDk6pBsZi/c9p0dnf8+7fmfGNecNE S8azjDzNhRlL5RJO70ztTXfuOcmi0pXPejjv5Prtdh9M4x9o3++1KW1MdW3JTT0as3jd32PB lz1SdM5/fzt5jYZttsLMu7U7tV62fLWMWRme++95VWz/DFar8jyPoqlRKmsbiw9F77wlkrRA q6Bz7gz1i4eeFCuxFGckGmoxFxUnAgCAl4ZMjwIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Milo, On 08/24/2016 04:25 AM, Milo Kim wrote: > * Support HDMI display data channel > I2C #2 is assigned for the HDMI DDC. It enables the EDID access. > > * GPIO for HDMI hot plug detect > GPX3_7 is used. The HPD awareness is done when the GPIO is active high and > single ended. > > * Enable HDMI block in Exynos5420 > HDMI PLL consumes 1.0V LDO6 (PVDD_ANAIP_1V0) and HDMI oscillator requires > 1.8V LDO7 (PVDD_ANAIP_1V8). > > Cc: Kukjin Kim > Cc: Krzysztof Kozlowski > Cc: David Airlie > Cc: Inki Dae > Cc: Joonyoung Shim > Cc: Seung-Woo Kim > Cc: Kyungmin Park > Cc: Rob Herring > Cc: devicetree@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-samsung-soc@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Milo Kim > --- > arch/arm/boot/dts/exynos5420-arndale-octa.dts | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/arch/arm/boot/dts/exynos5420-arndale-octa.dts b/arch/arm/boot/dts/exynos5420-arndale-octa.dts > index 39a3b81..df362a2 100644 > --- a/arch/arm/boot/dts/exynos5420-arndale-octa.dts > +++ b/arch/arm/boot/dts/exynos5420-arndale-octa.dts > @@ -70,6 +70,23 @@ > status = "disabled"; > }; > > +&i2c_2 { > + samsung,i2c-slave-addr = <0x50>; > + status = "okay"; > + > + hdmiddc@50 { > + compatible = "samsung,exynos4210-hdmiddc"; > + reg = <0x50>; > + }; > +}; > + > +&hdmi { > + hpd-gpios = <&gpx3 7 GPIO_OPEN_SOURCE>; > + vdd_osc-supply = <&ldo7_reg>; > + vdd_pll-supply = <&ldo6_reg>; > + status = "okay"; Please use ddc property in hdmi node, instead of this legacy binding. See exynos4210-universal_c210.dts or exynos4412-odroid-common.dtsi for reference. Regards Andrzej > +}; > + > &hsi2c_4 { > status = "okay"; >