From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5292BC43460 for ; Wed, 28 Apr 2021 10:47:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2045460BD3 for ; Wed, 28 Apr 2021 10:47:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239548AbhD1KsU (ORCPT ); Wed, 28 Apr 2021 06:48:20 -0400 Received: from so254-9.mailgun.net ([198.61.254.9]:63987 "EHLO so254-9.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239536AbhD1KsR (ORCPT ); Wed, 28 Apr 2021 06:48:17 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1619606853; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=ZuI/K9+NXDRWXfsFMoJzLU4sqRFnGeuqVbmpRUnN4cQ=; b=dFcU5s80ms6SnbY70ulMr1CxaWsSYLvg2MWv0SxEP7egl1XRotSHBwYYcAOLycjK1R0q21SX i4QidXzjqYGLzyeu6VMdKdVmikio3Y/c1vUwmIs1KaBM4vt5s1gOfF8oa85o1ge1C16VESKd hyBkqdhDjrvOmjpEGn1fG0Augts= X-Mailgun-Sending-Ip: 198.61.254.9 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n02.prod.us-east-1.postgun.com with SMTP id 60893d3574f773a6645c15cb (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Wed, 28 Apr 2021 10:47:17 GMT Sender: sbhanu=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 9839CC433F1; Wed, 28 Apr 2021 10:47:16 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: sbhanu) by smtp.codeaurora.org (Postfix) with ESMTPSA id 84A91C433D3; Wed, 28 Apr 2021 10:47:15 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 28 Apr 2021 16:17:15 +0530 From: sbhanu@codeaurora.org To: Doug Anderson Cc: Veerabhadrarao Badiganti , Adrian Hunter , Ulf Hansson , Rob Herring , Asutosh Das , Sahitya Tummala , Ram Prakash Gupta , Sayali Lokhande , sartgarg@codeaurora.org, Rajendra Nayak , Sai Prakash Ranjan , Sibi Sankar , cang@codeaurora.org, pragalla@codeaurora.org, nitirawa@codeaurora.org, Linux MMC List , LKML , linux-arm-msm , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Andy Gross , Bjorn Andersson , Evan Green , Georgi Djakov , Odelu Kukatla Subject: Re: [PATCH V2] arm64: dts: qcom: sc7280: Add nodes for eMMC and SD card In-Reply-To: References: <1616264220-25825-1-git-send-email-sbhanu@codeaurora.org> <6fdf704c4716f5873d413229ca8adc57@codeaurora.org> <8126e130e5c0ea1e7ea867414f0510c0@codeaurora.org> <32096a375966e1fcc149016df012c445@codeaurora.org> Message-ID: <7c6805abf9c1f590bc4d66d625152f22@codeaurora.org> X-Sender: sbhanu@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021-04-21 01:44, Doug Anderson wrote: > Hi, > > On Tue, Apr 20, 2021 at 10:21 AM wrote: >> >> On 2021-04-15 01:55, Doug Anderson wrote: >> > Hi, >> > >> > On Tue, Apr 13, 2021 at 3:59 AM wrote: >> >> >> >> >> >>> + required-opps = >> >> >> >>> <&rpmhpd_opp_low_svs>; >> >> >> >>> + opp-peak-kBps = <1200000 >> >> >> >>> 76000>; >> >> >> >>> + opp-avg-kBps = <1200000 >> >> >> >>> 50000>; >> >> >> >> Why are the kBps numbers so vastly different than the ones on sc7180 >> >> >> >> for the same OPP point. That implies: >> >> >> >> >> >> >> >> a) sc7180 is wrong. >> >> >> >> >> >> >> >> b) This patch is wrong. >> >> >> >> >> >> >> >> c) The numbers are essentially random and don't really matter. >> >> >> >> >> >> >> >> Can you identify which of a), b), or c) is correct, or propose an >> >> >> >> alternate explanation of the difference? >> >> >> >> >> >> >> >> >> >> We calculated bus votes values for both sc7180 and sc7280 with ICB >> >> >> tool, >> >> >> above mentioned values we got for sc7280. >> >> > >> >> > I don't know what an ICB tool is. Please clarify. >> >> > >> >> > Also: just because a tool spits out numbers that doesn't mean it's >> >> > correct. Presumably the tool could be wrong or incorrectly configured. >> >> > We need to understand why these numbers are different. >> >> > >> >> we checked with ICB tool team on this they conformed as Rennell & >> >> Kodiak >> >> are different chipsets, >> >> we might see delta in ib/ab values due to delta in scaling factors. >> > >> > ...but these numbers are in kbps, aren't they? As I understand it >> > these aren't supposed to be random numbers spit out by a tool but are >> > supposed to be understandable by how much bandwidth an IP block (like >> > MMC) needs from the busses it's connected to. Since the MMC IP block >> > on sc7180 and sc7280 is roughly the same there shouldn't be a big >> > difference in numbers. >> > >> > Something smells wrong. >> > >> > Adding a few people who understand interconnects better than I do, >> > though. >> > >> >> ICB team has re-checked the Rennell ICB tool and they confirmed that >> some configs were wrong in Rennell ICB tool and they corrected it.With >> the new updated Rennell ICB tool below are the values : >> >> >> Rennell LC:(Sc7180) >> >> opp-384000000 { >> opp-hz = /bits/ 64 <384000000>; >> required-opps = <&rpmhpd_opp_nom>; >> opp-peak-kBps = <5400000 490000>; >> opp-avg-kBps = <6600000 300000>; >> }; >> >> >> And now, these values are near to Kodaik LC values: >> >> Kodaik LC:(SC7280) >> >> opp-384000000 { >> opp-hz = /bits/ 64 <384000000>; >> required-opps = <&rpmhpd_opp_nom>; >> opp-peak-kBps = <5400000 399000>; >> opp-avg-kBps = <6000000 300000>; >> }; > > This still isn't making sense to me. > > * sc7180 and sc7280 are running at the same speed. I'm glad the > numbers are closer now, but I would have thought they'd be exactly the > same. > > * Aren't these supposed to be sensible? This is eMMC that does max > transfer rates of 400 megabytes / second to the external device. You > have bandwidths listed here of 5,400,000 kBps = 5,400,000 kilobytes / > second = 5400 megabytes / second. I can imagine there being some > overhead where an internal bus might need to be faster but that seems > excessive. This is 13.5x! > These numbers are not related to SDCC bandwidth, these are the values needed for the NOC's to run in nominal voltage corners (internal to hardware) and thus it helps SDCC to run in nominal to get required through put (384MBps).So above calculation mentioned by you is not applicable here. > * I can't see how it can make sense that "average" values are higher > than "peak" values. Here actual peak = peak number * 2 actual average = average number and this multiplication is taken care by ICC driver, so technically actual peak is still high than average. > > It still feels like there's a misconfiguration somewhere. > > -Doug