From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F7A7C31E44 for ; Mon, 17 Jun 2019 04:30:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D9BEF2054F for ; Mon, 17 Jun 2019 04:30:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="O+3RFtA3" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726017AbfFQEas (ORCPT ); Mon, 17 Jun 2019 00:30:48 -0400 Received: from lelv0143.ext.ti.com ([198.47.23.248]:55028 "EHLO lelv0143.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725730AbfFQEar (ORCPT ); Mon, 17 Jun 2019 00:30:47 -0400 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id x5H4U4rh055473; Sun, 16 Jun 2019 23:30:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1560745804; bh=ESKXVh9Sq512lPIqthTXEUClTEi6OelQzFKQgNFQ7wM=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=O+3RFtA3fdfmaj1j/OEZXoOysP1/tfUlSMyvZiC8PYnbYhSaaPvf++0OJeSmhd+uA FkMWyld0BDwQiHM1SjnHuwUiSV+LHs5tgvIbPZgqMbLIyHSavD+G8oXUxetR+Gj8dY GFqQuKTY1NyJxqD4amy7labW3TVRrE+zNWnedBio= Received: from DLEE105.ent.ti.com (dlee105.ent.ti.com [157.170.170.35]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x5H4U4E4103253 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Sun, 16 Jun 2019 23:30:04 -0500 Received: from DLEE101.ent.ti.com (157.170.170.31) by DLEE105.ent.ti.com (157.170.170.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Sun, 16 Jun 2019 23:30:03 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DLEE101.ent.ti.com (157.170.170.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5 via Frontend Transport; Sun, 16 Jun 2019 23:30:03 -0500 Received: from [172.24.190.89] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id x5H4TvCq010286; Sun, 16 Jun 2019 23:29:58 -0500 Subject: Re: [PATCH v5 4/5] dt-bindings: mtd: Add bindings for TI's AM654 HyperBus memory controller To: Sergei Shtylyov , David Woodhouse , Brian Norris , Boris Brezillon , Marek Vasut , Richard Weinberger , Rob Herring CC: , Tudor Ambarus , Miquel Raynal , Joakim Tjernlund , , Mason Yang , , References: <20190609103227.24875-1-vigneshr@ti.com> <20190609103227.24875-5-vigneshr@ti.com> From: Vignesh Raghavendra Message-ID: <7c7828b9-bcfd-6156-3ddb-cbdde5956675@ti.com> Date: Mon, 17 Jun 2019 10:00:45 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 10/06/19 9:55 PM, Sergei Shtylyov wrote: > Hello! > > On 06/09/2019 01:32 PM, Vignesh Raghavendra wrote: > >> Add binding documentation for TI's HyperBus memory controller present on >> AM654 SoC. >> >> Signed-off-by: Vignesh Raghavendra >> --- >> v5: >> Update binding example to show MMIO mux >> Fix reg property for flash slave. >> >> .../devicetree/bindings/mtd/ti,am654-hbmc.txt | 51 +++++++++++++++++++ >> MAINTAINERS | 1 + >> 2 files changed, 52 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/mtd/ti,am654-hbmc.txt >> >> diff --git a/Documentation/devicetree/bindings/mtd/ti,am654-hbmc.txt b/Documentation/devicetree/bindings/mtd/ti,am654-hbmc.txt >> new file mode 100644 >> index 000000000000..c2a2c2b42a92 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/mtd/ti,am654-hbmc.txt >> @@ -0,0 +1,51 @@ >> +Bindings for HyperBus Memory Controller (HBMC) on TI's K3 family of SoCs >> + >> +Required properties: >> +- compatible : "ti,am654-hbmc" for AM654 SoC >> +- reg : Two entries: >> + First entry pointed to the register space of HBMC controller >> + Second entry pointing to the memory map region dedicated for >> + MMIO access to attached flash devices >> +- ranges : Address translation from offset within CS to allocated MMIO >> + space in SoC >> + >> +Optional properties: >> +- mux-controls : phandle to the multiplexer that controls selection of >> + HBMC vs OSPI inside Flash SubSystem. Default is OSPI, >> + if property is absent. >> + See Documentation/devicetree/bindings/mux/reg-mux.txt >> + for mmio-mux binding details >> + >> +Example: >> + >> + fss: fss@47000000 { > > What's FSS? Flash SubSystem (FSS). Will highlight that in mux control definition above > Regardless of the answer, the node names should be generic, like "memory-controller@". > >> + compatible = "syscon", "simple-mfd"; > > If it's "sycon", the nme should probably be "system-controller". FSS is like a subchip that has all Flash controllers like Octal SPI controllers and HyperBus controller within it. Some of their controls are in the below address range. So I think its more closer to "system-controller" > >> + reg = <0x0 0x47000000 0x0 0x100>; >> + #address-cells = <2>; >> + #size-cells = <2>; >> + ranges; >> + >> + hbmc_mux: hbmc-mux { > > So, just "multiplexor"? Ok > >> + compatible = "mmio-mux"; >> + #mux-control-cells = <1>; >> + mux-reg-masks = <0x4 0x2>; /* 0: reg 0x4, bit 1 */ >> + }; >> + >> + hbmc: hbmc@47034000 { > > Should be named "memory-controller@47034000", according to the DT spec. IMO, since HyperBus is a bus protocol and has a specification, I think its should have a separate generic name like SPI etc. I will change this to "hyperbus@47034000" to common name of spec. > >> + compatible = "ti,am654-hbmc"; >> + reg = <0x0 0x47034000 0x0 0x100>, >> + <0x5 0x00000000 0x1 0x0000000>; >> + power-domains = <&k3_pds 55>; >> + #address-cells = <2>; >> + #size-cells = <1>; >> + ranges = <0x0 0x0 0x5 0x00000000 0x4000000>, /* CS0 - 64MB */ >> + <0x1 0x0 0x5 0x04000000 0x4000000>; /* CS1 - 64MB */ >> + mux-controls = <&hbmc_mux 0>; >> + >> + /* Slave flash node */ >> + flash@0,0 { >> + compatible = "cypress,hyperflash", "cfi-flash"; >> + reg = <0x0 0x0 0x4000000>; >> + }; >> + }; >> + }; > [...] > > MBR, Sergei > -- Regards Vignesh