linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Tiezhu Yang" <kernelpatch@126.com>
To: "Borislav Petkov" <bp@alien8.de>
Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
	x86@kernel.org, linux-kernel@vger.kernel.org, vgoyal@redhat.com
Subject: Re:Re: [PATCH] kexec: fix warnig of crash_zero_bytes in crash.c
Date: Fri, 21 Jun 2019 21:38:44 +0800 (CST)	[thread overview]
Message-ID: <7c86df5d.8b94.16b7a42c5be.Coremail.kernelpatch@126.com> (raw)
In-Reply-To: <20190620163900.GF28032@zn.tnic>

At 2019-06-21 00:39:00, "Borislav Petkov" <bp@alien8.de> wrote:
>On Sat, Jun 15, 2019 at 07:18:20AM +0800, Tiezhu Yang wrote:
>> This patch fixes the following sparse warning:
>
>Avoid having "This patch" or "This commit" in the commit message. It is
>tautologically useless.
>
>Also, do
>
>$ git grep 'This patch' Documentation/process
>
>for more details.
>
>> arch/x86/kernel/crash.c:59:15:
>> warning: symbol 'crash_zero_bytes' was not declared. Should it be static?
>> 
>> In addition, crash_zero_bytes is used when CONFIG_KEXEC_FILE is
>> set, so make it only available under CONFIG_KEXEC_FILE. Otherwise,
>> if CONFIG_KEXEC_FILE is not set, the following warning will appear:
>> 
>> arch/x86/kernel/crash.c:59:22:
>> warning: ‘crash_zero_bytes’ defined but not used [-Wunused-variable]
>
>That happens only when you make it static, so please state that in the
>commit message.

Thanks for your suggestion, I will send a v2 patch.

Thanks,

>
>Thx.
>
>-- 
>Regards/Gruss,
>    Boris.
>
>Good mailing practices for 400: avoid top-posting and trim the reply.

      reply	other threads:[~2019-06-21 13:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-14 23:18 [PATCH] kexec: fix warnig of crash_zero_bytes in crash.c Tiezhu Yang
2019-06-20 16:39 ` Borislav Petkov
2019-06-21 13:38   ` Tiezhu Yang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7c86df5d.8b94.16b7a42c5be.Coremail.kernelpatch@126.com \
    --to=kernelpatch@126.com \
    --cc=bp@alien8.de \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=vgoyal@redhat.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).