From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F293C25B07 for ; Fri, 5 Aug 2022 08:47:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237215AbiHEIrs (ORCPT ); Fri, 5 Aug 2022 04:47:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34544 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229899AbiHEIrp (ORCPT ); Fri, 5 Aug 2022 04:47:45 -0400 Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [IPv6:2a00:1450:4864:20::129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C5EF02AC78 for ; Fri, 5 Aug 2022 01:47:44 -0700 (PDT) Received: by mail-lf1-x129.google.com with SMTP id c17so2513202lfb.3 for ; Fri, 05 Aug 2022 01:47:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=cPhjnPAp997nXnbGBw6oxpbmrga8vTkPOOZqxdvdOc8=; b=Raai421gR0O4saWxOe/hXvr8OAj5W7eRABIdcMbIWZe0qLtZnpnqOydkGuDpSyXQW2 2WoYdHu9flurOu1S411FSuQuUH6rMs37rn2gqNOXO50/yJHkbfJ9N2WxqpkC3eT/gyJd Ln6Fx1bUI+0vu5I0gTLGijS3eY8VHBqCKT6TD3UVxQ8heADLtNGiBZLynk485JjPFbyw 3pTrOZ6wzwyVSWPo80gysf5JsTlmwXHHrAwTnDdC1ZOox4lA1UXlykrtarORPC5qnHyh DQwqwC79E/RE21N/C3gRJJT56r5BEzdzh5pJYWzZuFaE/N9jaHm0OTPT0kpSC7F2IKVl QMZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=cPhjnPAp997nXnbGBw6oxpbmrga8vTkPOOZqxdvdOc8=; b=30OnfBNsN0QPoOXulzbpG3xaQkFlD+XG5PLeQlBw8zjhomB88d+Rt5oqbl5ESakhvT Igf2Budk3xCXeAX9Vvi3g23ZWAOM3+2aPUhk9icD8Za/EDpodrXvaZ1efn1faXVhJ0eo ifArWHlgLRMP5RvFk05PDr0ldavAZjfcoOQ2bsirZpaqsAYRM6CZiRk+QfatGW1pfrny aHPIUrQEqM30VIdgsmagdPzgQ0qXKMvwiBzpwMqMzqI0ddwFOMYCAKOPSomtvb+vYDKI oZ28L1EAkoFNO3JDyjMFYOiJXVosA/7mjl6lEHQ/ch9Pf5gZXaftP0OuVISezQ32NYj7 JJdA== X-Gm-Message-State: ACgBeo0fsemI3Kkm6ksWOr6sOU0ei8KWnhHt3tgKvvzXiENWecZ0JaZZ nShrTW1/ZsmbKafUnTx36tII7Q== X-Google-Smtp-Source: AA6agR6qAtlU5Afpao5FBvkPRc9T+X/qjalJPoTo/YdLTpFSaF3HxsYAjSOiL6PkxBP40e4gKGzPNg== X-Received: by 2002:a05:6512:12c7:b0:48b:37af:15d3 with SMTP id p7-20020a05651212c700b0048b37af15d3mr2172359lfg.290.1659689263183; Fri, 05 Aug 2022 01:47:43 -0700 (PDT) Received: from [192.168.1.6] ([77.222.167.48]) by smtp.gmail.com with ESMTPSA id x6-20020a2e9c86000000b0025e59a76742sm400638lji.14.2022.08.05.01.47.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Aug 2022 01:47:41 -0700 (PDT) Message-ID: <7c9f0d96-2882-964a-cd1f-916ddb3f0410@linaro.org> Date: Fri, 5 Aug 2022 10:47:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH v3 2/4] spi: dt-binding: add coreqspi as a fallback for mpfs-qspi Content-Language: en-US To: Conor.Dooley@microchip.com, Nagasuresh.Relli@microchip.com, broonie@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org Cc: linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Valentina.FernandezAlanis@microchip.com References: <20220805053019.996484-1-nagasuresh.relli@microchip.com> <20220805053019.996484-3-nagasuresh.relli@microchip.com> <1e48a9bb-9e35-66e7-e8e7-ff5de9941fc7@microchip.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/08/2022 10:44, Conor.Dooley@microchip.com wrote: >> 1. It is redundant. I did not look too much at the driver, but none of >> the of_device_id entries have some driver data to differentiate, >> therefore - for the driver - the devices are identical. If they are >> identical and according to binding compatible, use less code and just >> one compatible. > > Right. Then the binding is correct and the driver should only bind > against "microchip,coreqspi-rtl-v2". Yes. Best regards, Krzysztof