* [PATCH] MIPS: ralink: fix incorrect assignment on ralink_soc
@ 2016-12-22 23:52 Colin King
2016-12-23 5:38 ` John Crispin
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2016-12-22 23:52 UTC (permalink / raw)
To: John Crispin, Ralf Baechle, linux-mips; +Cc: linux-kernel
From: Colin Ian King <colin.king@canonical.com>
ralink_soc sould be assigned to RT3883_SOC, replace incorrect
comparision with assignment.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
arch/mips/ralink/rt3883.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/mips/ralink/rt3883.c b/arch/mips/ralink/rt3883.c
index 141c597..f869052 100644
--- a/arch/mips/ralink/rt3883.c
+++ b/arch/mips/ralink/rt3883.c
@@ -157,5 +157,5 @@ void prom_soc_init(struct ralink_soc_info *soc_info)
rt2880_pinmux_data = rt3883_pinmux_data;
- ralink_soc == RT3883_SOC;
+ ralink_soc = RT3883_SOC;
}
--
2.10.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] MIPS: ralink: fix incorrect assignment on ralink_soc
2016-12-22 23:52 [PATCH] MIPS: ralink: fix incorrect assignment on ralink_soc Colin King
@ 2016-12-23 5:38 ` John Crispin
0 siblings, 0 replies; 2+ messages in thread
From: John Crispin @ 2016-12-23 5:38 UTC (permalink / raw)
To: Colin King, Ralf Baechle, linux-mips; +Cc: linux-kernel
On 23/12/2016 00:52, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> ralink_soc sould be assigned to RT3883_SOC, replace incorrect
> comparision with assignment.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: John Crispin <john@phrozen.org>
i thought i had sent this fix upstream ages ago. luckily this bug never
caused any error as none of the code checking ralink_soc checks for
rt3883. its used for the rt3x5x family.
John
> ---
> arch/mips/ralink/rt3883.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/ralink/rt3883.c b/arch/mips/ralink/rt3883.c
> index 141c597..f869052 100644
> --- a/arch/mips/ralink/rt3883.c
> +++ b/arch/mips/ralink/rt3883.c
> @@ -157,5 +157,5 @@ void prom_soc_init(struct ralink_soc_info *soc_info)
>
> rt2880_pinmux_data = rt3883_pinmux_data;
>
> - ralink_soc == RT3883_SOC;
> + ralink_soc = RT3883_SOC;
> }
>
his
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-12-23 5:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-22 23:52 [PATCH] MIPS: ralink: fix incorrect assignment on ralink_soc Colin King
2016-12-23 5:38 ` John Crispin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).