From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Mark Brown <broonie@kernel.org>, John Stultz <john.stultz@linaro.org>
Cc: Takashi Iwai <tiwai@suse.de>, Liam Girdwood <lgirdwood@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Bard Liao <yung-chuan.liao@linux.intel.com>,
Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>,
Srini Kandagatla <srinivas.kandagatla@linaro.org>,
Vinod Koul <vinod.koul@linaro.org>,
Amit Pundir <amit.pundir@linaro.org>
Subject: Re: [GIT PULL] sound fixes for 5.8-rc1
Date: Fri, 12 Jun 2020 08:54:11 -0500 [thread overview]
Message-ID: <7cd79261-6f8d-cad0-c65b-57570a40a6b6@linux.intel.com> (raw)
In-Reply-To: <20200612121946.GE5396@sirena.org.uk>
On 6/12/20 7:19 AM, Mark Brown wrote:
> On Thu, Jun 11, 2020 at 05:49:29PM -0700, John Stultz wrote:
>> On Thu, Jun 11, 2020 at 5:13 PM John Stultz <john.stultz@linaro.org> wrote:
>
>>> I've bisected it down to the following commit from this pull req:
>>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=b73287f0b0745961b14e5ebcce92cc8ed24d4d52
>
> For the benefit of readers that's "ASoC: soc-pcm: dpcm: fix
> playback/capture checks".
>
>> I don't know the backgroun again, but would something like the
>> following make sense?
>> https://git.linaro.org/people/john.stultz/android-dev.git/commit/?h=dev/db845c-mainline-WIP&id=7e49b248db77b5ed29b2aa278268e77650c75482
>
> That's a small out of tree test patch which has no changelog so I'm not
> entirely clear what the intent or motivation is but it looks like the
> goal is to change so that we only warn when a link says it supports
> playback/capture but some of the DAIs lack the capability instead of
> returning an error. I'm not sure I understand how that helps, it seems
> like the link is still misconfigured and we still have a warning which
> isn't great? Surely the issue is that we've flagged the link as
> supporting capture when it doesn't?
Indeed the addition of stricter checks will expose cases where the links
are not well configured, probably for years. The patch "ASoC: soc-pcm:
dpcm: fix playback/capture checks" did not add those checks, only fixed
them for the multi-dai case.
I think that those configuration errors are the problem and should be
fixed as a prerequisite to the removal of the duplication between
dpcm_playback/dpcm_capture/playback_only/capture_only. it may be painful
and generate noise for a while, but if we only throw a warning what are
the odds all those configuration errors will eventually be fixed?
If we need more time for validation on all platforms, then maybe we can
first relax the check for 5.8-rc1 as suggested by John, but re-add the
-EINVAL on -next to give a target of 5.9 with all configurations fixed?
next prev parent reply other threads:[~2020-06-12 13:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-11 11:33 [GIT PULL] sound fixes for 5.8-rc1 Takashi Iwai
2020-06-11 19:50 ` pr-tracker-bot
2020-06-12 0:13 ` John Stultz
2020-06-12 0:49 ` John Stultz
2020-06-12 11:41 ` Srinivas Kandagatla
2020-06-12 12:35 ` Mark Brown
2020-06-12 23:59 ` John Stultz
2020-06-12 12:19 ` Mark Brown
2020-06-12 13:54 ` Pierre-Louis Bossart [this message]
2020-06-12 14:46 ` Mark Brown
2020-06-12 14:56 ` Pierre-Louis Bossart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7cd79261-6f8d-cad0-c65b-57570a40a6b6@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=amit.pundir@linaro.org \
--cc=broonie@kernel.org \
--cc=guennadi.liakhovetski@linux.intel.com \
--cc=john.stultz@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.de \
--cc=vinod.koul@linaro.org \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).