From: Abhishek Sahu <abhsahu@nvidia.com>
To: Logan Gunthorpe <logang@deltatee.com>,
Andrew Morton <akpm@linux-foundation.org>,
Dan Williams <dan.j.williams@intel.com>,
"Ingo Molnar" <mingo@redhat.com>, <x86@kernel.org>,
Ingo Molnar <mingo@redhat.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Borislav Petkov <bp@alien8.de>, "H . Peter Anvin" <hpa@zytor.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86/mm: fix compilation error for unknown type name pgprot_t
Date: Mon, 27 Apr 2020 20:41:53 +0530 [thread overview]
Message-ID: <7cdc44e5-4de4-7dea-13c1-536708f12fa2@nvidia.com> (raw)
In-Reply-To: <24e4100d-f59b-daa6-801b-28c9d062f262@nvidia.com>
On 4/21/2020 11:18 AM, Abhishek Sahu wrote:
> On 4/20/2020 10:14 PM, Logan Gunthorpe wrote:
>> On 2020-04-20 2:22 a.m., Abhishek Sahu wrote:
>>> commit 30796e18c299 ("x86/mm: introduce __set_memory_prot()")
>>> added the function __set_memory_prot() which uses pgprot_t in
>>> function prototype. The currently included header files in
>>> <arch/x86/include/asm/set_memory.h> do not include type name
>>> pgprot_t. The pgprot_t is defined in <asm/pgtable_types.h>.
>>>
>>> Fixes: 30796e18c299 ("x86/mm: introduce __set_memory_prot()")
>>> Signed-off-by: Abhishek Sahu <abhsahu@nvidia.com>
>>
>> I assume this is only hit with a specific driver or something that
>> includes set_memory.h without including pgtable_types.h before hand.
>>
>> It certainly compiles fine for me and the kbuild robot has had lots of
>> time to test it with random configs.
>>
>> Reviewed-by: Logan Gunthorpe <logang@deltatee.com>
>
> Thanks Logan.
>
> Yes. The mainline is compiling fine with default config.
> This problem is coming while compiling Out of tree NVIDIA driver.
> But this problem can happen for the drivers which don't include
> <pgtable_types.h>. I am not sure if this problem will come with
> some other configs. Normally, the header files should not be
> dependent upon the callers.
>
Is it possible to get this patch merged for next rc of 5.7.
This issue started coming from 5.7-rc1.
Thanks,
Abhishek
next prev parent reply other threads:[~2020-04-27 15:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-20 8:22 [PATCH] x86/mm: fix compilation error for unknown type name pgprot_t Abhishek Sahu
2020-04-20 16:44 ` Logan Gunthorpe
2020-04-21 5:48 ` Abhishek Sahu
2020-04-27 15:11 ` Abhishek Sahu [this message]
2020-05-13 7:28 ` Abhishek Sahu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7cdc44e5-4de4-7dea-13c1-536708f12fa2@nvidia.com \
--to=abhsahu@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=dan.j.williams@intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=logang@deltatee.com \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).