From: Alexandre Bailon <abailon@baylibre.com>
To: Daniel Lezcano <daniel.lezcano@linaro.org>,
rui.zhang@intel.com, amitk@kernel.org
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
ben.tseng@mediatek.com, khilman@baylibre.com, mka@chromium.org
Subject: Re: [PATCH v2 0/2] Add a generic virtual thermal sensor
Date: Fri, 17 Sep 2021 15:33:34 +0200 [thread overview]
Message-ID: <7cddcdb7-4efd-bfdb-3d86-f5862ea0b7fe@baylibre.com> (raw)
In-Reply-To: <bd347d14-0b42-f9ed-bf15-080c929e1cb7@linaro.org>
Hi Daniel,
On 9/17/21 2:41 PM, Daniel Lezcano wrote:
> On 17/09/2021 09:27, Alexandre Bailon wrote:
>> This series add a virtual thermal sensor.
>> It could be used to get a temperature using some thermal sensors.
>> Currently, the supported operations are max, min and avg.
>> The virtual sensor could be easily extended to support others operations.
>>
>> Note:
>> Currently, thermal drivers must explicitly register their sensors to make them
>> available to the virtual sensor.
>> This doesn't seem a good solution to me and I think it would be preferable to
>> update the framework to register the list of each available sensors.
> Why must the drivers do that ?
Because there are no central place where thermal sensor are registered.
The only other way I found was to update thermal_of.c,
to register the thermal sensors and make them available later to the
virtual thermal sensor.
To work, the virtual thermal need to get the sensor_data the ops from
the thermal sensor.
And as far I know, this is only registered in thermal_of.c, in the
thermal zone data
but I can't access it directly from the virtual thermal sensor.
How would you do it ?
Thanks,
Alexandre
>
>> Changes in v2:
>> - Fix some warnings / errors reported by kernel test robot
>> - rename some struct and functions with a more accurate name
>> - update the dt bindings: rename type attribute to aggregation-function
>> - factorize a little bit the aggregation functions
>>
>> Alexandre Bailon (2):
>> dt-bindings: Add bindings for the virtual thermal sensor
>> thermal: add a virtual sensor to aggregate temperatures
>>
>> .../thermal/virtual,thermal-sensor.yaml | 67 +++
>> drivers/thermal/Kconfig | 8 +
>> drivers/thermal/Makefile | 1 +
>> drivers/thermal/virtual-sensor.h | 51 +++
>> drivers/thermal/virtual_sensor.c | 400 ++++++++++++++++++
>> include/dt-bindings/thermal/virtual-sensor.h | 15 +
>> 6 files changed, 542 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/thermal/virtual,thermal-sensor.yaml
>> create mode 100644 drivers/thermal/virtual-sensor.h
>> create mode 100644 drivers/thermal/virtual_sensor.c
>> create mode 100644 include/dt-bindings/thermal/virtual-sensor.h
>>
>
next prev parent reply other threads:[~2021-09-17 13:31 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-17 7:27 [PATCH v2 0/2] Add a generic virtual thermal sensor Alexandre Bailon
2021-09-17 7:27 ` [PATCH v2 1/2] dt-bindings: Add bindings for the " Alexandre Bailon
2021-09-17 7:27 ` [PATCH v2 2/2] thermal: add a virtual sensor to aggregate temperatures Alexandre Bailon
2021-10-07 16:38 ` Rafael J. Wysocki
2021-10-07 17:33 ` Rafael J. Wysocki
2021-10-09 14:46 ` Rafael J. Wysocki
2021-10-25 9:18 ` Alexandre Bailon
2021-09-17 12:41 ` [PATCH v2 0/2] Add a generic virtual thermal sensor Daniel Lezcano
2021-09-17 13:33 ` Alexandre Bailon [this message]
2021-09-17 14:03 ` Daniel Lezcano
2021-09-20 13:12 ` Alexandre Bailon
2021-09-22 8:10 ` Daniel Lezcano
2021-10-04 10:24 ` Alexandre Bailon
2021-10-04 13:42 ` Daniel Lezcano
2021-10-05 16:45 ` Rafael J. Wysocki
2021-10-06 16:06 ` Daniel Lezcano
2021-10-06 18:00 ` Rafael J. Wysocki
2021-10-06 19:51 ` Daniel Lezcano
2021-10-07 14:17 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7cddcdb7-4efd-bfdb-3d86-f5862ea0b7fe@baylibre.com \
--to=abailon@baylibre.com \
--cc=amitk@kernel.org \
--cc=ben.tseng@mediatek.com \
--cc=daniel.lezcano@linaro.org \
--cc=khilman@baylibre.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mka@chromium.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).