From: Eric Sandeen <sandeen@sandeen.net>
To: Fabian Frederick <fabf@skynet.be>,
Dave Chinner <david@fromorbit.com>,
Eric Sandeen <sandeen@redhat.com>
Cc: linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1 linux-next] xfs: remove unnecessary return
Date: Wed, 14 Dec 2016 22:17:02 -0600 [thread overview]
Message-ID: <7ce30624-de82-f682-776c-7b6f1757026d@sandeen.net> (raw)
In-Reply-To: <1481352729-7020-1-git-send-email-fabf@skynet.be>
On 12/10/16 12:52 AM, Fabian Frederick wrote:
> Commit f7a136aee3c1
> ("xfs: several xattr functions can be void")
>
> updated 2 end of function return 0 to return in void
> functions. Remove it.
>
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
Oh, sure. :)
Reviewed-by: Eric Sandeen <sandeen@sandeen.net>
> ---
> fs/xfs/xfs_attr_list.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/fs/xfs/xfs_attr_list.c b/fs/xfs/xfs_attr_list.c
> index 97c45b6..5aa46c3 100644
> --- a/fs/xfs/xfs_attr_list.c
> +++ b/fs/xfs/xfs_attr_list.c
> @@ -433,7 +433,6 @@ xfs_attr3_leaf_list_int(
> cursor->offset++;
> }
> trace_xfs_attr_list_leaf_end(context);
> - return;
> }
>
> /*
> @@ -543,7 +542,6 @@ xfs_attr_put_listent(
> alist->al_offset[context->count++] = context->firstu;
> alist->al_count = context->count;
> trace_xfs_attr_list_add(context);
> - return;
> }
>
> /*
>
next prev parent reply other threads:[~2016-12-15 4:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-10 6:52 [PATCH 1/1 linux-next] xfs: remove unnecessary return Fabian Frederick
2016-12-15 4:17 ` Eric Sandeen [this message]
2016-12-15 17:53 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ce30624-de82-f682-776c-7b6f1757026d@sandeen.net \
--to=sandeen@sandeen.net \
--cc=david@fromorbit.com \
--cc=fabf@skynet.be \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).