From: Jacek Anaszewski <jacek.anaszewski@gmail.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: Gene Chen <gene.chen.richtek@gmail.com>,
robh+dt@kernel.org, Matthias Brugger <matthias.bgg@gmail.com>,
Dan Murphy <dmurphy@ti.com>,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
Gene Chen <gene_chen@richtek.com>,
Wilma.Wu@mediatek.com, shufan_lee@richtek.com,
cy_huang@richtek.com, benjamin.chao@mediatek.com
Subject: Re: [PATCH v3 1/2] leds: mt6360: Add LED driver for MT6360
Date: Thu, 10 Sep 2020 22:31:28 +0200 [thread overview]
Message-ID: <7ce924da-5119-0406-7995-560c32097040@gmail.com> (raw)
In-Reply-To: <20200910202510.GB18431@ucw.cz>
On 9/10/20 10:25 PM, Pavel Machek wrote:
> Hi!
>
>>>> 1. set FLED1 brightness
>>>> # echo 1 > /sys/class/leds/white:flash1/flash_brightness
>>>> 2. enable FLED1 strobe
>>>> # echo 1 > /sys/class/leds/white:flash1/flash_strobe
>>>> 3 . turn off FLED1 strobe (just used to gaurantee the strobe mode
>>>> flash leds must be turned off)
>>>> # echo 0 > /sys/class/leds/white:flash1/flash_strobe
>>>
>>> I believe I'd preffer only exposing torch functionality in
>>> /sys/class/leds. .. strobe can be supported using v4l2 APIs.
>>
>> Actually having LED flash class without strobe is pointless.
>> If you looked at led_classdev_flash_register_ext() you would see that
>> it fails with uninitialized strobe_set op. And V4L2 API for strobing
>> flash calls strobe_set from LED flash class beneath.
>>
>> That was the idea behind LED and V4L2 flash API unification - there
>> is one hardware driver needed, the V4L2 Flash layer just takes over
>> control over it when needed.
>
> I agree that one driver is enough.
>
> But we should not need flash_strobe file in sysfs. Simply use V4L2 for
> that.
Apart from the fact that we can't remove it from LED flash class ABI
now, why would you like to prevent the user from exploiting main feature
of the hardware?
--
Best regards,
Jacek Anaszewski
next prev parent reply other threads:[~2020-09-10 20:37 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-07 10:27 [PATCH v3 0/2] leds: mt6360: Add LED driver for MT6360 Gene Chen
2020-09-07 10:27 ` [PATCH v3 1/2] " Gene Chen
2020-09-08 14:13 ` Dan Murphy
2020-09-08 22:25 ` Pavel Machek
2020-09-09 23:49 ` Gene Chen
2020-09-10 12:29 ` Pavel Machek
2020-09-10 20:23 ` Jacek Anaszewski
2020-09-10 20:25 ` Pavel Machek
2020-09-10 20:31 ` Jacek Anaszewski [this message]
2020-09-09 13:48 ` Andy Shevchenko
2020-09-10 0:11 ` Gene Chen
2020-09-10 8:18 ` Pavel Machek
2020-09-10 11:34 ` Andy Shevchenko
2020-09-10 12:28 ` Pavel Machek
2020-09-10 11:46 ` Andy Shevchenko
2020-09-10 21:42 ` Jacek Anaszewski
2020-09-11 7:05 ` Pavel Machek
2020-09-10 23:24 ` Gene Chen
2020-09-11 21:21 ` Jacek Anaszewski
2020-09-11 20:56 ` Jacek Anaszewski
2020-09-07 10:27 ` [PATCH v3 2/2] dt-bindings: leds: Add bindings for MT6360 LED Gene Chen
2020-09-08 13:55 ` Dan Murphy
2020-09-08 22:22 ` Pavel Machek
2020-09-15 15:51 ` Rob Herring
2020-09-08 14:14 ` [PATCH v3 0/2] leds: mt6360: Add LED driver for MT6360 Dan Murphy
2020-09-09 0:00 ` Gene Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ce924da-5119-0406-7995-560c32097040@gmail.com \
--to=jacek.anaszewski@gmail.com \
--cc=Wilma.Wu@mediatek.com \
--cc=benjamin.chao@mediatek.com \
--cc=cy_huang@richtek.com \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=gene.chen.richtek@gmail.com \
--cc=gene_chen@richtek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=shufan_lee@richtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).