From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: Robert Nelson <robertcnelson@gmail.com>,
alexey.roslyakov@gmail.com, Drew Fustini <drew@beagleboard.org>,
Jason Kridner <jkridner@beagleboard.org>
Cc: "Benoît Cousson" <bcousson@baylibre.com>,
"Tony Lindgren" <tony@atomide.com>,
"Rob Herring" <robh+dt@kernel.org>,
linux-omap <linux-omap@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
"linux kernel" <linux-kernel@vger.kernel.org>,
linux-wireless@vger.kernel.org,
brcm80211-dev-list.pdl@broadcom.com
Subject: Re: [PATCH] ARM: dts: am5729-beagleboneai: drop unused Broadcom WiFi properties
Date: Wed, 5 May 2021 10:22:37 -0400 [thread overview]
Message-ID: <7ced6d2f-7107-e612-6787-63e38e5e3edd@canonical.com> (raw)
In-Reply-To: <CAOCHtYiicw5bqaZU5g2QGJHG3DZKRQUwAr08NZHw81S9=hmrgw@mail.gmail.com>
On 05/05/2021 10:15, Robert Nelson wrote:
> On Wed, May 5, 2021 at 9:04 AM Krzysztof Kozlowski
> <krzysztof.kozlowski@canonical.com> wrote:
>>
>> The brcm,sd-head-align, brcm,sd_head_align and brcm,sd_sgentry_align are
>> not used by the driver and not present in dtschema:
>>
>> arch/arm/boot/dts/am5729-beagleboneai.dt.yaml: wifi@1:
>> 'brcm,sd-head-align', 'brcm,sd_head_align', 'brcm,sd_sgentry_align' do not match any of the regexes: 'pinctrl-[0-9]+'
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
>> ---
>> arch/arm/boot/dts/am5729-beagleboneai.dts | 4 ----
>> 1 file changed, 4 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/am5729-beagleboneai.dts b/arch/arm/boot/dts/am5729-beagleboneai.dts
>> index 149cfafb90bf..d3b2e87a6266 100644
>> --- a/arch/arm/boot/dts/am5729-beagleboneai.dts
>> +++ b/arch/arm/boot/dts/am5729-beagleboneai.dts
>> @@ -582,10 +582,6 @@ brcmf: wifi@1 {
>> reg = <1>;
>> compatible = "brcm,bcm4329-fmac";
>>
>> - brcm,sd-head-align = <4>;
>> - brcm,sd_head_align = <4>;
>> - brcm,sd_sgentry_align = <512>;
>> -
>> interrupt-parent = <&gpio3>;
>> interrupts = <23 IRQ_TYPE_LEVEL_LOW>;
>> interrupt-names = "host-wake";
>> --
>> 2.25.1
>>
>
> NAK, for what it is worth..
>
> This is a plain old shitty situation, that everyone that mistakenly
> chooses a BRCM based chipset in a design faces, then learns to NEVER
> touch that chipset again..
>
> These nodes have been posted before for mainline inclusion but always
> get killed off:
>
> https://lkml.org/lkml/2018/3/18/356
>
> The TI AM57xx SDIO needs these flags for the brcmfmac driver to actually work.
>
> I don't see the brcmfmac developers actually fixing it, as "out of
> tree" work for brcmfmac is 100+ patches long:
Thanks for explanation. I understand these are actually used by
out-of-tree driver? That's a valid reason to add them to the binding then...
>
> https://www.cypress.com/documentation/software-and-drivers-archive/wifi-bt-linux-archive?source=search&cat=other
Requires login - I am not able to get the sources.
Best regards,
Krzysztof
next prev parent reply other threads:[~2021-05-05 14:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-05 14:00 [PATCH] ARM: dts: am5729-beagleboneai: drop unused Broadcom WiFi properties Krzysztof Kozlowski
2021-05-05 14:15 ` Robert Nelson
2021-05-05 14:22 ` Krzysztof Kozlowski [this message]
2021-05-05 15:10 ` Robert Nelson
2021-05-05 15:12 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ced6d2f-7107-e612-6787-63e38e5e3edd@canonical.com \
--to=krzysztof.kozlowski@canonical.com \
--cc=alexey.roslyakov@gmail.com \
--cc=bcousson@baylibre.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=drew@beagleboard.org \
--cc=jkridner@beagleboard.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=robertcnelson@gmail.com \
--cc=robh+dt@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).