From: Frank Rowand <frowand.list@gmail.com>
To: Alexandre Torgue <alexandre.torgue@st.com>,
robh+dt@kernel.org, Masahiro Yamada <masahiroy@kernel.org>,
Michal Marek <michal.lkml@markovi.net>,
david@gibson.dropbear.id.au, sjg@chromium.org
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kbuild@vger.kernel.org,
devicetree-compiler@vger.kernel.org
Subject: Re: [RFC PATCH 0/3] Add device tree build information
Date: Fri, 17 Jan 2020 13:13:08 -0600 [thread overview]
Message-ID: <7cfd0bc0-13fd-98ea-9bfd-6cfbbfd77b6d@gmail.com> (raw)
In-Reply-To: <233e0a5f-d38f-908c-5ca7-66ee87d0fcae@st.com>
On 1/16/20 2:19 AM, Alexandre Torgue wrote:
> Hi Franck,
>
> On 1/16/20 3:28 AM, Frank Rowand wrote:
>> On 1/13/20 12:16 PM, Alexandre Torgue wrote:
>>> Hi,
>>>
>>> The goal of this series is to add device tree build information in dtb.
>>> This information can be dtb build date, where devicetree files come from,
>>> who built the dtb ... Actually, same kind of information that you can find
>>> in the Linux banner which is printout during kernel boot. Having the same
>>> kind of information for device tree is useful for debugging and maintenance.
>>>
>>> To achieve that a new option "-B" (using an argument) is added to dtc.
>>> The argument is a file containing a string with build information
>>> (e.g., From Linux 5.5.0-rc1 by alex the Mon Jan 13 18:25:38 CET 2020).
>>> DTC use it to append dts file with a new string property "Build-info".
>>>
>>> of/fdt.c is modified to printout "Build-info" property during Kernel boot and
>>> scripts/Makefile.lib is modified to use dtc -B option during kernel make (this
>>> last part could be improved for sure).
>>
>> Please read through the thread at:
>>
>> https://lore.kernel.org/linux-arm-kernel/550A42AC.8060104@gmail.com/
>>
>> which was my attempt to do something similar.
>
> Yes the idea is the same: get build DTB information like build date,
> "who built the DTB" ... The difference seems to be the way to do it.
> In my case, I don't want to modify existing dts source files., but I
> "just" append them by creating a new property with a string
> containing this build information.>
> Why your proposition has not been accepted ?
Since you are asking this question, I am presuming that you did not
read the replies in the thread I referenced. Please read through
the entire thread. Most of the review comments were objecting to
the concept of my proposal.
-Frank
>
> Regards
> Alex
>
>>
>> -Frank
>>
>>>
>>> Regards
>>> Alex
>>>
>>> Alexandre Torgue (3):
>>> dtc: Add dtb build information option
>>> of: fdt: print dtb build information
>>> scripts: Use -B dtc option to generate dtb build information.
>>>
>>> drivers/of/fdt.c | 9 +++++++
>>> scripts/Makefile.lib | 11 +++++---
>>> scripts/dtc/dtc.c | 55 +++++++++++++++++++++++++++++++++-----
>>> scripts/gen_dtb_build_info | 11 ++++++++
>>> 4 files changed, 76 insertions(+), 10 deletions(-)
>>> create mode 100755 scripts/gen_dtb_build_info
>>>
>>
>
next prev parent reply other threads:[~2020-01-17 19:13 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-13 18:16 [RFC PATCH 0/3] Add device tree build information Alexandre Torgue
2020-01-13 18:16 ` [RFC PATCH 1/3] dtc: Add dtb build information option Alexandre Torgue
2020-01-16 0:57 ` David Gibson
2020-01-16 8:58 ` Alexandre Torgue
2020-01-17 9:09 ` David Gibson
2020-01-17 14:43 ` Rob Herring
2020-01-17 15:11 ` Alexandre Torgue
2020-01-19 6:40 ` David Gibson
2020-01-19 6:39 ` David Gibson
2020-01-21 15:59 ` Rob Herring
2020-01-21 17:18 ` Steve McIntyre
2020-01-23 5:13 ` David Gibson
2020-01-23 14:05 ` Rob Herring
2020-01-20 18:17 ` Steve McIntyre
2020-01-22 18:00 ` Alexandre Torgue
2020-01-22 19:54 ` Frank Rowand
2020-01-13 18:16 ` [RFC PATCH 2/3] of: fdt: print dtb build information Alexandre Torgue
2020-01-13 18:16 ` [RFC PATCH 3/3] scripts: Use -B dtc option to generate " Alexandre Torgue
2020-01-17 19:20 ` Frank Rowand
2020-01-22 19:54 ` Frank Rowand
2020-01-20 16:16 ` Frank Rowand
2020-01-15 15:56 ` [RFC PATCH 0/3] Add device tree " Steve McIntyre
2020-01-16 2:28 ` Frank Rowand
2020-01-16 8:19 ` Alexandre Torgue
2020-01-17 19:13 ` Frank Rowand [this message]
2020-01-20 10:56 ` Alexandre Torgue
2020-01-20 16:14 ` Frank Rowand
2020-01-20 18:28 ` Steve McIntyre
2020-01-21 3:20 ` Frank Rowand
2020-01-21 3:39 ` Frank Rowand
2020-01-21 17:10 ` Steve McIntyre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7cfd0bc0-13fd-98ea-9bfd-6cfbbfd77b6d@gmail.com \
--to=frowand.list@gmail.com \
--cc=alexandre.torgue@st.com \
--cc=david@gibson.dropbear.id.au \
--cc=devicetree-compiler@vger.kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=michal.lkml@markovi.net \
--cc=robh+dt@kernel.org \
--cc=sjg@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).