From: Kant Fan <kant@allwinnertech.com>
To: Chanwoo Choi <cwchoi00@gmail.com>,
myungjoo.ham@samsung.com, kyungmin.park@samsung.com,
cw00.choi@samsung.com
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] devfreq: governor: Add a private governor_data for governors in devfreq
Date: Fri, 14 Oct 2022 17:46:51 +0800 [thread overview]
Message-ID: <7cfeafef-519d-b6e7-77fb-bd5e611faf71@allwinnertech.com> (raw)
In-Reply-To: <abc402b1-1253-fe94-94c4-afb1dfb9aebd@gmail.com>
On 10/13/2022 3:19 AM, Chanwoo Choi wrote:
>
> In addition, the devfreq driver pass the 'data' from devfreq driver
> to governor by using devfreq_add_device. I think that 'devfreq driver'
> is more proper
>
> * @data: devfreq driver pass to governors, governor should not change it.
>
> And then, there are extra changes required.
>
> diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
> index 63347a5ae599..0c59b7978391 100644
> --- a/drivers/devfreq/devfreq.c
> +++ b/drivers/devfreq/devfreq.c
> @@ -776,8 +776,7 @@ static void remove_sysfs_files(struct devfreq *devfreq,
> * @dev: the device to add devfreq feature.
> * @profile: device-specific profile to run devfreq.
> * @governor_name: name of the policy to choose frequency.
> - * @data: private data for the governor. The devfreq framework does not
> - * touch this value.
> + * @data: devfreq driver pass to governors, governor should not change it.
> */
> struct devfreq *devfreq_add_device(struct device *dev,
> struct devfreq_dev_profile *profile,
> @@ -1011,8 +1010,7 @@ static void devm_devfreq_dev_release(struct device *dev, void *res)
> * @dev: the device to add devfreq feature.
> * @profile: device-specific profile to run devfreq.
> * @governor_name: name of the policy to choose frequency.
> - * @data: private data for the governor. The devfreq framework does not
> - * touch this value.
> + * @data: devfreq driver pass to governors, governor should not change it.
> *
> * This function manages automatically the memory of devfreq device using device
> * resource management and simplify the free operation for memory of devfreq
>
Dear Chanwoo,
Thanks for your kindly advice. I've modified it as patch-v3 [1]. Please
have a look.
[1]
https://lore.kernel.org/all/20221014094359.100995-1-kant@allwinnertech.com/
--
Best Regards,
Kant Fan
prev parent reply other threads:[~2022-10-14 9:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-10 7:22 [PATCH v2] devfreq: governor: Add a private governor_data for governors in devfreq Kant Fan
2022-10-12 19:00 ` Chanwoo Choi
2022-10-12 19:19 ` Chanwoo Choi
2022-10-14 9:46 ` Kant Fan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7cfeafef-519d-b6e7-77fb-bd5e611faf71@allwinnertech.com \
--to=kant@allwinnertech.com \
--cc=cw00.choi@samsung.com \
--cc=cwchoi00@gmail.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).