From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934088AbcIXPgf (ORCPT ); Sat, 24 Sep 2016 11:36:35 -0400 Received: from saturn.retrosnub.co.uk ([178.18.118.26]:59379 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757101AbcIXPgb (ORCPT ); Sat, 24 Sep 2016 11:36:31 -0400 Subject: Re: [PATCH 1/7] iio: Use kmalloc_array() in iio_scan_mask_set() To: SF Markus Elfring , linux-iio@vger.kernel.org, Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler References: <566ABCD9.1060404@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: Jonathan Cameron Message-ID: <7d1ed0ab-f3ce-3112-a004-1540c54638fd@kernel.org> Date: Sat, 24 Sep 2016 16:36:29 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 24/09/16 07:24, SF Markus Elfring wrote: > From: Markus Elfring > Date: Fri, 23 Sep 2016 22:30:32 +0200 > > A multiplication for the size determination of a memory allocation > indicated that an array data structure should be processed. > Thus use the corresponding function "kmalloc_array". > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring Applied to the togreg branch of iio.git - initially pushed out as testing for the autobuilders to play with it. Thanks, Jonathan > --- > drivers/iio/industrialio-buffer.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/drivers/iio/industrialio-buffer.c b/drivers/iio/industrialio-buffer.c > index 49bf9c5..7a4d9499 100644 > --- a/drivers/iio/industrialio-buffer.c > +++ b/drivers/iio/industrialio-buffer.c > @@ -307,10 +307,9 @@ static int iio_scan_mask_set(struct iio_dev *indio_dev, > const unsigned long *mask; > unsigned long *trialmask; > > - trialmask = kmalloc(sizeof(*trialmask)* > - BITS_TO_LONGS(indio_dev->masklength), > - GFP_KERNEL); > - > + trialmask = kmalloc_array(BITS_TO_LONGS(indio_dev->masklength), > + sizeof(*trialmask), > + GFP_KERNEL); > if (trialmask == NULL) > return -ENOMEM; > if (!indio_dev->masklength) { >