From: Scott Wood <swood@redhat.com>
To: Alan Tull <atull@kernel.org>,
Moritz Fischer <moritz.fischer.private@gmail.com>
Cc: Wu Hao <hao.wu@intel.com>,
linux-fpga@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] fpga: dfl: afu: Pass the correct device to dma_mapping_error()
Date: Wed, 08 May 2019 16:39:51 -0500 [thread overview]
Message-ID: <7d3a76c0c9115726402cfc52da92fd8e2cac426c.camel@redhat.com> (raw)
In-Reply-To: <CANk1AXTv2DFpRDAJ9UH9+LRo=wrmcbP02zbWbtTXku6iwPAhOw@mail.gmail.com>
On Mon, 2019-04-15 at 14:22 -0500, Alan Tull wrote:
> On Thu, Apr 11, 2019 at 11:36 AM Moritz Fischer
> <moritz.fischer.private@gmail.com> wrote:
>
> Hi Scott,
>
> Thanks!
>
> > Hi Scott,
> >
> > good catch!
> >
> > On Thu, Apr 11, 2019 at 5:49 AM Wu Hao <hao.wu@intel.com> wrote:
> > > On Wed, Apr 10, 2019 at 04:53:27PM -0500, Scott Wood wrote:
> > > > dma_mapping_error() was being called on a different device struct
> > > > than
> > > > what was passed to map/unmap. Besides rendering the error checking
> > > > ineffective, it caused a debug splat with CONFIG_DMA_API_DEBUG.
> > > >
> > > > Signed-off-by: Scott Wood <swood@redhat.com>
> > >
> > > Hi Scott,
> > >
> > > Looks good to me. Thanks for catching this issue.
> > >
> > > Acked-by: Wu Hao <hao.wu@intel.com>
> > >
> > > Hao
> > >
> > > > ---
> > > > drivers/fpga/dfl-afu-dma-region.c | 2 +-
> > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/drivers/fpga/dfl-afu-dma-region.c b/drivers/fpga/dfl-
> > > > afu-dma-region.c
> > > > index e18a786fc943..cd68002ac097 100644
> > > > --- a/drivers/fpga/dfl-afu-dma-region.c
> > > > +++ b/drivers/fpga/dfl-afu-dma-region.c
> > > > @@ -399,7 +399,7 @@ int afu_dma_map_region(struct
> > > > dfl_feature_platform_data *pdata,
> > > > region->pages[0], 0,
> > > > region->length,
> > > > DMA_BIDIRECTIONAL);
> > > > - if (dma_mapping_error(&pdata->dev->dev, region->iova)) {
> > > > + if (dma_mapping_error(dfl_fpga_pdata_to_parent(pdata), region-
> > > > >iova)) {
> > > > dev_err(&pdata->dev->dev, "failed to map for dma\n");
> > > > ret = -EFAULT;
> > > > goto unpin_pages;
> > > > --
> > > > 1.8.3.1
> >
> > Acked-by: Moritz Fischer <mdf@kernel.org>
>
> Acked-by: Alan Tull <atull@kernel.org>
Whose tree would these patches be going through?
-Scott
next prev parent reply other threads:[~2019-05-08 21:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-10 21:53 [PATCH] fpga: dfl: afu: Pass the correct device to dma_mapping_error() Scott Wood
2019-04-11 12:33 ` Wu Hao
2019-04-11 16:35 ` Moritz Fischer
2019-04-15 19:22 ` Alan Tull
2019-05-08 21:39 ` Scott Wood [this message]
2019-05-09 1:55 ` Moritz Fischer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d3a76c0c9115726402cfc52da92fd8e2cac426c.camel@redhat.com \
--to=swood@redhat.com \
--cc=atull@kernel.org \
--cc=hao.wu@intel.com \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=moritz.fischer.private@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).