From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1AD5BC433F5 for ; Mon, 14 Mar 2022 16:43:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238650AbiCNQo4 (ORCPT ); Mon, 14 Mar 2022 12:44:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33828 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244516AbiCNQoE (ORCPT ); Mon, 14 Mar 2022 12:44:04 -0400 Received: from smtp-relay-internal-0.canonical.com (smtp-relay-internal-0.canonical.com [185.125.188.122]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9514F2671 for ; Mon, 14 Mar 2022 09:42:51 -0700 (PDT) Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 2D009405A5 for ; Mon, 14 Mar 2022 16:42:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1647276170; bh=Tz9ZNgcki9IM3FCuunguyV56DMoZc7Tr9Mm7Sjlp0x4=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=SVJPnKoOc/aEwb0r6xeKyn1wekVFxaRm9wvDoBHl2vxtup3wKKQxjs7K09SMpWndU gtYsr/fkavYl+93hxPnJOb6WV4n5UyhYbiDo/RvPZDzC9FZM6Y+XI2h5DVEFiS76L0 c07TjrIj5TICy1Qx5679tZs/fryNXpZhGoqzXEJZ/uEuWpMy00GKP78uRWCQlSt2iN kzNExFAwPQKC/cfvtgakTVZUSE1qFvS7PzocL568deiLzHVs+UykyM+1/sxS/yfXJL KNBF1InPlQDSdAF1TAimMbkh4QxbJJ9E/tPfFJCvhixwMD00bRc0Nvx/knSaqQIg/b MkgAqw78jwDrw== Received: by mail-ej1-f72.google.com with SMTP id l24-20020a170906a41800b006da873d66b6so8185206ejz.3 for ; Mon, 14 Mar 2022 09:42:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=Tz9ZNgcki9IM3FCuunguyV56DMoZc7Tr9Mm7Sjlp0x4=; b=aqOtWa9MoiT0rva3SNZ8jTPVLdQAvEdYAHh+Nc1lBiG5Jp7o1Q0J7SacTiAkNtDkFj C+IsL37w61f8DHyJvYPqs4h5XecDgvpF4eWOI0SSYtVlheu7GSPljhmBrGPJWtrY6jjV Me7vSZ4g1TB0bs2Kh0q3SyIMGONhDC1UpkGJs96IugOf/tnKwMD6dBZu0TRl8UtJ0n5D fbiDe9ANwEf6WxdLhl4OGB9ND+2/FIV4eUEbSR57zmKCGU2bzxM6vOO5qFuAtLC1Nw7D WhiFDl46hjf+NmlVeHnoYTPFVvHZAp9pBJGQdw5FS4YGKA9uGK2qkUGkWzyZH9C/ooaJ qLuA== X-Gm-Message-State: AOAM532SGune0xKJj8y4LnYeRI3mqjXD/FRhY79/UCgTL+DwKetRN12j vk2p7flxnE+Q98SSep1nTAZQNorqbaR3zywEyrCVflqBTKm6h7ZIu8edIdvJNlLRBj0jve70+5l 8u2KVQsa21muGC8EnhkZr+QlwwWVCpGwMkGNtiylNPQ== X-Received: by 2002:a17:906:3a83:b0:6d6:e54d:3264 with SMTP id y3-20020a1709063a8300b006d6e54d3264mr19561886ejd.96.1647276169864; Mon, 14 Mar 2022 09:42:49 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx34GYPJ8QiU5oevtOaGkstabUItCiKv4aw+jxv2P1DTpWtgTxUAEh3ZyVjY+fT4Cty1Peodw== X-Received: by 2002:a17:906:3a83:b0:6d6:e54d:3264 with SMTP id y3-20020a1709063a8300b006d6e54d3264mr19561873ejd.96.1647276169647; Mon, 14 Mar 2022 09:42:49 -0700 (PDT) Received: from [192.168.0.152] (xdsl-188-155-174-239.adslplus.ch. [188.155.174.239]) by smtp.googlemail.com with ESMTPSA id u9-20020a170906124900b006ce88a505a1sm7205436eja.179.2022.03.14.09.42.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Mar 2022 09:42:48 -0700 (PDT) Message-ID: <7d560277-95e2-070c-e603-30f00dea7f51@canonical.com> Date: Mon, 14 Mar 2022 17:42:47 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v1 2/2] dt-bindings: usb: Add bindings doc for Sunplus USB HOST OHCI driver Content-Language: en-US To: Vincent Shih , gregkh@linuxfoundation.org, stern@rowland.harvard.edu, p.zabel@pengutronix.de, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, robh+dt@kernel.org, devicetree@vger.kernel.org, wells.lu@sunplus.com References: <1647235924-15572-1-git-send-email-vincent.sunplus@gmail.com> <1647235924-15572-3-git-send-email-vincent.sunplus@gmail.com> From: Krzysztof Kozlowski In-Reply-To: <1647235924-15572-3-git-send-email-vincent.sunplus@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14/03/2022 06:32, Vincent Shih wrote: > Add bindings doc for Sunplus USB HOST OHCI driver > > Signed-off-by: Vincent Shih > --- > .../bindings/usb/sunplus,sp7021-usb-ohci.yaml | 69 ++++++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 70 insertions(+) > create mode 100644 Documentation/devicetree/bindings/usb/sunplus,sp7021-usb-ohci.yaml > > diff --git a/Documentation/devicetree/bindings/usb/sunplus,sp7021-usb-ohci.yaml b/Documentation/devicetree/bindings/usb/sunplus,sp7021-usb-ohci.yaml > new file mode 100644 > index 0000000..7583b68 > --- /dev/null > +++ b/Documentation/devicetree/bindings/usb/sunplus,sp7021-usb-ohci.yaml > @@ -0,0 +1,69 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +# Copyright (C) Sunplus Co., Ltd. 2021 > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/usb/sunplus,sp7021-usb-ohci.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + Looks good. Few minor nitpicks: > +title: Sunplus SP7021 OHCI Controller Device Tree Bindings Remove "Device Tree Bindings" words here. Title is about hardware. > + > +allOf: > + - $ref: usb-hcd.yaml# Put entire "allOf:" just before "properties:". > + > +maintainers: > + - Vincent Shih > + > +description: > + Sunplus SP7021 USB HOST IP is a USB2.0 Host Controller. It supports both > + Enhanced Host Controller Interface (EHCI) and Open Host Controller Interface > + (OHCI). > + > + It supports 32-bits address bus and 64bit data bus interface, compliant > + to AMBA AXI interface for data transfer. > + > + It supports 32-bits address and data bus interface, compliant to AMBA > + AHB interface for register configurations. > + > + It supports 32-bits address and data bus interface, compliant to AMBA > + AXI interface for register alternative configurations. > + > + The UTM Interface block generates PHY control signals, compliant to > + USB2.0 Transceiver Macrocell Interface Specification Revision 1.0. > + > +properties: > + compatible: > + const: sunplus,sp7021-usb-ohci > + > + reg: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + resets: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 You might need here phys. Are you sure you do not need to configure the phy for OHCI? You should not assume it would be configured by other driver. Best regards, Krzysztof