From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2585EC47094 for ; Thu, 10 Jun 2021 08:56:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 06EB661351 for ; Thu, 10 Jun 2021 08:56:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230134AbhFJI6v (ORCPT ); Thu, 10 Jun 2021 04:58:51 -0400 Received: from so254-9.mailgun.net ([198.61.254.9]:30426 "EHLO so254-9.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229770AbhFJI6u (ORCPT ); Thu, 10 Jun 2021 04:58:50 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1623315414; h=Content-Transfer-Encoding: Content-Type: In-Reply-To: MIME-Version: Date: Message-ID: References: Cc: To: From: Subject: Sender; bh=UPJ0taLEBb3jkwcs8gildde6vVSayjTGVrrycTxL2Vo=; b=BjFyc9voJIuW054EbIkcseypbHrDN//rA6zjQj3LDXDy7IGXqzAPLo0bCCn8cy6LSTTIKBtW /MV0RK5WdEIxAkKTHmAT01V+d32rdLeYC5uoFR/5IQisEyKmZ5B+2qD1Wz+WrlqXd05ePwCo 9/J+HqDYiYsvETSTlgdYFjUAWSA= X-Mailgun-Sending-Ip: 198.61.254.9 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n07.prod.us-east-1.postgun.com with SMTP id 60c1d3d4e27c0cc77fdfa9e9 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Thu, 10 Jun 2021 08:56:52 GMT Sender: faiyazm=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 20B21C43144; Thu, 10 Jun 2021 08:56:51 +0000 (UTC) Received: from [192.168.0.105] (unknown [49.204.182.221]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: faiyazm) by smtp.codeaurora.org (Postfix) with ESMTPSA id 6425DC433D3; Thu, 10 Jun 2021 08:56:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 6425DC433D3 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=faiyazm@codeaurora.org Subject: Re: [PATCH v11] mm: slub: move sysfs slab alloc/free interfaces to debugfs From: Faiyaz Mohammed To: Andy Shevchenko Cc: Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , linux-mm , Linux Kernel Mailing List , Greg KH , glittao@gmail.com, vinmenon@codeaurora.org, Vlastimil Babka References: <1623141934-7699-1-git-send-email-faiyazm@codeaurora.org> <78fc8848-bde8-769e-f8e9-6157d232a60f@suse.cz> <47842d8d-2747-3d0f-8695-122dc23d90e6@codeaurora.org> Message-ID: <7d652fca-23f3-fc03-c7b2-310edcafebb3@codeaurora.org> Date: Thu, 10 Jun 2021 14:26:43 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <47842d8d-2747-3d0f-8695-122dc23d90e6@codeaurora.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Andy, On 6/8/2021 11:43 PM, Faiyaz Mohammed wrote: > > > On 6/8/2021 11:05 PM, Vlastimil Babka wrote: >> On 6/8/21 7:11 PM, Faiyaz Mohammed wrote: >>> >>> >>> On 6/8/2021 5:20 PM, Andy Shevchenko wrote: >>>> On Tue, Jun 8, 2021 at 11:45 AM Faiyaz Mohammed wrote: >>>>> >>>>> alloc_calls and free_calls implementation in sysfs have two issues, >>>>> one is PAGE_SIZE limitation of sysfs and other is it does not adhere >>>>> to "one value per file" rule. >>>>> >>>>> To overcome this issues, move the alloc_calls and free_calls >>>>> implementation to debugfs. >>>>> >>>>> Debugfs cache will be created if SLAB_STORE_USER flag is set. >>>>> >>>>> Rename the alloc_calls/free_calls to alloc_traces/free_traces, >>>>> to be inline with what it does. >>>>> >>>>> Signed-off-by: Faiyaz Mohammed >>>>> --- >>>> >>>> It seems you missed the version bump along with changelog. >>>> Note, some maintainers (actually quite many I think) are using tools >>>> to fetch up the patches and two patches with the same version is a >>>> problem. Hence I do not consider it a nit-pick. >>>> >>> Hmmm, I think to avoid same version problem I have to push same patch >>> with new version number and thank you for your patience. >> >> I *think* Andrew wouldn't have this issue, so maybe resend only if he says it's >> needed. > Sure, I will send if he ask. Do I need to send patch with new version number?. >> On the other hand I did have troubles to apply the last version locally, patch >> (tool) complained of patch (file) being malformed at the end. Did you add or >> delete lines from it after generating the patch? I had to use the recountdiff > Yes, I added one line manually, I think that causes the issue. > >> tool to fix this. If you're going to resend, please make sure it's without the >> same issue. >> > Okay > >>> Thanks and regards, >>> Mohammed Faiyaz >>> >>