From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756042AbcEQK03 (ORCPT ); Tue, 17 May 2016 06:26:29 -0400 Received: from mail-db3on0116.outbound.protection.outlook.com ([157.55.234.116]:33712 "EHLO emea01-db3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755408AbcEQK01 (ORCPT ); Tue, 17 May 2016 06:26:27 -0400 X-Greylist: delayed 62804 seconds by postgrey-1.27 at vger.kernel.org; Tue, 17 May 2016 06:26:26 EDT Authentication-Results: virtuozzo.com; dkim=none (message not signed) header.d=none;virtuozzo.com; dmarc=none action=none header.from=virtuozzo.com; Subject: Re: [PATCHv8 resend 2/2] selftest/x86: add mremap vdso test To: Andy Lutomirski , Ingo Molnar References: <1462886951-23376-1-git-send-email-dsafonov@virtuozzo.com> <1462886951-23376-2-git-send-email-dsafonov@virtuozzo.com> <20160516135442.GA14452@gmail.com> <512f4c9c-7edc-0d12-df96-9708df5f498d@virtuozzo.com> CC: "linux-kernel@vger.kernel.org" , Ingo Molnar , Thomas Gleixner , "H. Peter Anvin" , X86 ML , Andrew Morton , "linux-mm@kvack.org" , Dmitry Safonov <0x7f454c46@gmail.com>, Shuah Khan , From: Dmitry Safonov Message-ID: <7d74b270-01dd-aab9-8133-249fe9a52767@virtuozzo.com> Date: Tue, 17 May 2016 13:25:04 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [195.214.232.10] X-ClientProxiedBy: DB5PR06CA0001.eurprd06.prod.outlook.com (10.162.165.11) To DB6PR0801MB1302.eurprd08.prod.outlook.com (10.168.11.20) X-MS-Office365-Filtering-Correlation-Id: cc3d0487-e54c-4052-963d-08d37e3daf06 X-Microsoft-Exchange-Diagnostics: 1;DB6PR0801MB1302;2:wXpDmDI/6Fl/mameQglMjAxbepIDg1lrMX5DlgGk6STQKo+r4bFuXGy5G+xClxp3O1KeJ92SLm8Blc+tW/JJnqUVKKggedGdpZLYjQYKOXiRhQukgu1g0wxP42CFwQpKifPxUnlGyG9XY7Ut2TVSwNmL3D38w1iZez1b1R3FVkr0XduQIyvu920CCcHutmF9;3:F+dDOHRdxn7a0iE8QHt0jC7x6Gk8rSM2uyrQEsJZ/Du5piENs3Rv3xja3Q6UC6N6hd088xBSO4SUr5W2WQdRjYcoKv5qBDG1EzjfO8tAFBub+HDYVDiiZZ3X5BMT19cH;25:VZF53FMGvfj+ATuUvuD0j2IzG5CJsid4WwVpZHoVocwv5YjBXiz0HNgpXbHAUwMWrldrL8PEskEinAQR/mbhtpKNux439sVZfik8np5CQIypZqBDlP5wllH8T30f1veUIMsmd5agDhEDdPeWFtxmpDZvHzngadlWete1dZFsbSQNu6nz+H0g2yxRGLXfASfGOwSELlfrSkH7b7Y2fsKl6RlKsq1TpsJASos+pznJiwF+Ag+iGs+Ac9yvwQAzLSskqTJ2H0muAdiI/R4gAkoCpLwV1Ez8F5MdZKP7BPN2Ik2u2HZeMAQBPhYVN1+Zu8PZyugEeY37Q2PsU39BPxPyLkC2hFCmDJR+tD0cTw/QtIs9gYZNVIlhaJpSTjq86EYcXp5XMILnMeSBWAsHrlbN03K4q8igfhvOe3T4tiU1bz8= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DB6PR0801MB1302; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040130)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6041072)(6043046);SRVR:DB6PR0801MB1302;BCL:0;PCL:0;RULEID:;SRVR:DB6PR0801MB1302; X-Microsoft-Exchange-Diagnostics: 1;DB6PR0801MB1302;4:0MR2AzjXwM5QYsyUgk+k1QXVwcC5mpVQVwJT7H5lWaQj6u7fq4RExlwfbv3sEUwTnaE+BV9CWa/iRS4142rk31aIl3qabtfLeQRcj5Lt7+qnm3LdyxwZUAkdsbAPKBXh5lLK7KE841NU3WBS+USaEE0zTa1c8DsoA17hoyG6ElF2KBqlM3OPEbxe0yRSye50aTGQhYSzdhubgcdkMnNQH0VHa9KXQpSHI11xSsHml/5ILKAJ+GKEYizMjumbMAgShxoaTfkJTgvj+BHIVi8zXfV2xnCLR2Myq4ZmhgNV6EoA05kNoliC10uEe3iEnFajwFDIwQT7J84tC5CzFEflCVONJiHOE95f0fRg7XHW0xoUgdlVjZ2mNKpqfM1SJ9CfH1wwfAHONgkSr5qdIiIxUpJc1bALR3/aqwyWPvfhh/c= X-Forefront-PRVS: 0945B0CC72 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(6049001)(377454003)(24454002)(36756003)(230700001)(2906002)(4326007)(5004730100002)(19580405001)(86362001)(586003)(65956001)(66066001)(6116002)(5001770100001)(64126003)(3846002)(5008740100001)(47776003)(189998001)(4001350100001)(23676002)(42186005)(92566002)(50986999)(33646002)(50466002)(76176999)(77096005)(2950100001)(81166006)(8676002)(31686004)(31696002)(54356999)(19580395003)(93886004)(65826006);DIR:OUT;SFP:1102;SCL:1;SRVR:DB6PR0801MB1302;H:[10.30.26.154];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtEQjZQUjA4MDFNQjEzMDI7MjM6Q0ZRcDhZWE1tblZqcktoSFVsdmRkVjZn?= =?utf-8?B?OXNnQkh0c0o1UVBTMGt3MXA0K2w1R1RxQWIyaGJVU25pbnlEZ3ltQzV0SFlS?= =?utf-8?B?WWJnZ0hoc0doS2hmem00RU9QYTBUTmdMbkxZcXQ0Zit5RlBBNUx1WXFRZlkr?= =?utf-8?B?Z1J3TDJJeUIrMEpYMmpYTmM0Qm52czE0MzNpSndlTkR0aW5nenJQbDM4VkVU?= =?utf-8?B?aXlyQXB2SWhTMjJBc1JYMkE1eSt0MlhKeStPRldEN1B3RGlzQ0VoaHAwak9i?= =?utf-8?B?bnk3TldXS0FES2tvU2xIWFdtU3E2ZmJiLzN4aFFPN0xyTWZrN0RSalRibXU0?= =?utf-8?B?Q0ZFS29ueDFxT0Y3U3BaMU12QkRRaFhmL1NVY1IvNzJuYVI2RWFJYmx4alRZ?= =?utf-8?B?S1F5YUFZcVM1bmxBdGpZWHhvam1oYjdwaHhaUmVTWHIxSVVMM1h1cXhxTmxH?= =?utf-8?B?OG1ldEFLSWFFMStaSUwrVzdVd0dEYytabjJEWEFLNnQ3RGFydFhpWlFlcmZ5?= =?utf-8?B?TXFKRDNuR0hsYzN5RWtQQ0VJemEzWFArQ2JnVVpDM1pHOXcxUkJTREZkMTlV?= =?utf-8?B?T0Jua1RndGRUcTM2b2MvbkhLOWhHMzdKQndHY1F4SGNmOHFmeEdITVFKa05y?= =?utf-8?B?R0RKaHc0ZDQzRlQvZ0IxdlA1M2pVdlhMRVNMazIvanBIOXlNWjVENmZmSm9v?= =?utf-8?B?bW9JbjBOcjFpS0g4SndaNFBOdW1Ed2QrUzFHUVNhRVh0L08vbjNoWmFMSTNM?= =?utf-8?B?aEtQc2t0SVY0WUtBZHU5elRYWlVJL1lDa3Y5ZVV2TTBBVkwvZWFvR21xamtl?= =?utf-8?B?NmlHYVNDWnV1QVBpWENTZ3JTQXRJRElBeTRGS3Ntc290aWdIUms5eXpGa25F?= =?utf-8?B?ZWFraWFmK092VEFRbUp5aFRYWVdTWFY1ZW9ZYzM5N21sR0xjYzNEaCtkSSta?= =?utf-8?B?M3gwcndEcEJ4VWgrRjAyaThSdDRPTVJ3WHF2NERnL25pbVNINkJ0cFlhaUti?= =?utf-8?B?NTdzemxrKzNYS0lIY1Nsbkl5bVpORkV6a2RaYkZtUFZOY2F2MXVqL2QwaVdp?= =?utf-8?B?ZitRY1h4a0ZlbG5uQVp5aWVuNlVUSkxwRE90VHNDbGtvTU5yN2RYdkZOd2ZT?= =?utf-8?B?YnR0MVZYOHF1Ui9tYmIxVWlRQlhHNzMzVVBWdE50eFBOMFJDK01vZHJOWmNi?= =?utf-8?B?MEFzbXlTQkNiaFZKTGNOZVNONWVlOXk1VERER3hyQzZLTXAvZ0N1UXcwNEIr?= =?utf-8?B?WDd6bTFldEFZVThZMTRVZVZuTnhCa3BsamVnWWNYNktiYmsySEMvcUViZVZ5?= =?utf-8?B?Mm03UHlJZUNER1N2MzRMOGQ3aUpmTEVHbWlQWnlnSjNEQXNlSWs3dHcrU0hj?= =?utf-8?B?bTk5L1ZpTFRxS3pkWU0xMmhYZEdnNzU1OENEWnhPa1BlVmNwc0JiS2hJNEVt?= =?utf-8?Q?eP9/3/pgdy/wXhef1v1JSx/R9OOX7?= X-Microsoft-Exchange-Diagnostics: 1;DB6PR0801MB1302;5:7mLHEG2sCCSTU8u8AQpw8dzcaowX4zbP+uK/sski322oOMjhX0OzUqJ0U9tdhzZRrM/nUzXAUvydorgia0xIkMbw3F5ejnw3xRM+qSGrVPFpYEuBaUctZG4cBmPw9Ak1sMaZ0IhBvYFyiuC+ayG0sg==;24:EUagbLowKd/+eOYwn3L1+8V/Z5Py96TreyRaRxty1UAZMQe9h6o4sZbfDIXH1Z0XfjfQO3v7AlIbZKshhSCnVsQyaSx/XMX3220G6ngqEHE=;7:ROlG0Ri+ryZFQQ5mdVezBbsM5d7cgzywfjzJasgizaqTwmQsXpz2wDFrmJ5PfircTl+LRU3uT2kqWFTM/Y2WyN9TxuCtxlY3TZ5Ff4PksAj0boiYyOefX4zchuSKKOY1zBS9FsErkJs9omPN9klBA9qTLT4J5gUBTNaia7gAB/J2S8y1cN2kKeOFAObIeq4n;20:iE+2MkOESIvVB1lWY/aOxKem2k4s6yjE/OxyqrRcM/1k9itDBJrNJFClNJ1il7YtgWf4FggM4x6NfYq5FCXXacu2cQQ3c8Vg/yAxgzNajXxBOqJjtJwK5ZcLTFPKnFtybKX4CJz6/LL77YTQN/v9CPdxcJzHXpmNyc6QqYdgRDQ= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 May 2016 10:26:16.6420 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0801MB1302 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/16/2016 09:25 PM, Andy Lutomirski wrote: > On Mon, May 16, 2016 at 9:24 AM, Dmitry Safonov wrote: >> On 05/16/2016 04:54 PM, Ingo Molnar wrote: >>> >>> >>> * Dmitry Safonov wrote: >>> >>>> Should print on success: >>>> [root@localhost ~]# ./test_mremap_vdso_32 >>>> AT_SYSINFO_EHDR is 0xf773f000 >>>> [NOTE] Moving vDSO: [f773f000, f7740000] -> [a000000, a001000] >>>> [OK] >>>> Or segfault if landing was bad (before patches): >>>> [root@localhost ~]# ./test_mremap_vdso_32 >>>> AT_SYSINFO_EHDR is 0xf774f000 >>>> [NOTE] Moving vDSO: [f774f000, f7750000] -> [a000000, a001000] >>>> Segmentation fault (core dumped) >>> >>> >>> Can the segfault be caught and recovered from, to print a proper failure >>> message? >> >> >> Will add segfault handler, thanks. >> > > It may be more complicated that that. Glibc is likely to explode if > this happens, and the headers are sufficiently screwed up that it's > awkward to bypass glibc and call rt_sigaction directly. I have a test > that does the latter, though, so it's at least possible, but I'm > unconvinced it's worth it just for an error message. Oh, I didn't know that, thanks, Andy. I'll leave it as is for simplicity. -- Regards, Dmitry Safonov