LKML Archive on
 help / color / Atom feed
From: Jorge Ramirez <>
To: Mark Brown <>
Subject: Re: [PATCH] regulator: core: do not report EPROBE_DEFER as error.
Date: Wed, 17 Apr 2019 19:05:52 +0200
Message-ID: <> (raw)
In-Reply-To: <>

On 4/17/19 17:46, Mark Brown wrote:
> On Wed, Apr 17, 2019 at 10:54:11AM +0200, Jorge Ramirez-Ortiz wrote:
>> Do not log a temporary failure to get a regulator (EPROBE_DEFER) while
>> the driver is requesting retries.
>> -			dev_err(dev, "Failed to get supply '%s': %d\n",
>> -				consumers[i].supply, ret);
>> +			if (ret != -EPROBE_DEFER)
>> +				dev_err(dev, "Failed to get supply '%s': %d\n",
>> +					consumers[i].supply, ret);
> Please leave at least a debug log in place, it's not good to just
> silently fail - even if we will retry someone might still need some help
> debugging (eg, figuring out that they need to enable whatever driver is
> providing the supply in their config) so we should tell them why we're
> deferring.

you mean replacing dev_err with dev_dbg on all cases or only on defer
leaving  dev_err on the rest?

> BTW does an e-mail address need updating somewhere here?

dont know, whose email? I got these from (below); or
are you referring to mine (in which case it is correct, I am back at
least for a bit longer)

Liam Girdwood <> (supporter:VOLTAGE AND CURRENT

  reply index

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-17  8:54 Jorge Ramirez-Ortiz
2019-04-17 15:46 ` Mark Brown
2019-04-17 17:05   ` Jorge Ramirez [this message]
2019-04-17 17:30     ` Mark Brown

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

LKML Archive on

Archives are clonable:
	git clone --mirror lkml/git/0.git
	git clone --mirror lkml/git/1.git
	git clone --mirror lkml/git/2.git
	git clone --mirror lkml/git/3.git
	git clone --mirror lkml/git/4.git
	git clone --mirror lkml/git/5.git
	git clone --mirror lkml/git/6.git
	git clone --mirror lkml/git/7.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 lkml lkml/ \
	public-inbox-index lkml

Newsgroup available over NNTP:

AGPL code for this site: git clone public-inbox