From: <Claudiu.Beznea@microchip.com>
To: <andrew@lunn.ch>
Cc: <davem@davemloft.net>, <kuba@kernel.org>, <robh+dt@kernel.org>,
<Nicolas.Ferre@microchip.com>, <linux@armlinux.org.uk>,
<paul.walmsley@sifive.com>, <palmer@dabbelt.com>,
<yash.shah@sifive.com>, <netdev@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-riscv@lists.infradead.org>
Subject: Re: [PATCH 3/7] net: macb: unprepare clocks in case of failure
Date: Mon, 7 Dec 2020 09:26:01 +0000 [thread overview]
Message-ID: <7d9bb653-5ea6-e2d3-d130-83a9cf2974f5@microchip.com> (raw)
In-Reply-To: <20201205143001.GC2420376@lunn.ch>
Hi Andrew,
On 05.12.2020 16:30, Andrew Lunn wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> On Fri, Dec 04, 2020 at 02:34:17PM +0200, Claudiu Beznea wrote:
>> Unprepare clocks in case of any failure in fu540_c000_clk_init().
>
> Hi Claudiu
>
> Nice patchset. Simple to understand.
>>
>
>> +err_disable_clocks:
>> + clk_disable_unprepare(*tx_clk);
>
>> + clk_disable_unprepare(*hclk);
>> + clk_disable_unprepare(*pclk);
>> + clk_disable_unprepare(*rx_clk);
>> + clk_disable_unprepare(*tsu_clk);
>
> This looks correct, but it would be more symmetrical to add a
>
> macb_clk_uninit()
>
> function for the four main clocks. I'm surprised it does not already
> exist.
I was in balance b/w added and not added it taking into account that the
disable unprepares are not taking care of all the clocks, in all the
places, in the same way. Anyway, I will add one function for the main
clocks, as you proposed, in the next version.
Thank you for your review,
Claudiu
>
> Andrew
>
next prev parent reply other threads:[~2020-12-07 9:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-04 12:34 [PATCH 0/7] net: macb: add support for sama7g5 Claudiu Beznea
2020-12-04 12:34 ` [PATCH 1/7] net: macb: add userio bits as platform configuration Claudiu Beznea
2020-12-05 14:30 ` Andrew Lunn
2020-12-04 12:34 ` [PATCH 2/7] net: macb: add capability to not set the clock rate Claudiu Beznea
2020-12-05 14:32 ` Andrew Lunn
2020-12-04 12:34 ` [PATCH 3/7] net: macb: unprepare clocks in case of failure Claudiu Beznea
2020-12-05 14:30 ` Andrew Lunn
2020-12-07 9:26 ` Claudiu.Beznea [this message]
2020-12-04 12:34 ` [PATCH 4/7] dt-bindings: add documentation for sama7g5 ethernet interface Claudiu Beznea
2020-12-05 14:32 ` Andrew Lunn
2020-12-04 12:34 ` [PATCH 5/7] dt-bindings: add documentation for sama7g5 gigabit " Claudiu Beznea
2020-12-05 14:32 ` Andrew Lunn
2020-12-04 12:34 ` [PATCH 6/7] net: macb: add support for sama7g5 gem interface Claudiu Beznea
2020-12-05 14:33 ` Andrew Lunn
2020-12-04 12:34 ` [PATCH 7/7] net: macb: add support for sama7g5 emac interface Claudiu Beznea
2020-12-05 14:33 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d9bb653-5ea6-e2d3-d130-83a9cf2974f5@microchip.com \
--to=claudiu.beznea@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
--cc=yash.shah@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).