From: Iouri Tarassov <iourit@linux.microsoft.com>
To: iourit@microsoft.com, iouri_t@hotmail.com
Cc: haiyangz@microsoft.com, sthemmin@microsoft.com,
gregkh@linuxfoundation.org, iourit@microsoft.com,
linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org
Subject: Re: [PATCH 1/4] drivers: hv: dxgkrnl: core code
Date: Wed, 26 Aug 2020 13:20:23 -0700 [thread overview]
Message-ID: <7db18ff7-e99b-62db-508e-a6054c9ac3f9@linux.microsoft.com> (raw)
In-Reply-To: <20200814131839.u2vy52mtiejtuwcg@liuwe-devbox-debian-v2>
On 8/14/2020 6:18 AM, Wei Liu wrote:
> On Fri, Aug 14, 2020 at 08:38:53AM -0400, Sasha Levin wrote:
> [...]
>> +
>> +#include "dxgkrnl.h"
>> +
>> +int dxgadapter_init(struct dxgadapter *adapter, struct hv_device *hdev)
>> +{
>> + int ret = 0;
>> + char s[80];
>> +
>> + UNUSED(s);
> If s is not used, why not just remove it?
>
> Indeed it is not used anywhere in this function. That saves you 80 bytes
> on stack.
>
>> +static int dxgk_destroy_hwcontext(struct dxgprocess *process,
>> + void *__user inargs)
>> +{
>> + /* This is obsolete entry point */
>> + return ENOTTY;
>> +}
>> +
> Other places have been using negative numbers for errors. I guess you
> want -ENOTTY here too.
>
> Wei.
>
>
next prev parent reply other threads:[~2020-08-26 20:20 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-14 12:38 [PATCH 0/4] drivers: hv: Microsoft Virtual GPU Driver Sasha Levin
2020-08-14 12:38 ` [PATCH 1/4] drivers: hv: dxgkrnl: core code Sasha Levin
2020-08-14 12:55 ` Greg KH
2020-08-27 23:29 ` Iouri Tarassov
2020-08-28 6:01 ` Greg KH
2020-08-14 12:57 ` Greg KH
2020-08-27 23:45 ` Iouri Tarassov
2020-08-28 6:15 ` Greg KH
2020-08-14 13:04 ` Greg KH
2020-08-28 0:05 ` Iouri Tarassov
2020-08-28 6:12 ` Greg KH
2020-09-03 18:55 ` Iouri Tarassov
2020-09-03 19:32 ` Greg KH
2020-08-14 13:18 ` Wei Liu
2020-08-26 20:20 ` Iouri Tarassov [this message]
2020-08-27 0:12 ` Iouri Tarassov
2020-08-27 19:09 ` Iouri Tarassov
2020-08-21 13:53 ` Pavel Machek
2020-08-28 0:25 ` Iouri Tarassov
2020-08-28 6:17 ` Greg KH
2020-08-28 6:18 ` Greg KH
2020-09-03 21:39 ` Iouri Tarassov
2020-09-04 5:18 ` Greg KH
2020-08-14 12:38 ` [PATCH 2/4] drivers: hv: dxgkrnl: hook up dxgkrnl Sasha Levin
2020-08-14 12:38 ` [PATCH 3/4] drivers: hv: vmbus: " Sasha Levin
2020-08-14 12:38 ` [PATCH 4/4] drivers: hv: dxgkrnl: create a MAINTAINERS entry Sasha Levin
2020-08-14 13:04 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7db18ff7-e99b-62db-508e-a6054c9ac3f9@linux.microsoft.com \
--to=iourit@linux.microsoft.com \
--cc=gregkh@linuxfoundation.org \
--cc=haiyangz@microsoft.com \
--cc=iouri_t@hotmail.com \
--cc=iourit@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sthemmin@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).