From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5ABE0C49EA7 for ; Thu, 24 Jun 2021 16:22:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 421A1613DC for ; Thu, 24 Jun 2021 16:22:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232060AbhFXQZG (ORCPT ); Thu, 24 Jun 2021 12:25:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42248 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230334AbhFXQZE (ORCPT ); Thu, 24 Jun 2021 12:25:04 -0400 Received: from mail-pg1-x529.google.com (mail-pg1-x529.google.com [IPv6:2607:f8b0:4864:20::529]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DEAFDC061574; Thu, 24 Jun 2021 09:22:44 -0700 (PDT) Received: by mail-pg1-x529.google.com with SMTP id h4so5141853pgp.5; Thu, 24 Jun 2021 09:22:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=3/3dGj2HIX+HnqnTIkrn2ymOpUkKJX2RUtpja3yGqZg=; b=gRbh80efko0UHOzbtOODSQmAQPa3cEFTibRwGo4GbI0vOB6X3QYXefkM+qbGgWQ/SQ 0EkZrMQVJUkam/mC+LDtc3pKzYHXmhERmg+A7WgL5rV1aJNup7HM2a42gwicG5z1no9w GY2DTBeg8c3vwsjll9bioaTkmXthn8lAGWAUM/FQtUCxhjoFLJ+/i/j5Q5cjsPe11GQT Y63C4wOdkjWcE8MDjQckSWw/STHK7EfK7P2i14xNYRJheLTzeTwLZwSGTs7q32tT+Yhn 3b5QaI7qQp6l9yRd2dKxjylnY1jxoKkcdL8T4oBO1qgVWPtzC6K83AE3wwmorN1yZqg0 kiNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=3/3dGj2HIX+HnqnTIkrn2ymOpUkKJX2RUtpja3yGqZg=; b=NTQuV/AY4jotca/EfCNeNISYTLJUjvErcJya5ETbVFvgpdPnwAhKmpSgq7sQK8zVEk 4xwanDDTUmcK0GvzErwNX7iYxNhEbKD16y+U51x/u0XK3nmaXt6NbDXI6AC3exrjuhKi MdhRaXgm8zLm7KqPKpn94ww/URTaPZNgc8OmTqvGstM2ttp3fTPK8BJdApJngsihcUy/ VvOKiZBzJKVXZQCE9sf/CKQMPPSQoKdY3qR/epldoKISjjM0ilVe97UW9SQDoYTUJztW cwSD518r4pL2BCv9KYYYdT8fjea0sVCUKvfjBUYp0lusJB89It9Nsu/G5VtTm7LXRkpq xeZA== X-Gm-Message-State: AOAM530S5FwPH4uhSbADKcK2ScJceeI4Q+k6DQRE/zqxIllTheZ8EObN Cjiq/Z9ftk+uZ9rRqtOHw1iruta7PPWIdg== X-Google-Smtp-Source: ABdhPJzxUpS0cVQifVC2919L/lkBqcK3L+x0bKhuPqlCJT2jVwG39zL+ioypFc9OPObDNA0CbFq27A== X-Received: by 2002:aa7:921a:0:b029:2cf:b55b:9d52 with SMTP id 26-20020aa7921a0000b02902cfb55b9d52mr5735259pfo.35.1624551764017; Thu, 24 Jun 2021 09:22:44 -0700 (PDT) Received: from [10.67.49.104] ([192.19.223.252]) by smtp.googlemail.com with ESMTPSA id 201sm3374506pfz.125.2021.06.24.09.22.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Jun 2021 09:22:43 -0700 (PDT) Subject: Re: [PATCH] pinctrl: bcm2835: Replace BUG with BUG_ON To: Jason Wang , linus.walleij@linaro.org Cc: nsaenz@kernel.org, rjui@broadcom.com, sbranden@broadcom.com, bcm-kernel-feedback-list@broadcom.com, phil@raspberrypi.com, iivanov@suse.de, linux-gpio@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20210624064913.41788-1-wangborong@cdjrlc.com> From: Florian Fainelli Message-ID: <7dd8b65e-0f89-9aa9-9eab-6cbc6c9495bb@gmail.com> Date: Thu, 24 Jun 2021 09:22:38 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210624064913.41788-1-wangborong@cdjrlc.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/23/21 11:49 PM, Jason Wang wrote: > The if condition followed by BUG can be replaced to BUG_ON which is > more compact and formal in linux source. > > Signed-off-by: Jason Wang Acked-by: Florian Fainelli Although I would rather completely remove this BUG_ON() and replace it with a WARN_ON() instead, no need to kill the machine for such a problem, however unlikely it is to appear. -- Florian