From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751806AbcFXP4S (ORCPT ); Fri, 24 Jun 2016 11:56:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45841 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751109AbcFXP4Q (ORCPT ); Fri, 24 Jun 2016 11:56:16 -0400 Subject: Re: [PATCH v10 07/22] IB/hns: Add event queue support To: Leon Romanovsky , Lijun Ou References: <1466087730-54856-1-git-send-email-oulijun@huawei.com> <1466087730-54856-8-git-send-email-oulijun@huawei.com> <20160624154643.GG23995@leon.nu> Cc: sean.hefty@intel.com, hal.rosenstock@gmail.com, davem@davemloft.net, jeffrey.t.kirsher@intel.com, jiri@mellanox.com, ogerlitz@mellanox.com, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, gongyangming@huawei.com, xiaokun@huawei.com, tangchaofei@huawei.com, haifeng.wei@huawei.com, yisen.zhuang@huawei.com, yankejian@huawei.com, charles.chenxin@huawei.com, linuxarm@huawei.com From: Doug Ledford Openpgp: id=AE6B1BDA122B23B4265B1274B826A3330E572FDD; url=pgp.mit.edu Organization: Red Hat, Inc. Message-ID: <7e1062ac-eabc-34ab-dd76-c8eb6b992307@redhat.com> Date: Fri, 24 Jun 2016 11:56:08 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <20160624154643.GG23995@leon.nu> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="xjbJiCkDKqqpJjd14JDlGKIuwcLvI5xn4" X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Fri, 24 Jun 2016 15:56:16 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --xjbJiCkDKqqpJjd14JDlGKIuwcLvI5xn4 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 06/24/2016 11:46 AM, Leon Romanovsky wrote: > On Thu, Jun 16, 2016 at 10:35:15PM +0800, Lijun Ou wrote: >> /*************ROCEE_REG DEFINITION****************/ >> #define ROCEE_VENDOR_ID_REG 0x0 >> @@ -44,8 +93,29 @@ >> #define ROCEE_SYS_IMAGE_GUID_L_REG 0xC >> #define ROCEE_SYS_IMAGE_GUID_H_REG 0x10 >> =20 >> +#define ROCEE_CAEP_AEQE_CONS_IDX_REG 0x3AC >> +#define ROCEE_CAEP_CEQC_CONS_IDX_0_REG 0x3BC >> + >> +#define ROCEE_ECC_UCERR_ALM1_REG 0xB38 >> +#define ROCEE_ECC_UCERR_ALM2_REG 0xB3C >> +#define ROCEE_ECC_CERR_ALM1_REG 0xB44 >> +#define ROCEE_ECC_CERR_ALM2_REG 0xB48 >> + >> #define ROCEE_ACK_DELAY_REG 0x14 >> =20 >> +#define ROCEE_CAEP_CE_INTERVAL_CFG_REG 0x190 >> +#define ROCEE_CAEP_CE_BURST_NUM_CFG_REG 0x194 >> + >> #define ROCEE_MB1_REG 0x210 >> =20 >> +#define ROCEE_CAEP_AEQC_AEQE_SHIFT_REG 0x3A0 >> +#define ROCEE_CAEP_CEQC_SHIFT_0_REG 0x3B0 >> +#define ROCEE_CAEP_CE_IRQ_MASK_0_REG 0x3C0 >> +#define ROCEE_CAEP_CEQ_ALM_OVF_0_REG 0x3C4 >> +#define ROCEE_CAEP_AE_MASK_REG 0x6C8 >> +#define ROCEE_CAEP_AE_ST_REG 0x6CC >> + >> +#define ROCEE_ECC_UCERR_ALM0_REG 0xB34 >> +#define ROCEE_ECC_CERR_ALM0_REG 0xB40 >=20 > Indentation I'm pretty sure this indentation is fine. When looking at patch file contents, the beginning of the line is shifted one char to the right, so when using tabs for indents, if the line would normally end at the final char before the next tab, and it gets shifted one char by the patch format, the contents on the other side of the indent get jumped an extra tab spot. You would have to look at it as a file to know for sure, but I'm betting you can ignore all of these indent issues. --=20 Doug Ledford GPG KeyID: 0E572FDD --xjbJiCkDKqqpJjd14JDlGKIuwcLvI5xn4 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBCAAGBQJXbVgYAAoJELgmozMOVy/d65sP/jBB+qVM4uaqCDmJnl3ICYb+ viXyhfh4lLHrmHY0MU7ZgdVCEQvIn1JWa1rKYe9QIvdRPmzgvV4osR91p3mULrVO LZD8ukeW+UDacLF7N3jjU9RrHyl/pd2rKF0t/kHckxbw33Xbl0dNO8OSngZ6xFLF P3fvxysyvGg8Fj1tKSDZI/zVKknsOHJpahwpiUaZ5pjtkKSXbTgjMTzgk4uU711V yRGq1UOme47Cx1GX1y9+Sq6VVSWSR80ujzfFd+8xo9Izzbpb9aDBIF4t50hkmJkd iswJINI3l1US4bZPgl6eRxD7J8bP92EShvHIfUgIjE69U/kppGcyP0xc/YNG/LJZ gaOyVquXQVXjOUx1l1NVOgo51qpr2deGfJAepcznEdVIX9wlq8/r3nMlg8ARFYQB DPMxUjIkspdk3/j+pdWJPMjCKbF1uXPMV6fsBCgpuKD2YNFFVGVZipbvAUXQrO/3 AkWNKMtQZ12u0JEmWecrAxM3Rek+Hlpdv2sffk3pD8EJEzzVJ2D558Zk1V1Wa4DX pK36EZB2dC3H3gW6rYoryKX1jwrx43GwvW4TcZ5pVYh31QOWgi1g1MJXAXiXdy6V b3WJehRWz0/z4lpc9YrE9P4NmxZUDSNbX4NBhd1h7W/PImvNJxLqYTld7FkbD7sv X+stoGRPboCV4jfJeoZ8 =kgu/ -----END PGP SIGNATURE----- --xjbJiCkDKqqpJjd14JDlGKIuwcLvI5xn4--